| Message ID | 20161117183541.8588-6-bigeasy@linutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, Nov 17, 2016 at 07:35:26PM +0100, Sebastian Andrzej Siewior wrote: > From: Thomas Gleixner <tglx@linutronix.de> > > The check loop for the cpu type is pointless as we already have a cpu model > match before that. The only thing which is not covered by that check would > be a smp system with two different cores. Not likely to happen. > > Cc: Jean Delvare <jdelvare@suse.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: linux-hwmon@vger.kernel.org > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Applied to -next. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2016-11-19 09:23:31 [-0800], Guenter Roeck wrote: > Applied to -next. Thanks. Since you took that one, could you also please consider to apply |[PATCH 06/20 v2] hwmon/via-cputemp: Convert to hotplug state machine ? It depends on the 5th patch from the series which applied. > Thanks, > Guenter Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/19/2016 02:53 PM, Sebastian Andrzej Siewior wrote: > On 2016-11-19 09:23:31 [-0800], Guenter Roeck wrote: >> Applied to -next. > > Thanks. Since you took that one, could you also please consider to apply > |[PATCH 06/20 v2] hwmon/via-cputemp: Convert to hotplug state machine > ? It depends on the 5th patch from the series which applied. > Problem is that I have no idea if any of the patches in this series really work. I wasn't copied on all patches, meaning I don't have the infrastructure, meaning I'll have to dig them up from patchwork for testing, and/or figure out if the required infrastructure is already in the kernel, and that all takes time. Just Acking or applying the the patches w/o testing doesn't seem appropriate, given their level of intrusiveness. I did spend most of today working through my backlog of hwmon patches, but that series simply was too much. I hope I'll get to it tomorrow, but no promises. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2016-11-19 19:53:21 [-0800], Guenter Roeck wrote: > Problem is that I have no idea if any of the patches in this series really work. > I wasn't copied on all patches, meaning I don't have the infrastructure, meaning > I'll have to dig them up from patchwork for testing, and/or figure out if the > required infrastructure is already in the kernel, and that all takes time. > Just Acking or applying the the patches w/o testing doesn't seem appropriate, > given their level of intrusiveness. I did spend most of today working through > my backlog of hwmon patches, but that series simply was too much. I hope I'll > get to it tomorrow, but no promises. You don't have to dig all the patches from the series. Patch four and five are via-cputemp related and independent of the others and you were on Cc: on both of them. The other 18 patches were converting other drivers for instance: [PATCH 01/20] x86/mce/therm_throt: Convert to hotplug state machine [PATCH 02/20] x86/cpuid: Convert to hotplug state machine [PATCH 03/20] x86/msr: Convert to hotplug state machine Infrastructure. The DYN allocation is available since 5b7aa87e0482 ("cpu/hotplug: Implement setup/removal interface") which is part of part of v4.6-rc1. So testing them on v4.8 should be enough :) > Guenter Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hwmon/via-cputemp.c b/drivers/hwmon/via-cputemp.c index ac91c07e3f90..5b9866b1b437 100644 --- a/drivers/hwmon/via-cputemp.c +++ b/drivers/hwmon/via-cputemp.c @@ -319,22 +319,8 @@ static int __init via_cputemp_init(void) goto exit; cpu_notifier_register_begin(); - for_each_online_cpu(i) { - struct cpuinfo_x86 *c = &cpu_data(i); - - if (c->x86 != 6) - continue; - - if (c->x86_model < 0x0a) - continue; - - if (c->x86_model > 0x0f) { - pr_warn("Unknown CPU model 0x%x\n", c->x86_model); - continue; - } - + for_each_online_cpu(i) via_cputemp_device_add(i); - } #ifndef CONFIG_HOTPLUG_CPU if (list_empty(&pdev_list)) {