| Message ID | 1479822362-4749-2-git-send-email-chris.paterson2@renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On Tue, Nov 22, 2016 at 2:46 PM, Chris Paterson <chris.paterson2@renesas.com> wrote: > Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com> > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Chris, On Wed, Nov 23, 2016 at 9:03 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Tue, Nov 22, 2016 at 2:46 PM, Chris Paterson > <chris.paterson2@renesas.com> wrote: >> Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com> >> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> BTW, as all patches in this series were Signed-off-by Ramesh first, does that mean he's the author, and you should have added his From: line, too? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hello Geert, Thank you for the review. > -----Original Message----- > From: geert.uytterhoeven@gmail.com > [mailto:geert.uytterhoeven@gmail.com] On Behalf Of Geert Uytterhoeven > Sent: 23 November 2016 08:06 > To: Chris Paterson <Chris.Paterson2@renesas.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>; Michael Turquette > <mturquette@baylibre.com>; Stephen Boyd <sboyd@codeaurora.org>; > Linux-Renesas <linux-renesas-soc@vger.kernel.org>; linux-clk <linux- > clk@vger.kernel.org>; Ramesh Shanmugasundaram > <ramesh.shanmugasundaram@bp.renesas.com> > Subject: Re: [PATCH 1/3] clk: renesas: r8a7796: Add CAN peripheral clock > > Hi Chris, > > On Wed, Nov 23, 2016 at 9:03 AM, Geert Uytterhoeven <geert@linux- > m68k.org> wrote: > > On Tue, Nov 22, 2016 at 2:46 PM, Chris Paterson > > <chris.paterson2@renesas.com> wrote: > >> Signed-off-by: Ramesh Shanmugasundaram > >> <ramesh.shanmugasundaram@bp.renesas.com> > >> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > BTW, as all patches in this series were Signed-off-by Ramesh first, does that > mean he's the author, and you should have added his From: line, too? Technically I authored these patches, but they are direct ports from Ramesh's r8a7795 patches [1][2][3]. [1] 11c6fb7 clk: shmobile: r8a7795: Add CAN peripheral clock [2] 7e00d631 clk: shmobile: r8a7795: Add CANFD clock [3] a080c8c clk: shmobile: r8a7795: Add CAN FD peripheral clock Apologies for not making this clear in the cover letter. Kind regards, Chris > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Chris, On Wed, Nov 23, 2016 at 9:39 AM, Chris Paterson <Chris.Paterson2@renesas.com> wrote: >> On Wed, Nov 23, 2016 at 9:03 AM, Geert Uytterhoeven <geert@linux- >> m68k.org> wrote: >> > On Tue, Nov 22, 2016 at 2:46 PM, Chris Paterson >> > <chris.paterson2@renesas.com> wrote: >> >> Signed-off-by: Ramesh Shanmugasundaram >> >> <ramesh.shanmugasundaram@bp.renesas.com> >> >> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> >> >> BTW, as all patches in this series were Signed-off-by Ramesh first, does that >> mean he's the author, and you should have added his From: line, too? > > Technically I authored these patches, but they are direct ports from Ramesh's r8a7795 patches [1][2][3]. OK, I'll replace his SoB by "based on patches for r8a7795 by Ramesh...". Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c b/drivers/clk/renesas/r8a7796-cpg-mssr.c index 7d298c5..99b19ce 100644 --- a/drivers/clk/renesas/r8a7796-cpg-mssr.c +++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c @@ -181,6 +181,8 @@ enum clk_ids { DEF_MOD("gpio2", 910, R8A7796_CLK_S3D4), DEF_MOD("gpio1", 911, R8A7796_CLK_S3D4), DEF_MOD("gpio0", 912, R8A7796_CLK_S3D4), + DEF_MOD("can-if1", 915, R8A7796_CLK_S3D4), + DEF_MOD("can-if0", 916, R8A7796_CLK_S3D4), DEF_MOD("i2c6", 918, R8A7796_CLK_S0D6), DEF_MOD("i2c5", 919, R8A7796_CLK_S0D6), DEF_MOD("i2c4", 927, R8A7796_CLK_S0D6),