| Message ID | a6358997-0e19-05b6-e488-3a17bdac5952@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 11/23/2016 09:31 PM, Jaehoon Chung wrote: > On 11/23/2016 08:50 PM, Jaehoon Chung wrote: >> On 11/23/2016 08:47 PM, Ulf Hansson wrote: >>> On 22 November 2016 at 17:13, Ulf Hansson <ulf.hansson@linaro.org> wrote: >>>> On 22 November 2016 at 10:59, Jaehoon Chung <jh80.chung@samsung.com> wrote: >>>>> Dear Ulf, >>>>> >>>>> Could you pull these patches on your next branch? >>>>> If there is a problem, let me know, plz. >>>>> >>>>> The following changes since commit e2081b37d910c5e6c6925d9b4d0a7a6283f84ec5: >>>>> >>>>> Merge branch 'fixes' into next (2016-11-21 11:09:18 +0100) >>>>> >>>>> are available in the git repository at: >>>>> >>>>> https://github.com/jh80chung/dw-mmc.git for-ulf >>>>> >>>>> for you to fetch changes up to e25fd245b557482a8e0f7ab87841085f30706f3a: >>>>> >>>>> Documentation: synopsys-dw-mshc: remove the unused properties (2016-11-22 10:34:05 +0900) >>>>> >>>>> ---------------------------------------------------------------- >>>>> Colin Ian King (1): >>>>> mmc: dw_mmc: fix spelling mistake in dev_dbg message >>>>> >>>>> Jaehoon Chung (9): >>>>> mmc: dw_mmc: display the real register value on debugfs >>>>> mmc: dw_mmc: fix the debug message for checking card's present >>>>> mmc: dw_mmc: change the DW_MCI_FREQ_MIN from 400K to 100K >>>>> mmc: dw_mmc: use the hold register when send stop command >>>>> mmc: dw_mmc: call the dw_mci_prep_stop_abort() by default >>>>> mmc: dw_mmc: use the cookie's enum values for post/pre_req() >>>>> mmc: dw_mmc: remove the unnecessary mmc_data structure >>>>> mmc: dw_mmc: The "clock-freq-min-max" property was deprecated >>>>> Documentation: synopsys-dw-mshc: remove the unused properties >>>>> >>>>> Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt | 8 ++------ >>>>> drivers/mmc/host/dw_mmc.c | 92 ++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------ >>>>> include/linux/mmc/dw_mmc.h | 6 ++++++ >>>>> 3 files changed, 52 insertions(+), 54 deletions(-) >>>>> >>>>> Best Regards, >>>>> Jaehoon Chung >>>> >>>> Dear Jaehoon, thanks for the pull request. I have add queued it all up >>>> for my next branch! >>>> >>>> >>>> Kind regards >>>> Uffe >>> >>> Jaehoon, >>> >>> It seems like some of these patches breaks Exynos 5250-arndale. Can >>> you please have a look and see what you think? >>> https://kernelci.org/boot/all/job/ulfh/kernel/v4.9-rc5-78-g52eb5d4531e4/ >> >> I will check and reply. Thanks for noticing. Ulf, It's strange..My patches didn't have any dependency... There is no any log for dwmmc..and even it doesn't initialize dwmmc controller. Did you think that this failure is my patches problem? What is your thinking? Best Regards, Jaehoon Chung > > Ulf, > > I'm not sure but if more stable than now..i think that needs to check NULL pointer. > What do you want how i do? Send patch or revert commit? > > I didn't have the 5250-arndale..so i can't test..How about the below? > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 881ca3e..7a0cb97 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -167,12 +167,14 @@ static int dw_mci_regs_show(struct seq_file *s, void *v) > { > struct dw_mci *host = s->private; > > - seq_printf(s, "STATUS:\t0x%08x\n", mci_readl(host, STATUS)); > - seq_printf(s, "RINTSTS:\t0x%08x\n", mci_readl(host, RINTSTS)); > - seq_printf(s, "CMD:\t0x%08x\n", mci_readl(host, CMD)); > - seq_printf(s, "CTRL:\t0x%08x\n", mci_readl(host, CTRL)); > - seq_printf(s, "INTMASK:\t0x%08x\n", mci_readl(host, INTMASK)); > - seq_printf(s, "CLKENA:\t0x%08x\n", mci_readl(host, CLKENA)); > + if (host->regs) { > + seq_printf(s, "STATUS:\t0x%08x\n", mci_readl(host, STATUS)); > + seq_printf(s, "RINTSTS:\t0x%08x\n", mci_readl(host, RINTSTS)); > + seq_printf(s, "CMD:\t0x%08x\n", mci_readl(host, CMD)); > + seq_printf(s, "CTRL:\t0x%08x\n", mci_readl(host, CTRL)); > + seq_printf(s, "INTMASK:\t0x%08x\n", mci_readl(host, INTMASK)); > + seq_printf(s, "CLKENA:\t0x%08x\n", mci_readl(host, CLKENA)); > + } > > return 0; > } > > Best Regards, > Jaehoon Chung > >> >> Beset Regards, >> Jaehoon Chung >> >>> >>> Kind regards >>> Uffe >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >>> >>> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 24 November 2016 at 12:17, Jaehoon Chung <jh80.chung@samsung.com> wrote: > On 11/23/2016 09:31 PM, Jaehoon Chung wrote: >> On 11/23/2016 08:50 PM, Jaehoon Chung wrote: >>> On 11/23/2016 08:47 PM, Ulf Hansson wrote: >>>> On 22 November 2016 at 17:13, Ulf Hansson <ulf.hansson@linaro.org> wrote: >>>>> On 22 November 2016 at 10:59, Jaehoon Chung <jh80.chung@samsung.com> wrote: >>>>>> Dear Ulf, >>>>>> >>>>>> Could you pull these patches on your next branch? >>>>>> If there is a problem, let me know, plz. >>>>>> >>>>>> The following changes since commit e2081b37d910c5e6c6925d9b4d0a7a6283f84ec5: >>>>>> >>>>>> Merge branch 'fixes' into next (2016-11-21 11:09:18 +0100) >>>>>> >>>>>> are available in the git repository at: >>>>>> >>>>>> https://github.com/jh80chung/dw-mmc.git for-ulf >>>>>> >>>>>> for you to fetch changes up to e25fd245b557482a8e0f7ab87841085f30706f3a: >>>>>> >>>>>> Documentation: synopsys-dw-mshc: remove the unused properties (2016-11-22 10:34:05 +0900) >>>>>> >>>>>> ---------------------------------------------------------------- >>>>>> Colin Ian King (1): >>>>>> mmc: dw_mmc: fix spelling mistake in dev_dbg message >>>>>> >>>>>> Jaehoon Chung (9): >>>>>> mmc: dw_mmc: display the real register value on debugfs >>>>>> mmc: dw_mmc: fix the debug message for checking card's present >>>>>> mmc: dw_mmc: change the DW_MCI_FREQ_MIN from 400K to 100K >>>>>> mmc: dw_mmc: use the hold register when send stop command >>>>>> mmc: dw_mmc: call the dw_mci_prep_stop_abort() by default >>>>>> mmc: dw_mmc: use the cookie's enum values for post/pre_req() >>>>>> mmc: dw_mmc: remove the unnecessary mmc_data structure >>>>>> mmc: dw_mmc: The "clock-freq-min-max" property was deprecated >>>>>> Documentation: synopsys-dw-mshc: remove the unused properties >>>>>> >>>>>> Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt | 8 ++------ >>>>>> drivers/mmc/host/dw_mmc.c | 92 ++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------ >>>>>> include/linux/mmc/dw_mmc.h | 6 ++++++ >>>>>> 3 files changed, 52 insertions(+), 54 deletions(-) >>>>>> >>>>>> Best Regards, >>>>>> Jaehoon Chung >>>>> >>>>> Dear Jaehoon, thanks for the pull request. I have add queued it all up >>>>> for my next branch! >>>>> >>>>> >>>>> Kind regards >>>>> Uffe >>>> >>>> Jaehoon, >>>> >>>> It seems like some of these patches breaks Exynos 5250-arndale. Can >>>> you please have a look and see what you think? >>>> https://kernelci.org/boot/all/job/ulfh/kernel/v4.9-rc5-78-g52eb5d4531e4/ >>> >>> I will check and reply. Thanks for noticing. > > Ulf, > > It's strange..My patches didn't have any dependency... > There is no any log for dwmmc..and even it doesn't initialize dwmmc controller. > > Did you think that this failure is my patches problem? What is your thinking? Well, I don't know but indeed it seems a bit odd. Maybe there are some interdependency that changes the behaviour for something outside dw_mmc, which triggers the problems!? It could of course also be completely unrelated. I do have the Arndale board available. I will try it out within a couple of days, to see if I can find something. [...] Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/24/2016 08:43 PM, Ulf Hansson wrote: > On 24 November 2016 at 12:17, Jaehoon Chung <jh80.chung@samsung.com> wrote: >> On 11/23/2016 09:31 PM, Jaehoon Chung wrote: >>> On 11/23/2016 08:50 PM, Jaehoon Chung wrote: >>>> On 11/23/2016 08:47 PM, Ulf Hansson wrote: >>>>> On 22 November 2016 at 17:13, Ulf Hansson <ulf.hansson@linaro.org> wrote: >>>>>> On 22 November 2016 at 10:59, Jaehoon Chung <jh80.chung@samsung.com> wrote: >>>>>>> Dear Ulf, >>>>>>> >>>>>>> Could you pull these patches on your next branch? >>>>>>> If there is a problem, let me know, plz. >>>>>>> >>>>>>> The following changes since commit e2081b37d910c5e6c6925d9b4d0a7a6283f84ec5: >>>>>>> >>>>>>> Merge branch 'fixes' into next (2016-11-21 11:09:18 +0100) >>>>>>> >>>>>>> are available in the git repository at: >>>>>>> >>>>>>> https://github.com/jh80chung/dw-mmc.git for-ulf >>>>>>> >>>>>>> for you to fetch changes up to e25fd245b557482a8e0f7ab87841085f30706f3a: >>>>>>> >>>>>>> Documentation: synopsys-dw-mshc: remove the unused properties (2016-11-22 10:34:05 +0900) >>>>>>> >>>>>>> ---------------------------------------------------------------- >>>>>>> Colin Ian King (1): >>>>>>> mmc: dw_mmc: fix spelling mistake in dev_dbg message >>>>>>> >>>>>>> Jaehoon Chung (9): >>>>>>> mmc: dw_mmc: display the real register value on debugfs >>>>>>> mmc: dw_mmc: fix the debug message for checking card's present >>>>>>> mmc: dw_mmc: change the DW_MCI_FREQ_MIN from 400K to 100K >>>>>>> mmc: dw_mmc: use the hold register when send stop command >>>>>>> mmc: dw_mmc: call the dw_mci_prep_stop_abort() by default >>>>>>> mmc: dw_mmc: use the cookie's enum values for post/pre_req() >>>>>>> mmc: dw_mmc: remove the unnecessary mmc_data structure >>>>>>> mmc: dw_mmc: The "clock-freq-min-max" property was deprecated >>>>>>> Documentation: synopsys-dw-mshc: remove the unused properties >>>>>>> >>>>>>> Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt | 8 ++------ >>>>>>> drivers/mmc/host/dw_mmc.c | 92 ++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------ >>>>>>> include/linux/mmc/dw_mmc.h | 6 ++++++ >>>>>>> 3 files changed, 52 insertions(+), 54 deletions(-) >>>>>>> >>>>>>> Best Regards, >>>>>>> Jaehoon Chung >>>>>> >>>>>> Dear Jaehoon, thanks for the pull request. I have add queued it all up >>>>>> for my next branch! >>>>>> >>>>>> >>>>>> Kind regards >>>>>> Uffe >>>>> >>>>> Jaehoon, >>>>> >>>>> It seems like some of these patches breaks Exynos 5250-arndale. Can >>>>> you please have a look and see what you think? >>>>> https://kernelci.org/boot/all/job/ulfh/kernel/v4.9-rc5-78-g52eb5d4531e4/ >>>> >>>> I will check and reply. Thanks for noticing. >> >> Ulf, >> >> It's strange..My patches didn't have any dependency... >> There is no any log for dwmmc..and even it doesn't initialize dwmmc controller. >> >> Did you think that this failure is my patches problem? What is your thinking? > > Well, I don't know but indeed it seems a bit odd. Maybe there are some > interdependency that changes the behaviour for something outside > dw_mmc, which triggers the problems!? > > It could of course also be completely unrelated. > > I do have the Arndale board available. I will try it out within a > couple of days, to see if I can find something. If there is effect..it seems that only below patch for clock.. commit 38332b0fd6c06fcecc64bc238bbb7cf80ed6bc7b Author: Jaehoon Chung <jh80.chung@samsung.com> Date: Thu Nov 17 16:40:35 2016 +0900 mmc: dw_mmc: change the DW_MCI_FREQ_MIN from 400K to 100K If there is no property "clock-freq-min-max", mmc->f_min should be set to 400K by default. But Some SoC can be used 100K. When 100K is used, MMC core will try to check from 400K to 100K. otherwise timing? I wonder when the below patches is applied, what happen.. https://patchwork.kernel.org/patch/9445233/ https://patchwork.kernel.org/patch/9445209/ https://patchwork.kernel.org/patch/9445211/ I will also check this continuously..to find before PR for next. Best Regards, Jaehoon Chung > > [...] > > Kind regards > Uffe > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/24/2016 08:50 PM, Jaehoon Chung wrote: > On 11/24/2016 08:43 PM, Ulf Hansson wrote: >> On 24 November 2016 at 12:17, Jaehoon Chung <jh80.chung@samsung.com> wrote: >>> On 11/23/2016 09:31 PM, Jaehoon Chung wrote: >>>> On 11/23/2016 08:50 PM, Jaehoon Chung wrote: >>>>> On 11/23/2016 08:47 PM, Ulf Hansson wrote: >>>>>> On 22 November 2016 at 17:13, Ulf Hansson <ulf.hansson@linaro.org> wrote: >>>>>>> On 22 November 2016 at 10:59, Jaehoon Chung <jh80.chung@samsung.com> wrote: >>>>>>>> Dear Ulf, >>>>>>>> >>>>>>>> Could you pull these patches on your next branch? >>>>>>>> If there is a problem, let me know, plz. >>>>>>>> >>>>>>>> The following changes since commit e2081b37d910c5e6c6925d9b4d0a7a6283f84ec5: >>>>>>>> >>>>>>>> Merge branch 'fixes' into next (2016-11-21 11:09:18 +0100) >>>>>>>> >>>>>>>> are available in the git repository at: >>>>>>>> >>>>>>>> https://github.com/jh80chung/dw-mmc.git for-ulf >>>>>>>> >>>>>>>> for you to fetch changes up to e25fd245b557482a8e0f7ab87841085f30706f3a: >>>>>>>> >>>>>>>> Documentation: synopsys-dw-mshc: remove the unused properties (2016-11-22 10:34:05 +0900) >>>>>>>> >>>>>>>> ---------------------------------------------------------------- >>>>>>>> Colin Ian King (1): >>>>>>>> mmc: dw_mmc: fix spelling mistake in dev_dbg message >>>>>>>> >>>>>>>> Jaehoon Chung (9): >>>>>>>> mmc: dw_mmc: display the real register value on debugfs >>>>>>>> mmc: dw_mmc: fix the debug message for checking card's present >>>>>>>> mmc: dw_mmc: change the DW_MCI_FREQ_MIN from 400K to 100K >>>>>>>> mmc: dw_mmc: use the hold register when send stop command >>>>>>>> mmc: dw_mmc: call the dw_mci_prep_stop_abort() by default >>>>>>>> mmc: dw_mmc: use the cookie's enum values for post/pre_req() >>>>>>>> mmc: dw_mmc: remove the unnecessary mmc_data structure >>>>>>>> mmc: dw_mmc: The "clock-freq-min-max" property was deprecated >>>>>>>> Documentation: synopsys-dw-mshc: remove the unused properties >>>>>>>> >>>>>>>> Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt | 8 ++------ >>>>>>>> drivers/mmc/host/dw_mmc.c | 92 ++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------ >>>>>>>> include/linux/mmc/dw_mmc.h | 6 ++++++ >>>>>>>> 3 files changed, 52 insertions(+), 54 deletions(-) >>>>>>>> >>>>>>>> Best Regards, >>>>>>>> Jaehoon Chung >>>>>>> >>>>>>> Dear Jaehoon, thanks for the pull request. I have add queued it all up >>>>>>> for my next branch! >>>>>>> >>>>>>> >>>>>>> Kind regards >>>>>>> Uffe >>>>>> >>>>>> Jaehoon, >>>>>> >>>>>> It seems like some of these patches breaks Exynos 5250-arndale. Can >>>>>> you please have a look and see what you think? >>>>>> https://kernelci.org/boot/all/job/ulfh/kernel/v4.9-rc5-78-g52eb5d4531e4/ >>>>> >>>>> I will check and reply. Thanks for noticing. >>> >>> Ulf, >>> >>> It's strange..My patches didn't have any dependency... >>> There is no any log for dwmmc..and even it doesn't initialize dwmmc controller. >>> >>> Did you think that this failure is my patches problem? What is your thinking? >> >> Well, I don't know but indeed it seems a bit odd. Maybe there are some >> interdependency that changes the behaviour for something outside >> dw_mmc, which triggers the problems!? >> >> It could of course also be completely unrelated. >> >> I do have the Arndale board available. I will try it out within a >> couple of days, to see if I can find something. > > If there is effect..it seems that only below patch for clock.. > > commit 38332b0fd6c06fcecc64bc238bbb7cf80ed6bc7b > Author: Jaehoon Chung <jh80.chung@samsung.com> > Date: Thu Nov 17 16:40:35 2016 +0900 > > mmc: dw_mmc: change the DW_MCI_FREQ_MIN from 400K to 100K > > If there is no property "clock-freq-min-max", mmc->f_min should be set > to 400K by default. But Some SoC can be used 100K. > When 100K is used, MMC core will try to check from 400K to 100K. > > otherwise timing? > > I wonder when the below patches is applied, what happen.. > > https://patchwork.kernel.org/patch/9445233/ > https://patchwork.kernel.org/patch/9445209/ > https://patchwork.kernel.org/patch/9445211/ > > I will also check this continuously..to find before PR for next. Dear Ulf, It seems that related to the below patch. https://lkml.org/lkml/2016/9/15/170 commit 212ca7c839abbec1d5ef4f29206b66b42192db22 Refs: v4.9-rc1-29-g212ca7c Author: Viresh Kumar <viresh.kumar@linaro.org> AuthorDate: Thu Oct 27 15:50:18 2016 +0530 Commit: Lee Jones <lee.jones@linaro.org> CommitDate: Mon Nov 21 13:00:28 2016 +0000 Applied on v4.9-rc1..but i don't know why occurred this error. Could you rebase your branch on v4.9-rc5 again? Best Regards, Jaehoon Chung > > Best Regards, > Jaehoon Chung > >> >> [...] >> >> Kind regards >> Uffe >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 881ca3e..7a0cb97 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -167,12 +167,14 @@ static int dw_mci_regs_show(struct seq_file *s, void *v) { struct dw_mci *host = s->private; - seq_printf(s, "STATUS:\t0x%08x\n", mci_readl(host, STATUS)); - seq_printf(s, "RINTSTS:\t0x%08x\n", mci_readl(host, RINTSTS)); - seq_printf(s, "CMD:\t0x%08x\n", mci_readl(host, CMD)); - seq_printf(s, "CTRL:\t0x%08x\n", mci_readl(host, CTRL)); - seq_printf(s, "INTMASK:\t0x%08x\n", mci_readl(host, INTMASK)); - seq_printf(s, "CLKENA:\t0x%08x\n", mci_readl(host, CLKENA)); + if (host->regs) { + seq_printf(s, "STATUS:\t0x%08x\n", mci_readl(host, STATUS)); + seq_printf(s, "RINTSTS:\t0x%08x\n", mci_readl(host, RINTSTS)); + seq_printf(s, "CMD:\t0x%08x\n", mci_readl(host, CMD)); + seq_printf(s, "CTRL:\t0x%08x\n", mci_readl(host, CTRL)); + seq_printf(s, "INTMASK:\t0x%08x\n", mci_readl(host, INTMASK)); + seq_printf(s, "CLKENA:\t0x%08x\n", mci_readl(host, CLKENA)); + } return 0; }