| Message ID | 1480000463-9625-4-git-send-email-benjamin.gaignard@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 24/11/16 15:14, Benjamin Gaignard wrote: > Define bindings for pwm-stm32 > > version 2: > - use parameters instead of compatible of handle the hardware configuration > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > --- > .../devicetree/bindings/pwm/pwm-stm32.txt | 37 ++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-stm32.txt > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-stm32.txt b/Documentation/devicetree/bindings/pwm/pwm-stm32.txt > new file mode 100644 > index 0000000..36263f0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/pwm-stm32.txt > @@ -0,0 +1,37 @@ > +STMicroelectronics PWM driver bindings for STM32 > + > +Must be a sub-node of STM32 general purpose timer driver > + > +Required parameters: > +- compatible: Must be "st,stm32-pwm" > +- pinctrl-names: Set to "default". > +- pinctrl-0: List of phandles pointing to pin configuration nodes > + for PWM module. > + For Pinctrl properties, please refer to [1]. > + > +Optional parameters: > +- st,breakinput: Set if the hardware have break input capabilities > +- st,breakinput-polarity: Set break input polarity. Default is 0 > + The value define the active polarity: > + - 0 (active LOW) > + - 1 (active HIGH) > +- st,pwm-num-chan: Number of available PWM channels. Default is 0. > +- st,32bits-counter: Set if the hardware have a 32 bits counter > +- st,complementary: Set if the hardware have complementary output channels > + > +[1] Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > + > +Example: > + gptimer1: gptimer1@40010000 { Given the example includes chunks for the other binding, make sure to have explicit cross references in the document. > + compatible = "st,stm32-gptimer"; > + reg = <0x40010000 0x400>; > + clocks = <&rcc 0 160>; > + clock-names = "clk_int"; > + > + pwm1@0 { > + compatible = "st,stm32-pwm"; > + st,pwm-num-chan = <4>; > + st,breakinput; > + st,complementary; > + }; > + }; >
On Thu, Nov 24, 2016 at 04:14:19PM +0100, Benjamin Gaignard wrote: > Define bindings for pwm-stm32 > > version 2: > - use parameters instead of compatible of handle the hardware configuration > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > --- > .../devicetree/bindings/pwm/pwm-stm32.txt | 37 ++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-stm32.txt > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-stm32.txt b/Documentation/devicetree/bindings/pwm/pwm-stm32.txt > new file mode 100644 > index 0000000..36263f0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/pwm-stm32.txt > @@ -0,0 +1,37 @@ > +STMicroelectronics PWM driver bindings for STM32 > + > +Must be a sub-node of STM32 general purpose timer driver > + > +Required parameters: > +- compatible: Must be "st,stm32-pwm" > +- pinctrl-names: Set to "default". > +- pinctrl-0: List of phandles pointing to pin configuration nodes > + for PWM module. > + For Pinctrl properties, please refer to [1]. > + > +Optional parameters: > +- st,breakinput: Set if the hardware have break input capabilities > +- st,breakinput-polarity: Set break input polarity. Default is 0 > + The value define the active polarity: > + - 0 (active LOW) > + - 1 (active HIGH) > +- st,pwm-num-chan: Number of available PWM channels. Default is 0. > +- st,32bits-counter: Set if the hardware have a 32 bits counter > +- st,complementary: Set if the hardware have complementary output channels What does complementary mean here? > + > +[1] Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > + > +Example: > + gptimer1: gptimer1@40010000 { timer@... > + compatible = "st,stm32-gptimer"; > + reg = <0x40010000 0x400>; > + clocks = <&rcc 0 160>; > + clock-names = "clk_int"; > + > + pwm1@0 { pwm { Is there more than one? > + compatible = "st,stm32-pwm"; > + st,pwm-num-chan = <4>; > + st,breakinput; > + st,complementary; > + }; > + }; > -- > 1.9.1 >
2016-11-30 22:20 GMT+01:00 Rob Herring <robh@kernel.org>: > On Thu, Nov 24, 2016 at 04:14:19PM +0100, Benjamin Gaignard wrote: >> Define bindings for pwm-stm32 >> >> version 2: >> - use parameters instead of compatible of handle the hardware configuration >> >> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> >> --- >> .../devicetree/bindings/pwm/pwm-stm32.txt | 37 ++++++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-stm32.txt >> >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-stm32.txt b/Documentation/devicetree/bindings/pwm/pwm-stm32.txt >> new file mode 100644 >> index 0000000..36263f0 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pwm/pwm-stm32.txt >> @@ -0,0 +1,37 @@ >> +STMicroelectronics PWM driver bindings for STM32 >> + >> +Must be a sub-node of STM32 general purpose timer driver >> + >> +Required parameters: >> +- compatible: Must be "st,stm32-pwm" >> +- pinctrl-names: Set to "default". >> +- pinctrl-0: List of phandles pointing to pin configuration nodes >> + for PWM module. >> + For Pinctrl properties, please refer to [1]. >> + >> +Optional parameters: >> +- st,breakinput: Set if the hardware have break input capabilities >> +- st,breakinput-polarity: Set break input polarity. Default is 0 >> + The value define the active polarity: >> + - 0 (active LOW) >> + - 1 (active HIGH) >> +- st,pwm-num-chan: Number of available PWM channels. Default is 0. >> +- st,32bits-counter: Set if the hardware have a 32 bits counter >> +- st,complementary: Set if the hardware have complementary output channels > > What does complementary mean here? Complementary channels are pwm channels where the signal level is inverted compare to the original channel. This parameter indicate that the hardware have this kind of outputs. If the polarity of the original channel change then polarity of complementary channel change too. > >> + >> +[1] Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt >> + >> +Example: >> + gptimer1: gptimer1@40010000 { > > timer@... I would like keep "timer" for timer-trigger sub-node > >> + compatible = "st,stm32-gptimer"; >> + reg = <0x40010000 0x400>; >> + clocks = <&rcc 0 160>; >> + clock-names = "clk_int"; >> + >> + pwm1@0 { > > pwm { > > Is there more than one? Not per hardware block but their is 12 of them in the SoC. Adding a number (which match with SoC documentation) help to find the wanted pwm in sysfs either we only have the address. > >> + compatible = "st,stm32-pwm"; >> + st,pwm-num-chan = <4>; >> + st,breakinput; >> + st,complementary; >> + }; >> + }; >> -- >> 1.9.1 >>
diff --git a/Documentation/devicetree/bindings/pwm/pwm-stm32.txt b/Documentation/devicetree/bindings/pwm/pwm-stm32.txt new file mode 100644 index 0000000..36263f0 --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/pwm-stm32.txt @@ -0,0 +1,37 @@ +STMicroelectronics PWM driver bindings for STM32 + +Must be a sub-node of STM32 general purpose timer driver + +Required parameters: +- compatible: Must be "st,stm32-pwm" +- pinctrl-names: Set to "default". +- pinctrl-0: List of phandles pointing to pin configuration nodes + for PWM module. + For Pinctrl properties, please refer to [1]. + +Optional parameters: +- st,breakinput: Set if the hardware have break input capabilities +- st,breakinput-polarity: Set break input polarity. Default is 0 + The value define the active polarity: + - 0 (active LOW) + - 1 (active HIGH) +- st,pwm-num-chan: Number of available PWM channels. Default is 0. +- st,32bits-counter: Set if the hardware have a 32 bits counter +- st,complementary: Set if the hardware have complementary output channels + +[1] Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt + +Example: + gptimer1: gptimer1@40010000 { + compatible = "st,stm32-gptimer"; + reg = <0x40010000 0x400>; + clocks = <&rcc 0 160>; + clock-names = "clk_int"; + + pwm1@0 { + compatible = "st,stm32-pwm"; + st,pwm-num-chan = <4>; + st,breakinput; + st,complementary; + }; + };
Define bindings for pwm-stm32 version 2: - use parameters instead of compatible of handle the hardware configuration Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> --- .../devicetree/bindings/pwm/pwm-stm32.txt | 37 ++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/pwm-stm32.txt