diff mbox

hiface: Fix sample rate changes

Message ID ee24b066-41d2-ad24-8598-f15a26a743a8@sonarnerd.net (mailing list archive)
State New, archived
Headers show

Commit Message

Jussi Laako Nov. 28, 2016, 9:27 a.m. UTC 
When attempting to change sample rate for the interface after first 
set-play cycle, the change is not reflected to the hardware, while from 
user space everything seems to go fine.

This patch fixes the issue and the driver now behaves the same way as 
for example the USB Audio Class driver.

Comments

Michael Nazzareno Trimarchi Nov. 28, 2016, 9:51 a.m. UTC | #1 
Hi

On Mon, Nov 28, 2016 at 10:27 AM, Jussi Laako <jussi@sonarnerd.net> wrote:
> When attempting to change sample rate for the interface after first set-play
> cycle, the change is not reflected to the hardware, while from user space
> everything seems to go fine.
>
> This patch fixes the issue and the driver now behaves the same way as for
> example the USB Audio Class driver.
>

Can you please sent it inline? Not having access at the hardware now
but Antonio should have it

Michael


>
diff mbox

Patch

From f4eec5602d86b5f938abed48a5725f59141d32cd Mon Sep 17 00:00:00 2001
From: Jussi Laako <jussi@sonarnerd.net>
Date: Mon, 28 Nov 2016 01:11:46 +0200
Subject: [PATCH] Fix M2Tech hiFace driver sampling rate change

Sampling rate changes after first set one are not reflected to the
hardware, while driver and ALSA think the rate has been changed.

Fix the problem by properly stopping the interface at the beginning of
prepare call, allowing new rate to be set to the hardware. This keeps
the hardware in sync with the driver.

Signed-off-by: Jussi Laako <jussi@sonarnerd.net>
---
 sound/usb/hiface/pcm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/usb/hiface/pcm.c b/sound/usb/hiface/pcm.c
index 2c44139..33db205 100644
--- a/sound/usb/hiface/pcm.c
+++ b/sound/usb/hiface/pcm.c
@@ -445,6 +445,8 @@  static int hiface_pcm_prepare(struct snd_pcm_substream *alsa_sub)
 
 	mutex_lock(&rt->stream_mutex);
 
+	hiface_pcm_stream_stop(rt);
+
 	sub->dma_off = 0;
 	sub->period_off = 0;
 
-- 
2.7.4