| Message ID | 1463090530-21864-1-git-send-email-dianders@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Olof, Arnd, On Thu, May 12, 2016 at 03:02:10PM -0700, Doug Anderson wrote: > We'd like to be able to use the cros-ec-keyboard.dtsi and > cros-ec-sbs.dtsi snippets for arm64 devices. Currently those files live > in the arm/boot/dts directory. > > Let's follow the convention set by commit 8ee57b8182c4 ("ARM64: dts: > vexpress: Use a symlink to vexpress-v2m-rs1.dtsi from arch=arm") and use > a symlink. Note that in this case we put the files in a new > "include/common" directory since these snippets may need to be > referenced by dts files in many different subdirectories. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > Note that, as of right now, there are no users of this. However, given > development happening it is almost 100% certain that users will arrive > soon. If we need to wait for the first user before landing this we can > leave this on the back burner. If it's OK to have no users (yet), let's > land. This may not fit your definition of "soon", but I'm looking to start using these files in arch/arm64/. I'll probably carry along this patch and resend when I'm ready, but it'd be just as well if you'd merge it now (or express a preference for a different directory structure). > arch/arm64/boot/dts/include/common/cros-ec-keyboard.dtsi | 1 + > arch/arm64/boot/dts/include/common/cros-ec-sbs.dtsi | 1 + > 2 files changed, 2 insertions(+) > create mode 120000 arch/arm64/boot/dts/include/common/cros-ec-keyboard.dtsi > create mode 120000 arch/arm64/boot/dts/include/common/cros-ec-sbs.dtsi > > \ No newline at end of file > > diff --git a/arch/arm64/boot/dts/include/common/cros-ec-keyboard.dtsi b/arch/arm64/boot/dts/include/common/cros-ec-keyboard.dtsi > new file mode 120000 > index 000000000000..1c1889f0a791 > --- /dev/null > +++ b/arch/arm64/boot/dts/include/common/cros-ec-keyboard.dtsi > @@ -0,0 +1 @@ > +../../../../../arm/boot/dts/cros-ec-keyboard.dtsi > \ No newline at end of file > diff --git a/arch/arm64/boot/dts/include/common/cros-ec-sbs.dtsi b/arch/arm64/boot/dts/include/common/cros-ec-sbs.dtsi > new file mode 120000 > index 000000000000..3d7ae9c88bcd > --- /dev/null > +++ b/arch/arm64/boot/dts/include/common/cros-ec-sbs.dtsi > @@ -0,0 +1 @@ > +../../../../../arm/boot/dts/cros-ec-sbs.dtsi FWIW: Reviewed-by: Brian Norris <briannorris@chromium.org>
Am Montag, 28. November 2016, 15:51:35 schrieb Brian Norris: > Hi Olof, Arnd, > > On Thu, May 12, 2016 at 03:02:10PM -0700, Doug Anderson wrote: > > We'd like to be able to use the cros-ec-keyboard.dtsi and > > cros-ec-sbs.dtsi snippets for arm64 devices. Currently those files live > > in the arm/boot/dts directory. > > > > Let's follow the convention set by commit 8ee57b8182c4 ("ARM64: dts: > > vexpress: Use a symlink to vexpress-v2m-rs1.dtsi from arch=arm") and use > > a symlink. Note that in this case we put the files in a new > > "include/common" directory since these snippets may need to be > > referenced by dts files in many different subdirectories. > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > Note that, as of right now, there are no users of this. However, given > > development happening it is almost 100% certain that users will arrive > > soon. If we need to wait for the first user before landing this we can > > leave this on the back burner. If it's OK to have no users (yet), let's > > land. > > This may not fit your definition of "soon", but I'm looking to start > using these files in arch/arm64/. I'll probably carry along this patch > and resend when I'm ready, but it'd be just as well if you'd merge it > now (or express a preference for a different directory structure). Till now I was expecting to just pick up this patch as well once the first (rk3399-)users arrived. But of course it could also be picked up separately. > > arch/arm64/boot/dts/include/common/cros-ec-keyboard.dtsi | 1 + > > arch/arm64/boot/dts/include/common/cros-ec-sbs.dtsi | 1 + > > 2 files changed, 2 insertions(+) > > create mode 120000 > > arch/arm64/boot/dts/include/common/cros-ec-keyboard.dtsi > > create mode 120000 arch/arm64/boot/dts/include/common/cros-ec-sbs.dtsi > > > > \ No newline at end of file > > > > diff --git a/arch/arm64/boot/dts/include/common/cros-ec-keyboard.dtsi > > b/arch/arm64/boot/dts/include/common/cros-ec-keyboard.dtsi new file mode > > 120000 > > index 000000000000..1c1889f0a791 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/include/common/cros-ec-keyboard.dtsi > > @@ -0,0 +1 @@ > > +../../../../../arm/boot/dts/cros-ec-keyboard.dtsi > > \ No newline at end of file > > diff --git a/arch/arm64/boot/dts/include/common/cros-ec-sbs.dtsi > > b/arch/arm64/boot/dts/include/common/cros-ec-sbs.dtsi new file mode > > 120000 > > index 000000000000..3d7ae9c88bcd > > --- /dev/null > > +++ b/arch/arm64/boot/dts/include/common/cros-ec-sbs.dtsi > > @@ -0,0 +1 @@ > > +../../../../../arm/boot/dts/cros-ec-sbs.dtsi > > FWIW: > > Reviewed-by: Brian Norris <briannorris@chromium.org> I'm also running with this on my rk3399-gru and it sucessfully enables the cros-ec keyboard :-) ,so if anyone picks it up before me they can add Reviewed-by: Heiko Stueber <heiko@sntech.de> Tested-by: Heiko Stuebner <heiko@sntech.de>
diff --git a/arch/arm64/boot/dts/include/common/cros-ec-keyboard.dtsi b/arch/arm64/boot/dts/include/common/cros-ec-keyboard.dtsi new file mode 120000 index 000000000000..1c1889f0a791 --- /dev/null +++ b/arch/arm64/boot/dts/include/common/cros-ec-keyboard.dtsi @@ -0,0 +1 @@ +../../../../../arm/boot/dts/cros-ec-keyboard.dtsi \ No newline at end of file diff --git a/arch/arm64/boot/dts/include/common/cros-ec-sbs.dtsi b/arch/arm64/boot/dts/include/common/cros-ec-sbs.dtsi new file mode 120000 index 000000000000..3d7ae9c88bcd --- /dev/null +++ b/arch/arm64/boot/dts/include/common/cros-ec-sbs.dtsi @@ -0,0 +1 @@ +../../../../../arm/boot/dts/cros-ec-sbs.dtsi
We'd like to be able to use the cros-ec-keyboard.dtsi and cros-ec-sbs.dtsi snippets for arm64 devices. Currently those files live in the arm/boot/dts directory. Let's follow the convention set by commit 8ee57b8182c4 ("ARM64: dts: vexpress: Use a symlink to vexpress-v2m-rs1.dtsi from arch=arm") and use a symlink. Note that in this case we put the files in a new "include/common" directory since these snippets may need to be referenced by dts files in many different subdirectories. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- Note that, as of right now, there are no users of this. However, given development happening it is almost 100% certain that users will arrive soon. If we need to wait for the first user before landing this we can leave this on the back burner. If it's OK to have no users (yet), let's land. arch/arm64/boot/dts/include/common/cros-ec-keyboard.dtsi | 1 + arch/arm64/boot/dts/include/common/cros-ec-sbs.dtsi | 1 + 2 files changed, 2 insertions(+) create mode 120000 arch/arm64/boot/dts/include/common/cros-ec-keyboard.dtsi create mode 120000 arch/arm64/boot/dts/include/common/cros-ec-sbs.dtsi \ No newline at end of file