| Message ID | 20161116122113.4317-1-marex@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 11/16/2016 01:21 PM, Marek Vasut wrote: > Add new DT bindings for new MXSFB driver that is using the > OF graph to parse the video output structure instead of > hard-coding the display properties into the MXSFB node. > The old MXSFB fbdev driver bindings are preserved in the > same file in the "Old bindings" section. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Rob Herring <robh@kernel.org> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Shawn Guo <shawnguo@kernel.org> > -- > V2: - Merge the new bindings into mxsfb.txt file instead of keeping > them in separate mxsfb-drm.txt file. > - Add dedicated compatible for i.MX6SX > - Drop all references to DRM/KMS > - Repair the required bits in clock node > V3: - Replace lcdif with LCDIF, lcdif@0 with display-controller@, > Old with Deprecated to address V2 feedback Bump ? > --- > .../devicetree/bindings/display/mxsfb.txt | 41 ++++++++++++++++++++-- > 1 file changed, 39 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/mxsfb.txt b/Documentation/devicetree/bindings/display/mxsfb.txt > index a4431f2..472e1ea 100644 > --- a/Documentation/devicetree/bindings/display/mxsfb.txt > +++ b/Documentation/devicetree/bindings/display/mxsfb.txt > @@ -1,10 +1,47 @@ > * Freescale MXS LCD Interface (LCDIF) > > +New bindings: > +============= > Required properties: > - compatible: Should be "fsl,imx23-lcdif" for i.MX23. > Should be "fsl,imx28-lcdif" for i.MX28. > -- reg: Address and length of the register set for lcdif > -- interrupts: Should contain lcdif interrupts > + Should be "fsl,imx6sx-lcdif" for i.MX6SX. > +- reg: Address and length of the register set for LCDIF > +- interrupts: Should contain LCDIF interrupt > +- clocks: A list of phandle + clock-specifier pairs, one for each > + entry in 'clock-names'. > +- clock-names: A list of clock names. For MXSFB it should contain: > + - "pix" for the LCDIF block clock > + - (MX6SX-only) "axi", "disp_axi" for the bus interface clock > + > +Required sub-nodes: > + - port: The connection to an encoder chip. > + > +Example: > + > + lcdif1: display-controller@2220000 { > + compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; > + reg = <0x02220000 0x4000>; > + interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>, > + <&clks IMX6SX_CLK_LCDIF_APB>, > + <&clks IMX6SX_CLK_DISPLAY_AXI>; > + clock-names = "pix", "axi", "disp_axi"; > + > + port { > + parallel_out: endpoint { > + remote-endpoint = <&panel_in_parallel>; > + }; > + }; > + }; > + > +Deprecated bindings: > +==================== > +Required properties: > +- compatible: Should be "fsl,imx23-lcdif" for i.MX23. > + Should be "fsl,imx28-lcdif" for i.MX28. > +- reg: Address and length of the register set for LCDIF > +- interrupts: Should contain LCDIF interrupts > - display: phandle to display node (see below for details) > > * display node >
On Fri, Nov 25, 2016 at 12:26 PM, Marek Vasut <marex@denx.de> wrote: > On 11/16/2016 01:21 PM, Marek Vasut wrote: >> Add new DT bindings for new MXSFB driver that is using the >> OF graph to parse the video output structure instead of >> hard-coding the display properties into the MXSFB node. >> The old MXSFB fbdev driver bindings are preserved in the >> same file in the "Old bindings" section. >> >> Signed-off-by: Marek Vasut <marex@denx.de> >> Cc: Rob Herring <robh@kernel.org> >> Cc: Lucas Stach <l.stach@pengutronix.de> >> Cc: Fabio Estevam <fabio.estevam@nxp.com> >> Cc: Shawn Guo <shawnguo@kernel.org> >> -- >> V2: - Merge the new bindings into mxsfb.txt file instead of keeping >> them in separate mxsfb-drm.txt file. >> - Add dedicated compatible for i.MX6SX >> - Drop all references to DRM/KMS >> - Repair the required bits in clock node >> V3: - Replace lcdif with LCDIF, lcdif@0 with display-controller@, >> Old with Deprecated to address V2 feedback > > Bump ? If you don't send to DT list, it won't be in my queue. Acked-by: Rob Herring <robh@kernel.org>
On 11/29/2016 04:29 PM, Rob Herring wrote: > On Fri, Nov 25, 2016 at 12:26 PM, Marek Vasut <marex@denx.de> wrote: >> On 11/16/2016 01:21 PM, Marek Vasut wrote: >>> Add new DT bindings for new MXSFB driver that is using the >>> OF graph to parse the video output structure instead of >>> hard-coding the display properties into the MXSFB node. >>> The old MXSFB fbdev driver bindings are preserved in the >>> same file in the "Old bindings" section. >>> >>> Signed-off-by: Marek Vasut <marex@denx.de> >>> Cc: Rob Herring <robh@kernel.org> >>> Cc: Lucas Stach <l.stach@pengutronix.de> >>> Cc: Fabio Estevam <fabio.estevam@nxp.com> >>> Cc: Shawn Guo <shawnguo@kernel.org> >>> -- >>> V2: - Merge the new bindings into mxsfb.txt file instead of keeping >>> them in separate mxsfb-drm.txt file. >>> - Add dedicated compatible for i.MX6SX >>> - Drop all references to DRM/KMS >>> - Repair the required bits in clock node >>> V3: - Replace lcdif with LCDIF, lcdif@0 with display-controller@, >>> Old with Deprecated to address V2 feedback >> >> Bump ? > > If you don't send to DT list, it won't be in my queue. > > Acked-by: Rob Herring <robh@kernel.org> > Did I miss the list _again_ ? Ughhhh, apologies, I'll apply brown paper bag now.
diff --git a/Documentation/devicetree/bindings/display/mxsfb.txt b/Documentation/devicetree/bindings/display/mxsfb.txt index a4431f2..472e1ea 100644 --- a/Documentation/devicetree/bindings/display/mxsfb.txt +++ b/Documentation/devicetree/bindings/display/mxsfb.txt @@ -1,10 +1,47 @@ * Freescale MXS LCD Interface (LCDIF) +New bindings: +============= Required properties: - compatible: Should be "fsl,imx23-lcdif" for i.MX23. Should be "fsl,imx28-lcdif" for i.MX28. -- reg: Address and length of the register set for lcdif -- interrupts: Should contain lcdif interrupts + Should be "fsl,imx6sx-lcdif" for i.MX6SX. +- reg: Address and length of the register set for LCDIF +- interrupts: Should contain LCDIF interrupt +- clocks: A list of phandle + clock-specifier pairs, one for each + entry in 'clock-names'. +- clock-names: A list of clock names. For MXSFB it should contain: + - "pix" for the LCDIF block clock + - (MX6SX-only) "axi", "disp_axi" for the bus interface clock + +Required sub-nodes: + - port: The connection to an encoder chip. + +Example: + + lcdif1: display-controller@2220000 { + compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; + reg = <0x02220000 0x4000>; + interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>, + <&clks IMX6SX_CLK_LCDIF_APB>, + <&clks IMX6SX_CLK_DISPLAY_AXI>; + clock-names = "pix", "axi", "disp_axi"; + + port { + parallel_out: endpoint { + remote-endpoint = <&panel_in_parallel>; + }; + }; + }; + +Deprecated bindings: +==================== +Required properties: +- compatible: Should be "fsl,imx23-lcdif" for i.MX23. + Should be "fsl,imx28-lcdif" for i.MX28. +- reg: Address and length of the register set for LCDIF +- interrupts: Should contain LCDIF interrupts - display: phandle to display node (see below for details) * display node
Add new DT bindings for new MXSFB driver that is using the OF graph to parse the video output structure instead of hard-coding the display properties into the MXSFB node. The old MXSFB fbdev driver bindings are preserved in the same file in the "Old bindings" section. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Rob Herring <robh@kernel.org> Cc: Lucas Stach <l.stach@pengutronix.de> Cc: Fabio Estevam <fabio.estevam@nxp.com> Cc: Shawn Guo <shawnguo@kernel.org> -- V2: - Merge the new bindings into mxsfb.txt file instead of keeping them in separate mxsfb-drm.txt file. - Add dedicated compatible for i.MX6SX - Drop all references to DRM/KMS - Repair the required bits in clock node V3: - Replace lcdif with LCDIF, lcdif@0 with display-controller@, Old with Deprecated to address V2 feedback --- .../devicetree/bindings/display/mxsfb.txt | 41 ++++++++++++++++++++-- 1 file changed, 39 insertions(+), 2 deletions(-)