diff mbox

audio: ac97: add exit function

Message ID 583d59a6.dcc6370a.3a361.b5d4@mx.google.com (mailing list archive)
State New, archived
Headers show

Commit Message

Li Qiang Nov. 29, 2016, 10:33 a.m. UTC 
From: Li Qiang <liqiang6-s@360.cn>

Currently the ac97 device emulation doesn't have a exit function,
hot unplug this device will leak some leak. Add a exit function to
avoid this.

Signed-off-by: Li Qiang <liqiang6-s@360.cn>
---
 hw/audio/ac97.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

J. Neuschäfer Nov. 30, 2016, 12:47 a.m. UTC | #1 
On Tue, Nov 29, 2016 at 02:33:41AM -0800, Li Qiang wrote:
> From: Li Qiang <liqiang6-s@360.cn>
> 
> Currently the ac97 device emulation doesn't have a exit function,
> hot unplug this device will leak some leak. Add a exit function to

s/some leak/some memory/ ?

> avoid this.
> 
> Signed-off-by: Li Qiang <liqiang6-s@360.cn>
> ---
>  hw/audio/ac97.c | 8 ++++++++
>  1 file changed, 8 insertions(+)

Regards,
Jonathan Neuschäfer
Li Qiang Nov. 30, 2016, 1:39 a.m. UTC | #2 
2016-11-30 8:47 GMT+08:00 Jonathan Neuschäfer <j.neuschaefer@gmx.net>:

> On Tue, Nov 29, 2016 at 02:33:41AM -0800, Li Qiang wrote:
> > From: Li Qiang <liqiang6-s@360.cn>
> >
> > Currently the ac97 device emulation doesn't have a exit function,
> > hot unplug this device will leak some leak. Add a exit function to
>
> s/some leak/some memory/ ?
>
>
True. Sorry for the mistake.

Li Qiang
Li Qiang Dec. 13, 2016, 8:54 a.m. UTC | #3 
Ping!

2016-11-29 18:33 GMT+08:00 Li Qiang <liq3ea@gmail.com>:

> From: Li Qiang <liqiang6-s@360.cn>
>
> Currently the ac97 device emulation doesn't have a exit function,
> hot unplug this device will leak some leak. Add a exit function to
> avoid this.
>
> Signed-off-by: Li Qiang <liqiang6-s@360.cn>
> ---
>  hw/audio/ac97.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/hw/audio/ac97.c b/hw/audio/ac97.c
> index cbd959e..2faed35 100644
> --- a/hw/audio/ac97.c
> +++ b/hw/audio/ac97.c
> @@ -1387,6 +1387,13 @@ static void ac97_realize(PCIDevice *dev, Error
> **errp)
>      ac97_on_reset (&s->dev.qdev);
>  }
>
> +static void ac97_exit(PCIDevice *dev)
> +{
> +    AC97LinkState *s = DO_UPCAST(AC97LinkState, dev, dev);
> +
> +    AUD_remove_card(&s->card);
> +}
> +
>  static int ac97_init (PCIBus *bus)
>  {
>      pci_create_simple (bus, -1, "AC97");
> @@ -1404,6 +1411,7 @@ static void ac97_class_init (ObjectClass *klass,
> void *data)
>      PCIDeviceClass *k = PCI_DEVICE_CLASS (klass);
>
>      k->realize = ac97_realize;
> +    k->exit = ac97_exit;
>      k->vendor_id = PCI_VENDOR_ID_INTEL;
>      k->device_id = PCI_DEVICE_ID_INTEL_82801AA_5;
>      k->revision = 0x01;
> --
> 1.8.3.1
>
>
diff mbox

Patch

diff --git a/hw/audio/ac97.c b/hw/audio/ac97.c
index cbd959e..2faed35 100644
--- a/hw/audio/ac97.c
+++ b/hw/audio/ac97.c
@@ -1387,6 +1387,13 @@  static void ac97_realize(PCIDevice *dev, Error **errp)
     ac97_on_reset (&s->dev.qdev);
 }
 
+static void ac97_exit(PCIDevice *dev)
+{
+    AC97LinkState *s = DO_UPCAST(AC97LinkState, dev, dev);
+
+    AUD_remove_card(&s->card);
+}
+
 static int ac97_init (PCIBus *bus)
 {
     pci_create_simple (bus, -1, "AC97");
@@ -1404,6 +1411,7 @@  static void ac97_class_init (ObjectClass *klass, void *data)
     PCIDeviceClass *k = PCI_DEVICE_CLASS (klass);
 
     k->realize = ac97_realize;
+    k->exit = ac97_exit;
     k->vendor_id = PCI_VENDOR_ID_INTEL;
     k->device_id = PCI_DEVICE_ID_INTEL_82801AA_5;
     k->revision = 0x01;