| Message ID | 1480420127-11382-1-git-send-email-ander.conselvan.de.oliveira@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Ander, [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on v4.9-rc7 next-20161129] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ander-Conselvan-de-Oliveira/drm-i915-Fix-intel_psr_init-kerneldoc/20161130-081024 base: git://anongit.freedesktop.org/drm-intel for-linux-next reproduce: make htmldocs All warnings (new ones prefixed by >>): make[3]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule. include/linux/init.h:1: warning: no structured comments found include/linux/workqueue.h:392: warning: No description found for parameter '...' include/linux/workqueue.h:392: warning: Excess function parameter 'args' description in 'alloc_workqueue' include/linux/workqueue.h:413: warning: No description found for parameter '...' include/linux/workqueue.h:413: warning: Excess function parameter 'args' description in 'alloc_ordered_workqueue' include/linux/kthread.h:26: warning: No description found for parameter '...' kernel/sys.c:1: warning: no structured comments found drivers/dma-buf/seqno-fence.c:1: warning: no structured comments found include/sound/core.h:324: warning: No description found for parameter '...' include/sound/core.h:335: warning: No description found for parameter '...' include/sound/core.h:388: warning: No description found for parameter '...' include/drm/drm_drv.h:295: warning: Incorrect use of kernel-doc format: * Hook for allocating the GEM object struct, for use by core include/drm/drm_drv.h:407: warning: No description found for parameter 'load' include/drm/drm_drv.h:407: warning: No description found for parameter 'firstopen' include/drm/drm_drv.h:407: warning: No description found for parameter 'open' include/drm/drm_drv.h:407: warning: No description found for parameter 'preclose' include/drm/drm_drv.h:407: warning: No description found for parameter 'postclose' include/drm/drm_drv.h:407: warning: No description found for parameter 'lastclose' include/drm/drm_drv.h:407: warning: No description found for parameter 'unload' include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_ioctl' include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_quiescent' include/drm/drm_drv.h:407: warning: No description found for parameter 'context_dtor' include/drm/drm_drv.h:407: warning: No description found for parameter 'set_busid' include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_handler' include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_preinstall' include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_postinstall' include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_uninstall' include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_init' include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_cleanup' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_open_object' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_close_object' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_create_object' include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_handle_to_fd' include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_fd_to_handle' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_export' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_pin' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_unpin' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_res_obj' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_get_sg_table' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import_sg_table' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vmap' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vunmap' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_mmap' include/drm/drm_drv.h:407: warning: No description found for parameter 'vgaarb_irq' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_vm_ops' include/drm/drm_drv.h:407: warning: No description found for parameter 'major' include/drm/drm_drv.h:407: warning: No description found for parameter 'minor' include/drm/drm_drv.h:407: warning: No description found for parameter 'patchlevel' include/drm/drm_drv.h:407: warning: No description found for parameter 'name' include/drm/drm_drv.h:407: warning: No description found for parameter 'desc' include/drm/drm_drv.h:407: warning: No description found for parameter 'date' include/drm/drm_drv.h:407: warning: No description found for parameter 'driver_features' include/drm/drm_drv.h:407: warning: No description found for parameter 'dev_priv_size' include/drm/drm_drv.h:407: warning: No description found for parameter 'ioctls' include/drm/drm_drv.h:407: warning: No description found for parameter 'num_ioctls' include/drm/drm_drv.h:407: warning: No description found for parameter 'fops' include/drm/drm_drv.h:407: warning: No description found for parameter 'legacy_dev_list' >> drivers/gpu/drm/i915/intel_psr.c:822: warning: No description found for parameter 'dev' >> drivers/gpu/drm/i915/intel_psr.c:822: warning: Excess function parameter 'dev_priv' description in 'intel_psr_init' drivers/gpu/drm/i915/intel_psr.c:823: warning: No description found for parameter 'dev' drivers/gpu/drm/i915/intel_psr.c:823: warning: Excess function parameter 'dev_priv' description in 'intel_psr_init' include/media/media-entity.h:1054: warning: No description found for parameter '...' include/net/mac80211.h:3207: ERROR: Unexpected indentation. include/net/mac80211.h:3210: WARNING: Block quote ends without a blank line; unexpected unindent. include/net/mac80211.h:3212: ERROR: Unexpected indentation. include/net/mac80211.h:3213: WARNING: Block quote ends without a blank line; unexpected unindent. include/net/mac80211.h:1772: ERROR: Unexpected indentation. include/net/mac80211.h:1776: WARNING: Block quote ends without a blank line; unexpected unindent. kernel/sched/fair.c:7259: WARNING: Inline emphasis start-string without end-string. kernel/time/timer.c:1240: ERROR: Unexpected indentation. kernel/time/timer.c:1242: ERROR: Unexpected indentation. kernel/time/timer.c:1243: WARNING: Block quote ends without a blank line; unexpected unindent. include/linux/wait.h:121: WARNING: Block quote ends without a blank line; unexpected unindent. include/linux/wait.h:124: ERROR: Unexpected indentation. include/linux/wait.h:126: WARNING: Block quote ends without a blank line; unexpected unindent. kernel/time/hrtimer.c:1021: WARNING: Block quote ends without a blank line; unexpected unindent. kernel/signal.c:317: WARNING: Inline literal start-string without end-string. drivers/base/firmware_class.c:1348: WARNING: Bullet list ends without a blank line; unexpected unindent. drivers/message/fusion/mptbase.c:5054: WARNING: Definition list ends without a blank line; unexpected unindent. drivers/tty/serial/serial_core.c:1893: WARNING: Definition list ends without a blank line; unexpected unindent. include/linux/spi/spi.h:369: ERROR: Unexpected indentation. WARNING: dvipng command 'dvipng' cannot be run (needed for math display), check the imgmath_dvipng setting vim +/dev +822 drivers/gpu/drm/i915/intel_psr.c 995d3047 Rodrigo Vivi 2014-11-19 806 0bc12bcb Rodrigo Vivi 2014-11-14 807 if (!dev_priv->psr.active && !dev_priv->psr.busy_frontbuffer_bits) d0ac896a Rodrigo Vivi 2015-11-11 808 if (!work_busy(&dev_priv->psr.work.work)) 0bc12bcb Rodrigo Vivi 2014-11-14 809 schedule_delayed_work(&dev_priv->psr.work, 20bb97fe Rodrigo Vivi 2015-11-11 810 msecs_to_jiffies(100)); 0bc12bcb Rodrigo Vivi 2014-11-14 811 mutex_unlock(&dev_priv->psr.lock); 0bc12bcb Rodrigo Vivi 2014-11-14 812 } 0bc12bcb Rodrigo Vivi 2014-11-14 813 b2b89f55 Rodrigo Vivi 2014-11-14 814 /** b2b89f55 Rodrigo Vivi 2014-11-14 815 * intel_psr_init - Init basic PSR work and mutex. acd19c01 Ander Conselvan de Oliveira 2016-11-29 816 * @dev_priv: i915 device private b2b89f55 Rodrigo Vivi 2014-11-14 817 * b2b89f55 Rodrigo Vivi 2014-11-14 818 * This function is called only once at driver load to initialize basic b2b89f55 Rodrigo Vivi 2014-11-14 819 * PSR stuff. b2b89f55 Rodrigo Vivi 2014-11-14 820 */ 0bc12bcb Rodrigo Vivi 2014-11-14 821 void intel_psr_init(struct drm_device *dev) 0bc12bcb Rodrigo Vivi 2014-11-14 @822 { fac5e23e Chris Wilson 2016-07-04 823 struct drm_i915_private *dev_priv = to_i915(dev); 0bc12bcb Rodrigo Vivi 2014-11-14 824 443a389f Ville Syrjälä 2015-11-11 825 dev_priv->psr_mmio_base = IS_HASWELL(dev_priv) ? 443a389f Ville Syrjälä 2015-11-11 826 HSW_EDP_PSR_BASE : BDW_EDP_PSR_BASE; 443a389f Ville Syrjälä 2015-11-11 827 d94d6e87 Rodrigo Vivi 2016-02-12 828 /* Per platform default */ d94d6e87 Rodrigo Vivi 2016-02-12 829 if (i915.enable_psr == -1) { 8652744b Tvrtko Ursulin 2016-10-13 830 if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv)) :::::: The code at line 822 was first introduced by commit :::::: 0bc12bcb1b9686d7011f16410ba17ed0740167c3 drm/i915: Introduce intel_psr.c :::::: TO: Rodrigo Vivi <rodrigo.vivi@intel.com> :::::: CC: Daniel Vetter <daniel.vetter@ffwll.ch> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
On Wed, 2016-11-30 at 09:29 +0800, kbuild test robot wrote: > Hi Ander, > > [auto build test WARNING on drm-intel/for-linux-next] > [also build test WARNING on v4.9-rc7 next-20161129] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Ander-Conselvan-de-Oliveira/drm-i915-Fix-intel_psr_init-kerneldoc/20161130-081024 > base: git://anongit.freedesktop.org/drm-intel for-linux-next > reproduce: make htmldocs > > All warnings (new ones prefixed by >>): > > make[3]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule. > include/linux/init.h:1: warning: no structured comments found > include/linux/workqueue.h:392: warning: No description found for parameter '...' > include/linux/workqueue.h:392: warning: Excess function parameter 'args' description in 'alloc_workqueue' > include/linux/workqueue.h:413: warning: No description found for parameter '...' > include/linux/workqueue.h:413: warning: Excess function parameter 'args' description in 'alloc_ordered_workqueue' > include/linux/kthread.h:26: warning: No description found for parameter '...' > kernel/sys.c:1: warning: no structured comments found > drivers/dma-buf/seqno-fence.c:1: warning: no structured comments found > include/sound/core.h:324: warning: No description found for parameter '...' > include/sound/core.h:335: warning: No description found for parameter '...' > include/sound/core.h:388: warning: No description found for parameter '...' > include/drm/drm_drv.h:295: warning: Incorrect use of kernel-doc format: * Hook for allocating the GEM object struct, for use by core > include/drm/drm_drv.h:407: warning: No description found for parameter 'load' > include/drm/drm_drv.h:407: warning: No description found for parameter 'firstopen' > include/drm/drm_drv.h:407: warning: No description found for parameter 'open' > include/drm/drm_drv.h:407: warning: No description found for parameter 'preclose' > include/drm/drm_drv.h:407: warning: No description found for parameter 'postclose' > include/drm/drm_drv.h:407: warning: No description found for parameter 'lastclose' > include/drm/drm_drv.h:407: warning: No description found for parameter 'unload' > include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_ioctl' > include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_quiescent' > include/drm/drm_drv.h:407: warning: No description found for parameter 'context_dtor' > include/drm/drm_drv.h:407: warning: No description found for parameter 'set_busid' > include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_handler' > include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_preinstall' > include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_postinstall' > include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_uninstall' > include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_init' > include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_cleanup' > include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_open_object' > include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_close_object' > include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_create_object' > include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_handle_to_fd' > include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_fd_to_handle' > include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_export' > include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import' > include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_pin' > include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_unpin' > include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_res_obj' > include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_get_sg_table' > include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import_sg_table' > include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vmap' > include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vunmap' > include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_mmap' > include/drm/drm_drv.h:407: warning: No description found for parameter 'vgaarb_irq' > include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_vm_ops' > include/drm/drm_drv.h:407: warning: No description found for parameter 'major' > include/drm/drm_drv.h:407: warning: No description found for parameter 'minor' > include/drm/drm_drv.h:407: warning: No description found for parameter 'patchlevel' > include/drm/drm_drv.h:407: warning: No description found for parameter 'name' > include/drm/drm_drv.h:407: warning: No description found for parameter 'desc' > include/drm/drm_drv.h:407: warning: No description found for parameter 'date' > include/drm/drm_drv.h:407: warning: No description found for parameter 'driver_features' > include/drm/drm_drv.h:407: warning: No description found for parameter 'dev_priv_size' > include/drm/drm_drv.h:407: warning: No description found for parameter 'ioctls' > include/drm/drm_drv.h:407: warning: No description found for parameter 'num_ioctls' > include/drm/drm_drv.h:407: warning: No description found for parameter 'fops' > include/drm/drm_drv.h:407: warning: No description found for parameter 'legacy_dev_list' > >> drivers/gpu/drm/i915/intel_psr.c:822: warning: No description found for parameter 'dev' > >> drivers/gpu/drm/i915/intel_psr.c:822: warning: Excess function parameter 'dev_priv' description in 'intel_psr_init' > drivers/gpu/drm/i915/intel_psr.c:823: warning: No description found for parameter 'dev' > drivers/gpu/drm/i915/intel_psr.c:823: warning: Excess function parameter 'dev_priv' description in 'intel_psr_init' These warnings are for some wrong tree, which doesn't have the patch that converts from dev to dev_priv in intel_psr_init()'s signature. Ander
On Tue, 2016-11-29 at 13:48 +0200, Ander Conselvan de Oliveira wrote: > In commit c39055b072f8 ("drm/i915: Pass dev_priv to > intel_setup_outputs()"), I forgot to update the kerneldoc for > intel_psr_init() init, leading to warnings when building the > documentation: > > drivers/gpu/drm/i915/intel_psr.c:822: warning: No description found for parameter 'dev_priv' > drivers/gpu/drm/i915/intel_psr.c:822: warning: Excess function parameter 'dev' description in 'intel_psr_init' > > Fixes: c39055b072f8 ("drm/i915: Pass dev_priv to intel_setup_outputs()") > Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Daniel Vetter <daniel.vetter@intel.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: intel-gfx@lists.freedesktop.org > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> Pushed with Daniel's irc r-b. Ander > --- > drivers/gpu/drm/i915/intel_psr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_psr.c > b/drivers/gpu/drm/i915/intel_psr.c > index 5c3616e..d5f8d03 100644 > --- a/drivers/gpu/drm/i915/intel_psr.c > +++ b/drivers/gpu/drm/i915/intel_psr.c > @@ -813,7 +813,7 @@ void intel_psr_flush(struct drm_i915_private *dev_priv, > > /** > * intel_psr_init - Init basic PSR work and mutex. > - * @dev: DRM device > + * @dev_priv: i915 device private > * > * This function is called only once at driver load to initialize basic > * PSR stuff. --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
On 11/30, Ander Conselvan De Oliveira wrote: >On Wed, 2016-11-30 at 09:29 +0800, kbuild test robot wrote: >> Hi Ander, >> >> [auto build test WARNING on drm-intel/for-linux-next] >> [also build test WARNING on v4.9-rc7 next-20161129] >> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] >> >> url: https://github.com/0day-ci/linux/commits/Ander-Conselvan-de-Oliveira/drm-i915-Fix-intel_psr_init-kerneldoc/20161130-081024 >> base: git://anongit.freedesktop.org/drm-intel for-linux-next >> reproduce: make htmldocs >> >> All warnings (new ones prefixed by >>): >> >> make[3]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule. >> include/linux/init.h:1: warning: no structured comments found >> include/linux/workqueue.h:392: warning: No description found for parameter '...' >> include/linux/workqueue.h:392: warning: Excess function parameter 'args' description in 'alloc_workqueue' >> include/linux/workqueue.h:413: warning: No description found for parameter '...' >> include/linux/workqueue.h:413: warning: Excess function parameter 'args' description in 'alloc_ordered_workqueue' >> include/linux/kthread.h:26: warning: No description found for parameter '...' >> kernel/sys.c:1: warning: no structured comments found >> drivers/dma-buf/seqno-fence.c:1: warning: no structured comments found >> include/sound/core.h:324: warning: No description found for parameter '...' >> include/sound/core.h:335: warning: No description found for parameter '...' >> include/sound/core.h:388: warning: No description found for parameter '...' >> include/drm/drm_drv.h:295: warning: Incorrect use of kernel-doc format: * Hook for allocating the GEM object struct, for use by core >> include/drm/drm_drv.h:407: warning: No description found for parameter 'load' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'firstopen' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'open' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'preclose' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'postclose' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'lastclose' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'unload' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_ioctl' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_quiescent' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'context_dtor' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'set_busid' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_handler' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_preinstall' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_postinstall' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_uninstall' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_init' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_cleanup' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_open_object' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_close_object' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_create_object' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_handle_to_fd' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_fd_to_handle' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_export' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_pin' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_unpin' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_res_obj' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_get_sg_table' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import_sg_table' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vmap' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vunmap' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_mmap' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'vgaarb_irq' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_vm_ops' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'major' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'minor' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'patchlevel' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'name' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'desc' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'date' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'driver_features' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'dev_priv_size' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'ioctls' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'num_ioctls' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'fops' >> include/drm/drm_drv.h:407: warning: No description found for parameter 'legacy_dev_list' >> >> drivers/gpu/drm/i915/intel_psr.c:822: warning: No description found for parameter 'dev' >> >> drivers/gpu/drm/i915/intel_psr.c:822: warning: Excess function parameter 'dev_priv' description in 'intel_psr_init' >> drivers/gpu/drm/i915/intel_psr.c:823: warning: No description found for parameter 'dev' >> drivers/gpu/drm/i915/intel_psr.c:823: warning: Excess function parameter 'dev_priv' description in 'intel_psr_init' > >These warnings are for some wrong tree, which doesn't have the patch that >converts from dev to dev_priv in intel_psr_init()'s signature. Thanks for the note, could you tell us the correct tree to which this patch should be applied? Thanks, Xiaolong > >Ander > >
On Tue, 2016-12-06 at 02:01 +0800, Ye Xiaolong wrote: > On 11/30, Ander Conselvan De Oliveira wrote: > > > > On Wed, 2016-11-30 at 09:29 +0800, kbuild test robot wrote: > > > > > > Hi Ander, > > > > > > [auto build test WARNING on drm-intel/for-linux-next] > > > [also build test WARNING on v4.9-rc7 next-20161129] > > > [if your patch is applied to the wrong git tree, please drop us a note to > > > help improve the system] > > > > > > url: https://github.com/0day-ci/linux/commits/Ander-Conselvan-de-Olivei > > > ra/drm-i915-Fix-intel_psr_init-kerneldoc/20161130-081024 > > > base: git://anongit.freedesktop.org/drm-intel for-linux-next > > > reproduce: make htmldocs > > > > > > All warnings (new ones prefixed by >>): > > > > > > make[3]: warning: jobserver unavailable: using -j1. Add '+' to parent > > > make rule. > > > include/linux/init.h:1: warning: no structured comments found > > > include/linux/workqueue.h:392: warning: No description found for > > > parameter '...' > > > include/linux/workqueue.h:392: warning: Excess function parameter > > > 'args' description in 'alloc_workqueue' > > > include/linux/workqueue.h:413: warning: No description found for > > > parameter '...' > > > include/linux/workqueue.h:413: warning: Excess function parameter > > > 'args' description in 'alloc_ordered_workqueue' > > > include/linux/kthread.h:26: warning: No description found for parameter > > > '...' > > > kernel/sys.c:1: warning: no structured comments found > > > drivers/dma-buf/seqno-fence.c:1: warning: no structured comments found > > > include/sound/core.h:324: warning: No description found for parameter > > > '...' > > > include/sound/core.h:335: warning: No description found for parameter > > > '...' > > > include/sound/core.h:388: warning: No description found for parameter > > > '...' > > > include/drm/drm_drv.h:295: warning: Incorrect use of kernel-doc > > > format: * Hook for allocating the GEM object struct, for use by core > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'load' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'firstopen' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'open' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'preclose' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'postclose' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'lastclose' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'unload' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'dma_ioctl' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'dma_quiescent' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'context_dtor' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'set_busid' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'irq_handler' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'irq_preinstall' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'irq_postinstall' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'irq_uninstall' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'debugfs_init' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'debugfs_cleanup' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'gem_open_object' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'gem_close_object' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'gem_create_object' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'prime_handle_to_fd' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'prime_fd_to_handle' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'gem_prime_export' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'gem_prime_import' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'gem_prime_pin' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'gem_prime_unpin' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'gem_prime_res_obj' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'gem_prime_get_sg_table' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'gem_prime_import_sg_table' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'gem_prime_vmap' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'gem_prime_vunmap' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'gem_prime_mmap' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'vgaarb_irq' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'gem_vm_ops' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'major' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'minor' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'patchlevel' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'name' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'desc' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'date' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'driver_features' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'dev_priv_size' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'ioctls' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'num_ioctls' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'fops' > > > include/drm/drm_drv.h:407: warning: No description found for parameter > > > 'legacy_dev_list' > > > > > > > > > > > > > > drivers/gpu/drm/i915/intel_psr.c:822: warning: No description found > > > > > for parameter 'dev' > > > > > drivers/gpu/drm/i915/intel_psr.c:822: warning: Excess function > > > > > parameter 'dev_priv' description in 'intel_psr_init' > > > drivers/gpu/drm/i915/intel_psr.c:823: warning: No description found for > > > parameter 'dev' > > > drivers/gpu/drm/i915/intel_psr.c:823: warning: Excess function > > > parameter 'dev_priv' description in 'intel_psr_init' > > These warnings are for some wrong tree, which doesn't have the patch that > > converts from dev to dev_priv in intel_psr_init()'s signature. > Thanks for the note, could you tell us the correct tree to which this patch > should be applied? That would be drm-intel/drm-intel-next-queued. Ander
diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c index 5c3616e..d5f8d03 100644 --- a/drivers/gpu/drm/i915/intel_psr.c +++ b/drivers/gpu/drm/i915/intel_psr.c @@ -813,7 +813,7 @@ void intel_psr_flush(struct drm_i915_private *dev_priv, /** * intel_psr_init - Init basic PSR work and mutex. - * @dev: DRM device + * @dev_priv: i915 device private * * This function is called only once at driver load to initialize basic * PSR stuff.
In commit c39055b072f8 ("drm/i915: Pass dev_priv to intel_setup_outputs()"), I forgot to update the kerneldoc for intel_psr_init() init, leading to warnings when building the documentation: drivers/gpu/drm/i915/intel_psr.c:822: warning: No description found for parameter 'dev_priv' drivers/gpu/drm/i915/intel_psr.c:822: warning: Excess function parameter 'dev' description in 'intel_psr_init' Fixes: c39055b072f8 ("drm/i915: Pass dev_priv to intel_setup_outputs()") Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: intel-gfx@lists.freedesktop.org Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> --- drivers/gpu/drm/i915/intel_psr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)