| Message ID | 1476906582-14241-1-git-send-email-javier@osg.samsung.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Javier Martinez Canillas <javier@osg.samsung.com> writes: > The Amlogic Meson is a DT-only platform, which means the devices are > registered via OF and not using the legacy platform devices support. > > So there's no need to have a MODULE_ALIAS("platform:meson-gxbb-wdt") > since the reported uevent MODALIAS to user-space will be the OF one. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Acked-by: Kevin Hilman <khilman@baylibre.com> > --- > > drivers/watchdog/meson_gxbb_wdt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c > index 44d180a2c5e5..45d47664a00a 100644 > --- a/drivers/watchdog/meson_gxbb_wdt.c > +++ b/drivers/watchdog/meson_gxbb_wdt.c > @@ -264,7 +264,6 @@ static struct platform_driver meson_gxbb_wdt_driver = { > > module_platform_driver(meson_gxbb_wdt_driver); > > -MODULE_ALIAS("platform:meson-gxbb-wdt"); > MODULE_AUTHOR("Neil Armstrong <narmstrong@baylibre.com>"); > MODULE_DESCRIPTION("Amlogic Meson GXBB Watchdog timer driver"); > MODULE_LICENSE("Dual BSD/GPL");
On Wed, Oct 19, 2016 at 04:49:42PM -0300, Javier Martinez Canillas wrote: > The Amlogic Meson is a DT-only platform, which means the devices are > registered via OF and not using the legacy platform devices support. > > So there's no need to have a MODULE_ALIAS("platform:meson-gxbb-wdt") > since the reported uevent MODALIAS to user-space will be the OF one. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Hello Wim, On 10/20/2016 07:28 PM, Guenter Roeck wrote: > On Wed, Oct 19, 2016 at 04:49:42PM -0300, Javier Martinez Canillas wrote: >> The Amlogic Meson is a DT-only platform, which means the devices are >> registered via OF and not using the legacy platform devices support. >> >> So there's no need to have a MODULE_ALIAS("platform:meson-gxbb-wdt") >> since the reported uevent MODALIAS to user-space will be the OF one. >> >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > Any comments about this patch? There are other two similar fixes for watchdog drivers that were also reviewed by Guenter but never picked: https://lkml.org/lkml/2016/10/14/412 https://lkml.org/lkml/2016/10/14/413 Best regards,
On 11/29/2016 06:57 AM, Javier Martinez Canillas wrote: > Hello Wim, > > On 10/20/2016 07:28 PM, Guenter Roeck wrote: >> On Wed, Oct 19, 2016 at 04:49:42PM -0300, Javier Martinez Canillas wrote: >>> The Amlogic Meson is a DT-only platform, which means the devices are >>> registered via OF and not using the legacy platform devices support. >>> >>> So there's no need to have a MODULE_ALIAS("platform:meson-gxbb-wdt") >>> since the reported uevent MODALIAS to user-space will be the OF one. >>> >>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >> >> Reviewed-by: Guenter Roeck <linux@roeck-us.net> >> > > Any comments about this patch? There are other two similar fixes for > watchdog drivers that were also reviewed by Guenter but never picked: > > https://lkml.org/lkml/2016/10/14/412 > https://lkml.org/lkml/2016/10/14/413 > > Best regards, > The patches are all in my watchdog-next branch, so Wim will hopefully pick them up for the next release. Guenter
Hello Guenter, On 11/30/2016 07:59 AM, Guenter Roeck wrote: > On 11/29/2016 06:57 AM, Javier Martinez Canillas wrote: >> Hello Wim, >> >> On 10/20/2016 07:28 PM, Guenter Roeck wrote: >>> On Wed, Oct 19, 2016 at 04:49:42PM -0300, Javier Martinez Canillas wrote: >>>> The Amlogic Meson is a DT-only platform, which means the devices are >>>> registered via OF and not using the legacy platform devices support. >>>> >>>> So there's no need to have a MODULE_ALIAS("platform:meson-gxbb-wdt") >>>> since the reported uevent MODALIAS to user-space will be the OF one. >>>> >>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >>> >>> Reviewed-by: Guenter Roeck <linux@roeck-us.net> >>> >> >> Any comments about this patch? There are other two similar fixes for >> watchdog drivers that were also reviewed by Guenter but never picked: >> >> https://lkml.org/lkml/2016/10/14/412 >> https://lkml.org/lkml/2016/10/14/413 >> >> Best regards, >> > The patches are all in my watchdog-next branch, so Wim will hopefully > pick them up for the next release. > Great, thanks a lot for the info. > Guenter > Best regards,
diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c index 44d180a2c5e5..45d47664a00a 100644 --- a/drivers/watchdog/meson_gxbb_wdt.c +++ b/drivers/watchdog/meson_gxbb_wdt.c @@ -264,7 +264,6 @@ static struct platform_driver meson_gxbb_wdt_driver = { module_platform_driver(meson_gxbb_wdt_driver); -MODULE_ALIAS("platform:meson-gxbb-wdt"); MODULE_AUTHOR("Neil Armstrong <narmstrong@baylibre.com>"); MODULE_DESCRIPTION("Amlogic Meson GXBB Watchdog timer driver"); MODULE_LICENSE("Dual BSD/GPL");
The Amlogic Meson is a DT-only platform, which means the devices are registered via OF and not using the legacy platform devices support. So there's no need to have a MODULE_ALIAS("platform:meson-gxbb-wdt") since the reported uevent MODALIAS to user-space will be the OF one. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- drivers/watchdog/meson_gxbb_wdt.c | 1 - 1 file changed, 1 deletion(-)