diff mbox

libexport.a: fix using bad index for loop at cltsetup()

Message ID 4DF6C46C.9030201@cn.fujitsu.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mi Jinlong June 14, 2011, 2:16 a.m. UTC
At cltsetup(), for address checking, it should use clp's naddr for index, 
not cltarg's naddr(and it's always zero here).

Signed-off-by: Mi Jinlong <mijinlong@cn.fujitsu.com>
---
 support/export/nfsctl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Mi Jinlong June 14, 2011, 2:54 a.m. UTC | #1
Mi Jinlong ??:
> At cltsetup(), for address checking, it should use clp's naddr for index, 
> not cltarg's naddr(and it's always zero here).

  After sending this patch, I find this problem was introduced by 6299a.
Steve Dickson June 22, 2011, 10:35 p.m. UTC | #2
On 06/13/2011 10:16 PM, Mi Jinlong wrote:
> At cltsetup(), for address checking, it should use clp's naddr for index, 
> not cltarg's naddr(and it's always zero here).
> 
> Signed-off-by: Mi Jinlong <mijinlong@cn.fujitsu.com>
> ---
>  support/export/nfsctl.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/support/export/nfsctl.c b/support/export/nfsctl.c
> index f89c644..2950a90 100644
> --- a/support/export/nfsctl.c
> +++ b/support/export/nfsctl.c
> @@ -78,7 +78,7 @@ cltsetup(struct nfsctl_client *cltarg, nfs_client *clp)
>  	str_tolower(cltarg->cl_ident);
>  
>  	j = 0;
> -	for (i = 0; i < cltarg->cl_naddr && i < NFSCLNT_ADDRMAX; i++) {
> +	for (i = 0; i < clp->m_naddr && i < NFSCLNT_ADDRMAX; i++) {
>  		const struct sockaddr_in *sin = get_addrlist_in(clp, i);
>  		if (sin->sin_family == AF_INET)
>  			cltarg->cl_addrlist[j++] = sin->sin_addr;
Committed..

steved.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/support/export/nfsctl.c b/support/export/nfsctl.c
index f89c644..2950a90 100644
--- a/support/export/nfsctl.c
+++ b/support/export/nfsctl.c
@@ -78,7 +78,7 @@  cltsetup(struct nfsctl_client *cltarg, nfs_client *clp)
 	str_tolower(cltarg->cl_ident);
 
 	j = 0;
-	for (i = 0; i < cltarg->cl_naddr && i < NFSCLNT_ADDRMAX; i++) {
+	for (i = 0; i < clp->m_naddr && i < NFSCLNT_ADDRMAX; i++) {
 		const struct sockaddr_in *sin = get_addrlist_in(clp, i);
 		if (sin->sin_family == AF_INET)
 			cltarg->cl_addrlist[j++] = sin->sin_addr;