| Message ID | 5c0eea3c-5265-b996-2523-c68b969ca7d6@epam.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Artem, On 30/11/16 13:53, Artem Mygaiev wrote: > Fix misplaced parentheses for PSCI version check > > Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com> Can you please include the coverity ID: Coverity-ID: 1381830 With that: Reviewed-by: Julien Grall <julien.grall@arm.com> This has been introduced by me in commit 2831f20 "xen/arm: Add support of PSCI v1.0 for the host" in Xen 4.7. I am not sure whether we should backport it. Cheers,
On Wed, 30 Nov 2016, Julien Grall wrote: > Hi Artem, > > On 30/11/16 13:53, Artem Mygaiev wrote: > > Fix misplaced parentheses for PSCI version check > > > > Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com> > > Can you please include the coverity ID: > > Coverity-ID: 1381830 > > With that: > > Reviewed-by: Julien Grall <julien.grall@arm.com> > > This has been introduced by me in commit 2831f20 "xen/arm: Add support of PSCI > v1.0 for the host" in Xen 4.7. I am not sure whether we should backport it. I think we should backport it. Wei, can I have a release-ack or do you want to wait until after the release?
On Wed, Nov 30, 2016 at 11:16:49AM -0800, Stefano Stabellini wrote: > On Wed, 30 Nov 2016, Julien Grall wrote: > > Hi Artem, > > > > On 30/11/16 13:53, Artem Mygaiev wrote: > > > Fix misplaced parentheses for PSCI version check > > > > > > Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com> > > > > Can you please include the coverity ID: > > > > Coverity-ID: 1381830 > > > > With that: > > > > Reviewed-by: Julien Grall <julien.grall@arm.com> > > > > This has been introduced by me in commit 2831f20 "xen/arm: Add support of PSCI > > v1.0 for the host" in Xen 4.7. I am not sure whether we should backport it. > > I think we should backport it. > > Wei, can I have a release-ack or do you want to wait until after the > release? Please wait until after the release. Wei.
On Thu, 1 Dec 2016, Wei Liu wrote: > On Wed, Nov 30, 2016 at 11:16:49AM -0800, Stefano Stabellini wrote: > > On Wed, 30 Nov 2016, Julien Grall wrote: > > > Hi Artem, > > > > > > On 30/11/16 13:53, Artem Mygaiev wrote: > > > > Fix misplaced parentheses for PSCI version check > > > > > > > > Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com> > > > > > > Can you please include the coverity ID: > > > > > > Coverity-ID: 1381830 > > > > > > With that: > > > > > > Reviewed-by: Julien Grall <julien.grall@arm.com> > > > > > > This has been introduced by me in commit 2831f20 "xen/arm: Add support of PSCI > > > v1.0 for the host" in Xen 4.7. I am not sure whether we should backport it. > > > > I think we should backport it. > > > > Wei, can I have a release-ack or do you want to wait until after the > > release? > > Please wait until after the release. In the meantime, I applied to xen-arm-next.
Thanks, resent On 30.11.16 17:55, Julien Grall wrote: > Hi Artem, > > On 30/11/16 13:53, Artem Mygaiev wrote: >> Fix misplaced parentheses for PSCI version check >> >> Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com> > > Can you please include the coverity ID: > > Coverity-ID: 1381830 > > With that: > > Reviewed-by: Julien Grall <julien.grall@arm.com> > > This has been introduced by me in commit 2831f20 "xen/arm: Add support of PSCI v1.0 for the host" in Xen 4.7. I am not sure whether we should backport it. > > Cheers, >
diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c index 7966b5e..34ee97e 100644 --- a/xen/arch/arm/psci.c +++ b/xen/arch/arm/psci.c @@ -147,7 +147,7 @@ int __init psci_init_0_2(void) psci_ver = call_smc(PSCI_0_2_FN_PSCI_VERSION, 0, 0, 0); /* For the moment, we only support PSCI 0.2 and PSCI 1.x */ - if ( psci_ver != PSCI_VERSION(0, 2) && PSCI_VERSION_MAJOR(psci_ver != 1) ) + if ( psci_ver != PSCI_VERSION(0, 2) && PSCI_VERSION_MAJOR(psci_ver) != 1 ) { printk("Error: Unrecognized PSCI version %u.%u\n", PSCI_VERSION_MAJOR(psci_ver), PSCI_VERSION_MINOR(psci_ver));
Fix misplaced parentheses for PSCI version check Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com> --- xen/arch/arm/psci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)