diff mbox

[PATCHv2] xen/arm: Fix misplaced parentheses for PSCI version check

Message ID 44269e56-5f91-1426-b182-7579bbd165e6@epam.com (mailing list archive)
State New, archived
Headers show

Commit Message

Artem Mygaiev Dec. 6, 2016, 1:57 p.m. UTC 
Fix misplaced parentheses for PSCI version check
Coverity-ID: 1381830

Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com>

Reviewed-by: Julien Grall <julien.grall@arm.com>

---
 xen/arch/arm/psci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Julien Grall Dec. 6, 2016, 2:03 p.m. UTC | #1 
Hi Artem,

On 06/12/16 13:57, Artem Mygaiev wrote:
> Fix misplaced parentheses for PSCI version check
> Coverity-ID: 1381830
>
> Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com>
>
> Reviewed-by: Julien Grall <julien.grall@arm.com>

It looks like that Stefano already queued this patch in xen-arm-next.

Although, the Coverity-ID has not been added as I requested. Stefano, 
I'd like to have a tag with the coverity ID when it is relevant. It 
makes easier to track what has been fixed or not.

Cheers,
Stefano Stabellini Dec. 6, 2016, 6:44 p.m. UTC | #2 
On Tue, 6 Dec 2016, Julien Grall wrote:
> Hi Artem,
> 
> On 06/12/16 13:57, Artem Mygaiev wrote:
> > Fix misplaced parentheses for PSCI version check
> > Coverity-ID: 1381830
> > 
> > Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com>
> > 
> > Reviewed-by: Julien Grall <julien.grall@arm.com>
> 
> It looks like that Stefano already queued this patch in xen-arm-next.
> 
> Although, the Coverity-ID has not been added as I requested. Stefano, I'd like
> to have a tag with the coverity ID when it is relevant. It makes easier to
> track what has been fixed or not.
 
I agree. This one was already committed, but let's do it from now on.
diff mbox

Patch

diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c
index 7966b5e..34ee97e 100644
--- a/xen/arch/arm/psci.c
+++ b/xen/arch/arm/psci.c
@@ -147,7 +147,7 @@  int __init psci_init_0_2(void)
     psci_ver = call_smc(PSCI_0_2_FN_PSCI_VERSION, 0, 0, 0);

     /* For the moment, we only support PSCI 0.2 and PSCI 1.x */
-    if ( psci_ver != PSCI_VERSION(0, 2) && PSCI_VERSION_MAJOR(psci_ver != 1) )
+    if ( psci_ver != PSCI_VERSION(0, 2) && PSCI_VERSION_MAJOR(psci_ver) != 1 )
     {
         printk("Error: Unrecognized PSCI version %u.%u\n",
                PSCI_VERSION_MAJOR(psci_ver), PSCI_VERSION_MINOR(psci_ver));