| Message ID | 1481529653-28133-1-git-send-email-boris.brezillon@free-electrons.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Stephen Boyd |
| Headers | show |
On Monday, December 12, 2016 9:00:53 AM CET Boris Brezillon wrote: > best_rate is reported as potentially uninitialized by gcc. > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > Fixes: 155e8b3b0ee3 ("clk: bcm: Support rate change propagation on bcm2835 clocks") > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> I wonder why I didn't get that. Which compiler version did you use? Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Arnd, On Mon, 12 Dec 2016 09:12:36 +0100 Arnd Bergmann <arnd@arndb.de> wrote: > > On Monday, December 12, 2016 9:00:53 AM CET Boris Brezillon wrote: > > best_rate is reported as potentially uninitialized by gcc. > > > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > Fixes: 155e8b3b0ee3 ("clk: bcm: Support rate change propagation on bcm2835 clocks") > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > > I wonder why I didn't get that. Which compiler version did you use? Gcc-5.2.0 powerpc-le hosted cross compiler.
On Mon, 12 Dec 2016 09:12:36 +0100 Arnd Bergmann <arnd@arndb.de> wrote: > On Monday, December 12, 2016 9:00:53 AM CET Boris Brezillon wrote: > > best_rate is reported as potentially uninitialized by gcc. > > > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > Fixes: 155e8b3b0ee3 ("clk: bcm: Support rate change propagation on bcm2835 clocks") > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > > I wonder why I didn't get that. Which compiler version did you use? > In case you're interested, my gcc [1] failed to detect it as well, and this is not the first time it happens :-/. [1]gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Monday, December 12, 2016 9:31:30 AM CET Boris Brezillon wrote: > On Mon, 12 Dec 2016 09:12:36 +0100 > Arnd Bergmann <arnd@arndb.de> wrote: > > > On Monday, December 12, 2016 9:00:53 AM CET Boris Brezillon wrote: > > > best_rate is reported as potentially uninitialized by gcc. > > > > > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > > Fixes: 155e8b3b0ee3 ("clk: bcm: Support rate change propagation on bcm2835 clocks") > > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > > > > I wonder why I didn't get that. Which compiler version did you use? > > > > In case you're interested, my gcc [1] failed to detect it as well, and > this is not the first time it happens :-/. > > [1]gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 No, I see it now with gcc-7, it only just turned up in linux-next. I ran into it right away with an allmodconfig build. You were probably testing based on an earlier v4.9-rc release that had the warning globally disabled. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 12 Dec 2016 09:34:28 +0100 Arnd Bergmann <arnd@arndb.de> wrote: > On Monday, December 12, 2016 9:31:30 AM CET Boris Brezillon wrote: > > On Mon, 12 Dec 2016 09:12:36 +0100 > > Arnd Bergmann <arnd@arndb.de> wrote: > > > > > On Monday, December 12, 2016 9:00:53 AM CET Boris Brezillon wrote: > > > > best_rate is reported as potentially uninitialized by gcc. > > > > > > > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > > > Fixes: 155e8b3b0ee3 ("clk: bcm: Support rate change propagation on bcm2835 clocks") > > > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > > > > > > I wonder why I didn't get that. Which compiler version did you use? > > > > > > > In case you're interested, my gcc [1] failed to detect it as well, and > > this is not the first time it happens :-/. > > > > [1]gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 > > No, I see it now with gcc-7, it only just turned up in linux-next. > > I ran into it right away with an allmodconfig build. You were > probably testing based on an earlier v4.9-rc release that had > the warning globally disabled. Indeed, I was testing on a 4.9-rc. -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Boris Brezillon <boris.brezillon@free-electrons.com> writes: > best_rate is reported as potentially uninitialized by gcc. > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > Fixes: 155e8b3b0ee3 ("clk: bcm: Support rate change propagation on bcm2835 clocks") > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Reviewed-by: Eric Anholt <eric@anholt.net>
On 12/12, Boris Brezillon wrote: > best_rate is reported as potentially uninitialized by gcc. > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > Fixes: 155e8b3b0ee3 ("clk: bcm: Support rate change propagation on bcm2835 clocks") > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > --- Applied to clk-next
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index eaf82f49dede..0d14409097e7 100644 --- a/drivers/clk/bcm/clk-bcm2835.c +++ b/drivers/clk/bcm/clk-bcm2835.c @@ -1029,7 +1029,7 @@ static unsigned long bcm2835_clock_choose_div_and_prate(struct clk_hw *hw, struct bcm2835_clock *clock = bcm2835_clock_from_hw(hw); struct bcm2835_cprman *cprman = clock->cprman; const struct bcm2835_clock_data *data = clock->data; - unsigned long best_rate; + unsigned long best_rate = 0; u32 curdiv, mindiv, maxdiv; struct clk_hw *parent;
best_rate is reported as potentially uninitialized by gcc. Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> Fixes: 155e8b3b0ee3 ("clk: bcm: Support rate change propagation on bcm2835 clocks") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> --- drivers/clk/bcm/clk-bcm2835.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)