| Message ID | 1481188984-43683-6-git-send-email-yao.yuan@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote: > From: Yuan Yao <yao.yuan@nxp.com> Same problem in this subject too. > > new compatible string: "fsl,ls1012a-qspi". > > Signed-off-by: Yuan Yao <yao.yuan@nxp.com> > --- > Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 + > 1 file changed, 1 insertion(+) Acked-by: Rob Herring <robh@kernel.org>
On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote: > On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote: > > From: Yuan Yao <yao.yuan@nxp.com> > > Same problem in this subject too. > > > > > new compatible string: "fsl,ls1012a-qspi". > > > > Signed-off-by: Yuan Yao <yao.yuan@nxp.com> > > --- > > Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 + > > 1 file changed, 1 insertion(+) > > Acked-by: Rob Herring <robh@kernel.org> Thanks for your review. And do you have any suggestion for this subject? I will update the subject and send v2 soon.
On Mon, Dec 12, 2016 at 8:47 PM, Yao Yuan <yao.yuan@nxp.com> wrote: > On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote: >> On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote: >> > From: Yuan Yao <yao.yuan@nxp.com> >> >> Same problem in this subject too. >> >> > >> > new compatible string: "fsl,ls1012a-qspi". >> > >> > Signed-off-by: Yuan Yao <yao.yuan@nxp.com> >> > --- >> > Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 + >> > 1 file changed, 1 insertion(+) >> >> Acked-by: Rob Herring <robh@kernel.org> > > Thanks for your review. > And do you have any suggestion for this subject? The problem is you have a space in the compatible string: "fsl, ls1012a-qspi" rather than "fsl,ls1012a-qspi" Also, I prefer "dt/bindings: " as the beginning of binding patch subjects. Rob
On Thu, Dec 14, 2016 at 05:23:02PM +0800, Rob Herring wrote: > On Mon, Dec 12, 2016 at 8:47 PM, Yao Yuan <yao.yuan@nxp.com> wrote: > > On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote: > >> On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote: > >> > From: Yuan Yao <yao.yuan@nxp.com> > >> > >> Same problem in this subject too. > >> > >> > > >> > new compatible string: "fsl,ls1012a-qspi". > >> > > >> > Signed-off-by: Yuan Yao <yao.yuan@nxp.com> > >> > --- > >> > Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 + > >> > 1 file changed, 1 insertion(+) > >> > >> Acked-by: Rob Herring <robh@kernel.org> > > > > Thanks for your review. > > And do you have any suggestion for this subject? > > The problem is you have a space in the compatible string: "fsl, ls1012a-qspi" > rather than "fsl,ls1012a-qspi" > > Also, I prefer "dt/bindings: " as the beginning of binding patch subjects. > Ok, Get it. Thanks for your comments. I will send v2 soon.
diff --git a/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt b/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt index c34aa6f..a2ed621 100644 --- a/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt +++ b/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt @@ -7,6 +7,7 @@ Required properties: or "fsl,ls2080a-qspi" followed by "fsl,ls1021a-qspi", "fsl,ls1043a-qspi" followed by "fsl,ls1021a-qspi" + "fsl,ls1012a-qspi" followed by "fsl,ls1021a-qspi" - reg : the first contains the register location and length, the second contains the memory mapping address and length - reg-names: Should contain the reg names "QuadSPI" and "QuadSPI-memory"