diff mbox

n900 device tree: cleanup

Message ID 20161011081243.GA24580@amd (mailing list archive)
State New, archived
Headers show

Commit Message

Pavel Machek Oct. 11, 2016, 8:12 a.m. UTC 
Fix GPIO comment to be consistent with rest of file and add comment what
tpa6130 is.

Signed-off-by: Pavel Machek <pavel@ucw.cz>

Comments

Sebastian Reichel Dec. 7, 2016, 3:10 a.m. UTC | #1 
Hi Tony,

It looks like this fell through the cracks. Apart from inconsistent
patch subject:

Reviewed-By: Sebastian Reichel <sre@kernel.org>

-- Sebastian

On Tue, Oct 11, 2016 at 10:12:43AM +0200, Pavel Machek wrote:
> Fix GPIO comment to be consistent with rest of file and add comment what
> tpa6130 is.
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index bfffd6c..ca9fe8c 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -47,7 +47,7 @@
>  		compatible = "gpio-leds";
>  		heartbeat {
>  			label = "debug::sleep";
> -			gpios = <&gpio6 2 GPIO_ACTIVE_HIGH>;  /* gpio162 */
> +			gpios = <&gpio6 2 GPIO_ACTIVE_HIGH>;  /* 162 */
>  			linux,default-trigger = "default-on";
>  			pinctrl-names = "default";
>  			pinctrl-0 = <&debug_leds>;
> @@ -637,6 +637,7 @@
>  		reg = <0x55>;
>  	};
>  
> +	/* Stereo headphone amplifier */
>  	tpa6130a2: tpa6130a2@60 {
>  		compatible = "ti,tpa6130a2";
>  		reg = <0x60>;
Pali Rohár Dec. 14, 2016, 12:28 p.m. UTC | #2 
On Wednesday 07 December 2016 04:10:48 Sebastian Reichel wrote:
> Hi Tony,
> 
> It looks like this fell through the cracks. Apart from inconsistent
> patch subject:
> 
> Reviewed-By: Sebastian Reichel <sre@kernel.org>

Fine for me too. Reviewed-By: Pali Rohár <pali.rohar@gmail.com>

> -- Sebastian
> 
> On Tue, Oct 11, 2016 at 10:12:43AM +0200, Pavel Machek wrote:
> > Fix GPIO comment to be consistent with rest of file and add comment
> > what tpa6130 is.
> > 
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > 
> > diff --git a/arch/arm/boot/dts/omap3-n900.dts
> > b/arch/arm/boot/dts/omap3-n900.dts index bfffd6c..ca9fe8c 100644
> > --- a/arch/arm/boot/dts/omap3-n900.dts
> > +++ b/arch/arm/boot/dts/omap3-n900.dts
> > @@ -47,7 +47,7 @@
> > 
> >  		compatible = "gpio-leds";
> >  		heartbeat {
> >  		
> >  			label = "debug::sleep";
> > 
> > -			gpios = <&gpio6 2 GPIO_ACTIVE_HIGH>;  /* gpio162 */
> > +			gpios = <&gpio6 2 GPIO_ACTIVE_HIGH>;  /* 162 */
> > 
> >  			linux,default-trigger = "default-on";
> >  			pinctrl-names = "default";
> >  			pinctrl-0 = <&debug_leds>;
> > 
> > @@ -637,6 +637,7 @@
> > 
> >  		reg = <0x55>;
> >  	
> >  	};
> > 
> > +	/* Stereo headphone amplifier */
> > 
> >  	tpa6130a2: tpa6130a2@60 {
> >  	
> >  		compatible = "ti,tpa6130a2";
> >  		reg = <0x60>;
Tony Lindgren Jan. 5, 2017, 4:15 p.m. UTC | #3 
* Pali Rohár <pali.rohar@gmail.com> [161214 04:28]:
> On Wednesday 07 December 2016 04:10:48 Sebastian Reichel wrote:
> > Hi Tony,
> > 
> > It looks like this fell through the cracks. Apart from inconsistent
> > patch subject:
> > 
> > Reviewed-By: Sebastian Reichel <sre@kernel.org>
> 
> Fine for me too. Reviewed-By: Pali Rohár <pali.rohar@gmail.com>

Fixing subject line to use "ARM: dts: n900: cleanup" and applying into
omap-for-v4.11/dt.

Tony
diff mbox

Patch

diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index bfffd6c..ca9fe8c 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -47,7 +47,7 @@ 
 		compatible = "gpio-leds";
 		heartbeat {
 			label = "debug::sleep";
-			gpios = <&gpio6 2 GPIO_ACTIVE_HIGH>;  /* gpio162 */
+			gpios = <&gpio6 2 GPIO_ACTIVE_HIGH>;  /* 162 */
 			linux,default-trigger = "default-on";
 			pinctrl-names = "default";
 			pinctrl-0 = <&debug_leds>;
@@ -637,6 +637,7 @@ 
 		reg = <0x55>;
 	};
 
+	/* Stereo headphone amplifier */
 	tpa6130a2: tpa6130a2@60 {
 		compatible = "ti,tpa6130a2";
 		reg = <0x60>;