| Message ID | 1477400039-16925-1-git-send-email-Ram.Amrani@cavium.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Tue, Oct 25, 2016 at 03:53:59PM +0300, Ram Amrani wrote: > The recent introduction of qedr driver support in qede causes a > GPF when probing the driver in a server without a RoCE enabled > QLogic NIC. This fix avoids using an uninitialized pointer in such > a case. Caught by the kernel test robot. > > Signed-off-by: Ram Amrani <Ram.Amrani@cavium.com> > --- > drivers/net/ethernet/qlogic/qede/qede_roce.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Ram, The rdma-core word in the subject is misleading. Thanks > > diff --git a/drivers/net/ethernet/qlogic/qede/qede_roce.c b/drivers/net/ethernet/qlogic/qede/qede_roce.c > index 9867f96..4927271 100644 > --- a/drivers/net/ethernet/qlogic/qede/qede_roce.c > +++ b/drivers/net/ethernet/qlogic/qede/qede_roce.c > @@ -191,8 +191,8 @@ int qede_roce_register_driver(struct qedr_driver *drv) > } > mutex_unlock(&qedr_dev_list_lock); > > - DP_INFO(edev, "qedr: discovered and registered %d RoCE funcs\n", > - qedr_counter); > + pr_notice("qedr: discovered and registered %d RoCE funcs\n", > + qedr_counter); > > return 0; > } > -- > 1.8.3.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
> The rdma-core word in the subject is misleading.
Yeah it is. The location of the code (qede) is somewhat different from the content (qedr).
I don't know how you would have done it, but at least you'll see in a future patch that we've
changed this to be fully qedr.
Ram
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Oct 30, 2016 at 09:25:09AM +0000, Amrani, Ram wrote: > > The rdma-core word in the subject is misleading. > > Yeah it is. The location of the code (qede) is somewhat different from the content (qedr). > I don't know how you would have done it, but at least you'll see in a future patch that we've > changed this to be fully qedr. We use "rdma-core" notations for patches intended to consolidated library, while your patch is for the kernel. > > Ram > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
> We use "rdma-core" notations for patches intended to consolidated library, > while your patch is for the kernel. ACK. My bad. Shall I re-send it? Ram -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Nov 01, 2016 at 01:34:23PM +0000, Amrani, Ram wrote: > > We use "rdma-core" notations for patches intended to consolidated library, > > while your patch is for the kernel. > > ACK. My bad. Shall I re-send it? No, there is no need. The information from [..] is stripped from the actual applied patch. Thanks > > Ram > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
> The recent introduction of qedr driver support in qede causes a GPF when > probing the driver in a server without a RoCE enabled QLogic NIC. This fix avoids > using an uninitialized pointer in such a case. Caught by the kernel test robot. > > Signed-off-by: Ram Amrani <Ram.Amrani@cavium.com> > --- > drivers/net/ethernet/qlogic/qede/qede_roce.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/qlogic/qede/qede_roce.c > b/drivers/net/ethernet/qlogic/qede/qede_roce.c > index 9867f96..4927271 100644 > --- a/drivers/net/ethernet/qlogic/qede/qede_roce.c > +++ b/drivers/net/ethernet/qlogic/qede/qede_roce.c > @@ -191,8 +191,8 @@ int qede_roce_register_driver(struct qedr_driver *drv) > } > mutex_unlock(&qedr_dev_list_lock); > > - DP_INFO(edev, "qedr: discovered and registered %d RoCE funcs\n", > - qedr_counter); > + pr_notice("qedr: discovered and registered %d RoCE funcs\n", > + qedr_counter); > > return 0; > } > -- > 1.8.3.1 Hi Doug, Can you update if this patch taken and if not, when do you expect it will be? Thanks, Ram -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/13/2016 11:42 AM, Amrani, Ram wrote: >> The recent introduction of qedr driver support in qede causes a GPF when >> probing the driver in a server without a RoCE enabled QLogic NIC. This fix avoids >> using an uninitialized pointer in such a case. Caught by the kernel test robot. >> >> Signed-off-by: Ram Amrani <Ram.Amrani@cavium.com> >> --- >> drivers/net/ethernet/qlogic/qede/qede_roce.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/qlogic/qede/qede_roce.c >> b/drivers/net/ethernet/qlogic/qede/qede_roce.c >> index 9867f96..4927271 100644 >> --- a/drivers/net/ethernet/qlogic/qede/qede_roce.c >> +++ b/drivers/net/ethernet/qlogic/qede/qede_roce.c >> @@ -191,8 +191,8 @@ int qede_roce_register_driver(struct qedr_driver *drv) >> } >> mutex_unlock(&qedr_dev_list_lock); >> >> - DP_INFO(edev, "qedr: discovered and registered %d RoCE funcs\n", >> - qedr_counter); >> + pr_notice("qedr: discovered and registered %d RoCE funcs\n", >> + qedr_counter); >> >> return 0; >> } >> -- >> 1.8.3.1 > > > Hi Doug, > Can you update if this patch taken and if not, when do you expect it will be? This patch no longer applies. But, more importantly, it's a patch to the ethernet side of the driver and should go through Dave Miller anyway.
diff --git a/drivers/net/ethernet/qlogic/qede/qede_roce.c b/drivers/net/ethernet/qlogic/qede/qede_roce.c index 9867f96..4927271 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_roce.c +++ b/drivers/net/ethernet/qlogic/qede/qede_roce.c @@ -191,8 +191,8 @@ int qede_roce_register_driver(struct qedr_driver *drv) } mutex_unlock(&qedr_dev_list_lock); - DP_INFO(edev, "qedr: discovered and registered %d RoCE funcs\n", - qedr_counter); + pr_notice("qedr: discovered and registered %d RoCE funcs\n", + qedr_counter); return 0; }
The recent introduction of qedr driver support in qede causes a GPF when probing the driver in a server without a RoCE enabled QLogic NIC. This fix avoids using an uninitialized pointer in such a case. Caught by the kernel test robot. Signed-off-by: Ram Amrani <Ram.Amrani@cavium.com> --- drivers/net/ethernet/qlogic/qede/qede_roce.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)