qemu: bunch of spelling-fixes

Commit Message

Marc-André Lureau Dec. 27, 2016, 5:19 p.m. UTC

Hi,

----- Original Message -----
> Hi,
> 
> I used misspell_fixer [1], [2] on qemu sources. (used
> http://git.qemu.org/qemu.git )
> found a bunch of typos, patches with spelling-fixes attached.
> 

Nice tool, thanks for the links.

> so.. i did all these stuff, before read and fully understood the full
> "howto submit patch".
> 
> phew. sounds too complicated.. sitting on wrong machine, wrong email
> addresses and want to keep my personal footprint out there as small as
> possible.
> And hey, this are just typo-fixes, no rocket-science. It was even easier
> to get the fixes into openssl
> 
> But throwing the stuff as its done not into /dev/null is also not good.
> So i picked someone at random from the trivial-mailinglist... tada...
> 

If you don't have the time to follow http://qemu-project.org/Contribute/SubmitAPatch, perhaps someone else will do it for you, or not.

> 
> I'm attaching 2 patches.
> 1) is just for comments and texts. ( all the .txt, CHANGELOG,
> /*comment*/ stuff )
>     after applying, the compiled binary should [3] still be same.
> 2) some printf() related output.
> 
> ... and I did not test the stuff.

Not a good idea :)

> 
> lg
> .klemens
> 
> 1] https://github.com/ka7/misspell_fixer
>    it also relays heavily to the spelling-dictionary of debian-linter
> 2] https://github.com/ka7/misspell_fixer/tree/master/motivation
> 3] https://wiki.debian.org/ReproducibleBuilds/About

Comments

Peter Maydell Dec. 27, 2016, 5:24 p.m. UTC | #1

On 27 December 2016 at 17:19, Marc-André Lureau <[e-mail]> wrote:
> Hi,
>
> ----- Original Message -----
>> phew. sounds too complicated.. sitting on wrong machine, wrong email
>> addresses and want to keep my personal footprint out there as small as
>> possible.
>> And hey, this are just typo-fixes, no rocket-science. It was even easier
>> to get the fixes into openssl
>>
>> But throwing the stuff as its done not into /dev/null is also not good.
>> So i picked someone at random from the trivial-mailinglist... tada...
>>
>
> If you don't have the time to follow
> http://qemu-project.org/Contribute/SubmitAPatch, perhaps someone
> else will do it for you, or not.

An important part of the instructions is the part where you
have to provide your Signed-off-by: line with your name and
email address. This says "I own the copyright on these changes
and am happy for them to go into QEMU under the QEMU license".
Without that signoff we unfortunately can't accept the changes,
even if somebody else does the work of cleaning them up, reviewing
them and applying them :-(

thanks
-- PMM

Patch

From 45bc74375b60db2e82849a186f89af8d1dd05e53 Mon Sep 17 00:00:00 2001
From: klemens <[e-mail]>
Date: Sun, 25 Dec 2016 21:52:46 +0100
Subject: [PATCH 2/2] spelling fixes, might have an side-effect ( print() .. )

---
 scripts/tracetool/__init__.py     | 2 +-
 target/ppc/translate_init.c       | 2 +-
 tests/docker/docker.py            | 4 ++--
 tests/guest-debug/test-gdbstub.py | 2 +-
 tests/vhost-user-bridge.c         | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py
index 365446f..f7d139f 100644
--- a/scripts/tracetool/__init__.py
+++ b/scripts/tracetool/__init__.py
@@ -35,7 +35,7 @@  def error(*lines):
 def out(*lines, **kwargs):
     """Write a set of output lines.
 
-    You can use kwargs as a shorthand for mapping variables when formating all
+    You can use kwargs as a shorthand for mapping variables when formatting all
     the strings in lines.
     """
     lines = [ l % kwargs for l in lines ]
diff --git a/target/ppc/translate_init.c b/target/ppc/translate_init.c
index 626e031..cd3ba19 100644
--- a/target/ppc/translate_init.c
+++ b/target/ppc/translate_init.c
@@ -9861,7 +9861,7 @@  static void ppc_cpu_realizefn(DeviceState *dev, Error **errp)
 #if !defined(CONFIG_USER_ONLY)
         if (env->tlb.tlb6) {
             printf("                       %d %s TLB in %d ways\n",
-                   env->nb_tlb, env->id_tlbs ? "splitted" : "merged",
+                   env->nb_tlb, env->id_tlbs ? "split" : "merged",
                    env->nb_ways);
         }
 #endif
diff --git a/tests/docker/docker.py b/tests/docker/docker.py
index 37d8319..61b9504 100755
--- a/tests/docker/docker.py
+++ b/tests/docker/docker.py
@@ -83,7 +83,7 @@  def _get_so_libs(executable):
     return libs
 
 def _copy_binary_with_libs(src, dest_dir):
-    """Copy a binary executable and all its dependant libraries.
+    """Copy a binary executable and all its dependent libraries.
 
     This does rely on the host file-system being fairly multi-arch
     aware so the file don't clash with the guests layout."""
@@ -196,7 +196,7 @@  class SubCommand(object):
     name = None # Subcommand name
     def shared_args(self, parser):
         parser.add_argument("--quiet", action="store_true",
-                            help="Run quietly unless an error occured")
+                            help="Run quietly unless an error occurred")
 
     def args(self, parser):
         """Setup argument parser"""
diff --git a/tests/guest-debug/test-gdbstub.py b/tests/guest-debug/test-gdbstub.py
index 31ba6c9..88463f7 100644
--- a/tests/guest-debug/test-gdbstub.py
+++ b/tests/guest-debug/test-gdbstub.py
@@ -121,7 +121,7 @@  class CatchBreakpoint(gdb.Breakpoint):
 
 
 def run_test():
-    "Run throught the tests one by one"
+    "Run through the tests one by one"
 
     print ("Checking we can step the first few instructions")
     step_ok = 0
diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c
index 775e031..ebc4384 100644
--- a/tests/vhost-user-bridge.c
+++ b/tests/vhost-user-bridge.c
@@ -1426,7 +1426,7 @@  main(int argc, char *argv[])
 out:
     fprintf(stderr, "Usage: %s ", argv[0]);
     fprintf(stderr, "[-c] [-u ud_socket_path] [-l lhost:lport] [-r rhost:rport]\n");
-    fprintf(stderr, "\t-u path to unix doman socket. default: %s\n",
+    fprintf(stderr, "\t-u path to unix domain socket. default: %s\n",
             DEFAULT_UD_SOCKET);
     fprintf(stderr, "\t-l local host and port. default: %s:%s\n",
             DEFAULT_LHOST, DEFAULT_LPORT);
-- 
2.1.4