diff mbox

[1/2] drm: Add target_vblank member to drm_crtc_state

Message ID 1483286380-15865-2-git-send-email-Andrey.Grodzovsky@amd.com (mailing list archive)
State New, archived
Headers show

Commit Message

Andrey Grodzovsky Jan. 1, 2017, 3:59 p.m. UTC 
This change allows usage of the new page_flip_target hook for
drivers implementing the atomic path.

Signed-off-by: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
---
 include/drm/drm_crtc.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Daniel Vetter Jan. 2, 2017, 8:15 a.m. UTC | #1 
On Sun, Jan 1, 2017 at 4:59 PM, Andrey Grodzovsky
<Andrey.Grodzovsky@amd.com> wrote:
> This change allows usage of the new page_flip_target hook for
> drivers implementing the atomic path.
>
> Signed-off-by: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

Instead of patching your amdgpu version of the page_flip helper you
should patch at least the one in drm_atomic_helper..c, and then use
that one. We probably need a page_flip_target version of that, which
then opens some questions about how you would expose this for atomic
drivers and the atomic ioctl. Just adding this here in the shared
struct is somewhat pointless, you could do that in the
amdgpu_crtc_state struct too.

> ---
>  include/drm/drm_crtc.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index 946672f..3a7685f 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -156,6 +156,9 @@ struct drm_crtc_state {
>         struct drm_property_blob *ctm;
>         struct drm_property_blob *gamma_lut;
>
> +       /* target vblank count to do a flip */

Please type real kerneldoc for this.

Thanks, Daniel

> +       u32 target_vblank;
> +
>         /**
>          * @event:
>          *
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox

Patch

diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index 946672f..3a7685f 100644
--- a/include/drm/drm_crtc.h
+++ b/include/drm/drm_crtc.h
@@ -156,6 +156,9 @@  struct drm_crtc_state {
 	struct drm_property_blob *ctm;
 	struct drm_property_blob *gamma_lut;
 
+	/* target vblank count to do a flip */
+	u32 target_vblank;
+
 	/**
 	 * @event:
 	 *