| Message ID | 20161220095649.7674-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Dec 20 2016 or thereabouts, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > version is a u8, the check for version > 0 means that version can only > be zero, so the subsequent check for version != 0 is never true and > hence is redudant code and can be removed. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- Works for me: Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > drivers/input/rmi4/rmi_f34.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/input/rmi4/rmi_f34.c b/drivers/input/rmi4/rmi_f34.c > index 9774dfb..c3285ce 100644 > --- a/drivers/input/rmi4/rmi_f34.c > +++ b/drivers/input/rmi4/rmi_f34.c > @@ -441,8 +441,6 @@ static int rmi_f34_probe(struct rmi_function *fn) > /* v5 code only supported version 0, try V7 probe */ > if (version > 0) > return rmi_f34v7_probe(f34); > - else if (version != 0) > - return -ENODEV; > > f34->bl_version = 5; > > -- > 2.10.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/rmi4/rmi_f34.c b/drivers/input/rmi4/rmi_f34.c index 9774dfb..c3285ce 100644 --- a/drivers/input/rmi4/rmi_f34.c +++ b/drivers/input/rmi4/rmi_f34.c @@ -441,8 +441,6 @@ static int rmi_f34_probe(struct rmi_function *fn) /* v5 code only supported version 0, try V7 probe */ if (version > 0) return rmi_f34v7_probe(f34); - else if (version != 0) - return -ENODEV; f34->bl_version = 5;