| Message ID | 1483536181-22356-1-git-send-email-mnarani@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, Manish Narani <manish.narani@xilinx.com> writes: > This patch adds support for OTG driver compilation and object > file creation > > Signed-off-by: Manish Narani <mnarani@xilinx.com> > --- > drivers/usb/dwc3/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile > index ffca340..2d269ad 100644 > --- a/drivers/usb/dwc3/Makefile > +++ b/drivers/usb/dwc3/Makefile > @@ -17,6 +17,10 @@ ifneq ($(filter y,$(CONFIG_USB_DWC3_GADGET) $(CONFIG_USB_DWC3_DUAL_ROLE)),) > dwc3-y += gadget.o ep0.o > endif > > +ifneq ($(CONFIG_USB_DWC3_DUAL_ROLE),) > + dwc3-y += otg.o > +endif you just broke compilation
Hi Felipe, > From: Felipe Balbi [mailto:balbi@kernel.org] > Sent: Wednesday, January 04, 2017 7:01 PM > Hi, > > Manish Narani <manish.narani@xilinx.com> writes: > > This patch adds support for OTG driver compilation and object file > > creation > > > > Signed-off-by: Manish Narani <mnarani@xilinx.com> > > --- > > drivers/usb/dwc3/Makefile | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile > > index ffca340..2d269ad 100644 > > --- a/drivers/usb/dwc3/Makefile > > +++ b/drivers/usb/dwc3/Makefile > > @@ -17,6 +17,10 @@ ifneq ($(filter y,$(CONFIG_USB_DWC3_GADGET) > $(CONFIG_USB_DWC3_DUAL_ROLE)),) > > dwc3-y += gadget.o ep0.o > > endif > > > > +ifneq ($(CONFIG_USB_DWC3_DUAL_ROLE),) > > + dwc3-y += otg.o > > +endif > > you just broke compilation Should I add new USB_DWC3_OTG macro in Kconfig? Thanks, Manish This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
Hi, Manish Narani <manish.narani@xilinx.com> writes: > Hi Felipe, > > >> From: Felipe Balbi [mailto:balbi@kernel.org] >> Sent: Wednesday, January 04, 2017 7:01 PM >> Hi, >> >> Manish Narani <manish.narani@xilinx.com> writes: >> > This patch adds support for OTG driver compilation and object file >> > creation >> > >> > Signed-off-by: Manish Narani <mnarani@xilinx.com> >> > --- >> > drivers/usb/dwc3/Makefile | 4 ++++ >> > 1 file changed, 4 insertions(+) >> > >> > diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile >> > index ffca340..2d269ad 100644 >> > --- a/drivers/usb/dwc3/Makefile >> > +++ b/drivers/usb/dwc3/Makefile >> > @@ -17,6 +17,10 @@ ifneq ($(filter y,$(CONFIG_USB_DWC3_GADGET) >> $(CONFIG_USB_DWC3_DUAL_ROLE)),) >> > dwc3-y += gadget.o ep0.o >> > endif >> > >> > +ifneq ($(CONFIG_USB_DWC3_DUAL_ROLE),) >> > + dwc3-y += otg.o >> > +endif >> >> you just broke compilation > > Should I add new USB_DWC3_OTG macro in Kconfig? No, no. Reset your tree to this commit and try to compile it. Problem should be clear. > This email and any attachments are intended for the sole use of the > named recipient(s) and contain(s) confidential information that may be > proprietary, privileged or copyrighted under applicable law. If you > are not the intended recipient, do not read, copy, or forward this > email message or any attachments. Delete this email message and any > attachments immediately. you should make sure these notes aren't sent to public mailing lists. I'll delete this email of yours and stop reading them until this is sorted out.
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi index 68a90833..ce9ad02 100644 --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi @@ -351,7 +351,7 @@ compatible = "snps,dwc3"; status = "disabled"; interrupt-parent = <&gic>; - interrupts = <0 65 4>; + interrupts = <0 65 4>, <0 69 4>; reg = <0x0 0xfe200000 0x0 0x40000>; clock-names = "clk_xin", "clk_ahb"; };
This patch adds OTG interrupt support in device tree. It will add an extra interrupt line number dedicated to OTG events. This will enable OTG interrupts to serve in DWC3 OTG driver. Signed-off-by: Manish Narani <mnarani@xilinx.com> --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)