| Message ID | 20170102163723.7939-16-quentin.schulz@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 02 Jan 2017, Quentin Schulz wrote: > The CHR_CTRL1 register is made of 7 read-write bits with one being used > to set the target voltage for battery charging. > > This adds the CHRG_CTRL1 register to the list of writeable registers for > AXP20X and AXP22X PMICs. > > Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com> > --- > drivers/mfd/axp20x.c | 2 ++ > 1 file changed, 2 insertions(+) For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 65c57d0..19bdba3 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -66,6 +66,7 @@ static const struct regmap_access_table axp152_volatile_table = { > static const struct regmap_range axp20x_writeable_ranges[] = { > regmap_reg_range(AXP20X_DATACACHE(0), AXP20X_IRQ5_STATE), > regmap_reg_range(AXP20X_VBUS_IPSOUT_MGMT, AXP20X_VBUS_IPSOUT_MGMT), > + regmap_reg_range(AXP20X_CHRG_CTRL1, AXP20X_CHRG_CTRL1), > regmap_reg_range(AXP20X_DCDC_MODE, AXP20X_FG_RES), > regmap_reg_range(AXP20X_RDC_H, AXP20X_OCV(AXP20X_OCV_MAX)), > }; > @@ -94,6 +95,7 @@ static const struct regmap_access_table axp20x_volatile_table = { > static const struct regmap_range axp22x_writeable_ranges[] = { > regmap_reg_range(AXP20X_DATACACHE(0), AXP20X_IRQ5_STATE), > regmap_reg_range(AXP20X_VBUS_IPSOUT_MGMT, AXP20X_VBUS_IPSOUT_MGMT), > + regmap_reg_range(AXP20X_CHRG_CTRL1, AXP20X_CHRG_CTRL1), > regmap_reg_range(AXP20X_DCDC_MODE, AXP22X_BATLOW_THRES1), > }; >
On Tue, Jan 3, 2017 at 12:37 AM, Quentin Schulz <quentin.schulz@free-electrons.com> wrote: > The CHR_CTRL1 register is made of 7 read-write bits with one being used > to set the target voltage for battery charging. The description is incorrect. All 8 bits are read-write: - The highest bit enables the charger module - Bits [6:5] set the target voltage - Bits [4:3] set when the charge cycle ends, based on percentage of charge current - Bits [2:0] set the charge current Feel free to use the above in the commit message. > > This adds the CHRG_CTRL1 register to the list of writeable registers for > AXP20X and AXP22X PMICs. You might want to add up to CHRG_CTRL3 for the AXP22x and CHRG_CTRL2 for the AXP20x. These control additional aspects of the charger. AXP20X_CHRG_BAK_CTRL controls the charger for the RTC battery. You could add this now, or let the person doing the RTC battery driver add it. Regards ChenYu > > Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com> > --- > drivers/mfd/axp20x.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 65c57d0..19bdba3 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -66,6 +66,7 @@ static const struct regmap_access_table axp152_volatile_table = { > static const struct regmap_range axp20x_writeable_ranges[] = { > regmap_reg_range(AXP20X_DATACACHE(0), AXP20X_IRQ5_STATE), > regmap_reg_range(AXP20X_VBUS_IPSOUT_MGMT, AXP20X_VBUS_IPSOUT_MGMT), > + regmap_reg_range(AXP20X_CHRG_CTRL1, AXP20X_CHRG_CTRL1), > regmap_reg_range(AXP20X_DCDC_MODE, AXP20X_FG_RES), > regmap_reg_range(AXP20X_RDC_H, AXP20X_OCV(AXP20X_OCV_MAX)), > }; > @@ -94,6 +95,7 @@ static const struct regmap_access_table axp20x_volatile_table = { > static const struct regmap_range axp22x_writeable_ranges[] = { > regmap_reg_range(AXP20X_DATACACHE(0), AXP20X_IRQ5_STATE), > regmap_reg_range(AXP20X_VBUS_IPSOUT_MGMT, AXP20X_VBUS_IPSOUT_MGMT), > + regmap_reg_range(AXP20X_CHRG_CTRL1, AXP20X_CHRG_CTRL1), > regmap_reg_range(AXP20X_DCDC_MODE, AXP22X_BATLOW_THRES1), > }; > > -- > 2.9.3 >
On 05/01/2017 07:10, Chen-Yu Tsai wrote: > On Tue, Jan 3, 2017 at 12:37 AM, Quentin Schulz > <quentin.schulz@free-electrons.com> wrote: >> The CHR_CTRL1 register is made of 7 read-write bits with one being used >> to set the target voltage for battery charging. > > The description is incorrect. > > All 8 bits are read-write: > > - The highest bit enables the charger module > - Bits [6:5] set the target voltage > - Bits [4:3] set when the charge cycle ends, based on percentage > of charge current > - Bits [2:0] set the charge current > > Feel free to use the above in the commit message. > Thanks for the correction. >> >> This adds the CHRG_CTRL1 register to the list of writeable registers for >> AXP20X and AXP22X PMICs. > > You might want to add up to CHRG_CTRL3 for the AXP22x and CHRG_CTRL2 > for the AXP20x. These control additional aspects of the charger. > ACK. > AXP20X_CHRG_BAK_CTRL controls the charger for the RTC battery. You > could add this now, or let the person doing the RTC battery driver > add it. I'll let the person adding the RTC battery driver add it. Thanks, Quentin
diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c index 65c57d0..19bdba3 100644 --- a/drivers/mfd/axp20x.c +++ b/drivers/mfd/axp20x.c @@ -66,6 +66,7 @@ static const struct regmap_access_table axp152_volatile_table = { static const struct regmap_range axp20x_writeable_ranges[] = { regmap_reg_range(AXP20X_DATACACHE(0), AXP20X_IRQ5_STATE), regmap_reg_range(AXP20X_VBUS_IPSOUT_MGMT, AXP20X_VBUS_IPSOUT_MGMT), + regmap_reg_range(AXP20X_CHRG_CTRL1, AXP20X_CHRG_CTRL1), regmap_reg_range(AXP20X_DCDC_MODE, AXP20X_FG_RES), regmap_reg_range(AXP20X_RDC_H, AXP20X_OCV(AXP20X_OCV_MAX)), }; @@ -94,6 +95,7 @@ static const struct regmap_access_table axp20x_volatile_table = { static const struct regmap_range axp22x_writeable_ranges[] = { regmap_reg_range(AXP20X_DATACACHE(0), AXP20X_IRQ5_STATE), regmap_reg_range(AXP20X_VBUS_IPSOUT_MGMT, AXP20X_VBUS_IPSOUT_MGMT), + regmap_reg_range(AXP20X_CHRG_CTRL1, AXP20X_CHRG_CTRL1), regmap_reg_range(AXP20X_DCDC_MODE, AXP22X_BATLOW_THRES1), };
The CHR_CTRL1 register is made of 7 read-write bits with one being used to set the target voltage for battery charging. This adds the CHRG_CTRL1 register to the list of writeable registers for AXP20X and AXP22X PMICs. Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com> --- drivers/mfd/axp20x.c | 2 ++ 1 file changed, 2 insertions(+)