diff mbox

ARM: dts: sunxi: Enable spi1 and spi2 for Olimex A20 SOM EVB

Message ID 20161226175349.17712-1-manu@bidouilliste.com (mailing list archive)
State New, archived
Headers show

Commit Message

Emmanuel Vadot Dec. 26, 2016, 5:53 p.m. UTC
Enable the spi1 and spi2 node since the pins are exposed on the UEXT
connectors.

Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com>
---
 arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts | 2 ++
 1 file changed, 2 insertions(+)

Comments

Maxime Ripard Jan. 5, 2017, 5:16 p.m. UTC | #1
Hi,

On Mon, Dec 26, 2016 at 06:53:49PM +0100, Emmanuel Vadot wrote:
> Enable the spi1 and spi2 node since the pins are exposed on the UEXT
> connectors.
> 
> Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com>
> ---
>  arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts b/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
> index 669a1c338c76..fa8c6f60552b 100644
> --- a/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
> @@ -300,12 +300,14 @@
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&spi1_pins_a>,
>  		    <&spi1_cs0_pins_a>;
> +	status = "okay";
>  };
>  
>  &spi2 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&spi2_pins_a>,
>  		    <&spi2_cs0_pins_a>;
> +	status = "okay";
>  };

Those nodes don't exist unfortunately. Maybe you forgot to send one
patch?

Thanks!
Maxime
Emmanuel Vadot Jan. 5, 2017, 5:37 p.m. UTC | #2
Hi,

On Thu, 5 Jan 2017 18:16:01 +0100
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:

> Hi,
> 
> On Mon, Dec 26, 2016 at 06:53:49PM +0100, Emmanuel Vadot wrote:
> > Enable the spi1 and spi2 node since the pins are exposed on the UEXT
> > connectors.
> > 
> > Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com>
> > ---
> >  arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts b/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
> > index 669a1c338c76..fa8c6f60552b 100644
> > --- a/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
> > +++ b/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
> > @@ -300,12 +300,14 @@
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&spi1_pins_a>,
> >  		    <&spi1_cs0_pins_a>;
> > +	status = "okay";
> >  };
> >  
> >  &spi2 {
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&spi2_pins_a>,
> >  		    <&spi2_cs0_pins_a>;
> > +	status = "okay";
> >  };
> 
> Those nodes don't exist unfortunately. Maybe you forgot to send one
> patch?
> 
> Thanks!
> Maxime
> 
> -- 
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

 It's based on a previous sent patch :
http://lists.infradead.org/pipermail/linux-arm-kernel/2016-November/469288.html

 You said you'll squash the two commits.
Maxime Ripard Jan. 5, 2017, 6:01 p.m. UTC | #3
On Thu, Jan 05, 2017 at 06:37:34PM +0100, Emmanuel Vadot wrote:
> 
>  Hi,
> 
> On Thu, 5 Jan 2017 18:16:01 +0100
> Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
> 
> > Hi,
> > 
> > On Mon, Dec 26, 2016 at 06:53:49PM +0100, Emmanuel Vadot wrote:
> > > Enable the spi1 and spi2 node since the pins are exposed on the UEXT
> > > connectors.
> > > 
> > > Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com>
> > > ---
> > >  arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts b/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
> > > index 669a1c338c76..fa8c6f60552b 100644
> > > --- a/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
> > > +++ b/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
> > > @@ -300,12 +300,14 @@
> > >  	pinctrl-names = "default";
> > >  	pinctrl-0 = <&spi1_pins_a>,
> > >  		    <&spi1_cs0_pins_a>;
> > > +	status = "okay";
> > >  };
> > >  
> > >  &spi2 {
> > >  	pinctrl-names = "default";
> > >  	pinctrl-0 = <&spi2_pins_a>,
> > >  		    <&spi2_cs0_pins_a>;
> > > +	status = "okay";
> > >  };
> > 
> > Those nodes don't exist unfortunately. Maybe you forgot to send one
> > patch?
> > 
> > Thanks!
> > Maxime
> > 
> > -- 
> > Maxime Ripard, Free Electrons
> > Embedded Linux and Kernel engineering
> > http://free-electrons.com
> 
>  It's based on a previous sent patch :
> http://lists.infradead.org/pipermail/linux-arm-kernel/2016-November/469288.html
> 
>  You said you'll squash the two commits.

Hmmm, indeed, I might have made a mistake on this one and ended up
dropping it... :/

I reapplied both and squashed them together, thanks (and sorry again)!

Maxime
Emmanuel Vadot Jan. 5, 2017, 6:04 p.m. UTC | #4
On Thu, 5 Jan 2017 19:01:51 +0100
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:

> On Thu, Jan 05, 2017 at 06:37:34PM +0100, Emmanuel Vadot wrote:
> > 
> >  Hi,
> > 
> > On Thu, 5 Jan 2017 18:16:01 +0100
> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
> > 
> > > Hi,
> > > 
> > > On Mon, Dec 26, 2016 at 06:53:49PM +0100, Emmanuel Vadot wrote:
> > > > Enable the spi1 and spi2 node since the pins are exposed on the UEXT
> > > > connectors.
> > > > 
> > > > Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com>
> > > > ---
> > > >  arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git a/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts b/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
> > > > index 669a1c338c76..fa8c6f60552b 100644
> > > > --- a/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
> > > > +++ b/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
> > > > @@ -300,12 +300,14 @@
> > > >  	pinctrl-names = "default";
> > > >  	pinctrl-0 = <&spi1_pins_a>,
> > > >  		    <&spi1_cs0_pins_a>;
> > > > +	status = "okay";
> > > >  };
> > > >  
> > > >  &spi2 {
> > > >  	pinctrl-names = "default";
> > > >  	pinctrl-0 = <&spi2_pins_a>,
> > > >  		    <&spi2_cs0_pins_a>;
> > > > +	status = "okay";
> > > >  };
> > > 
> > > Those nodes don't exist unfortunately. Maybe you forgot to send one
> > > patch?
> > > 
> > > Thanks!
> > > Maxime
> > > 
> > > -- 
> > > Maxime Ripard, Free Electrons
> > > Embedded Linux and Kernel engineering
> > > http://free-electrons.com
> > 
> >  It's based on a previous sent patch :
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2016-November/469288.html
> > 
> >  You said you'll squash the two commits.
> 
> Hmmm, indeed, I might have made a mistake on this one and ended up
> dropping it... :/
> 
> I reapplied both and squashed them together, thanks (and sorry again)!
> 
> Maxime
> 
> -- 
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

 No problem, thank you!
diff mbox

Patch

diff --git a/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts b/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
index 669a1c338c76..fa8c6f60552b 100644
--- a/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
+++ b/arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts
@@ -300,12 +300,14 @@ 
 	pinctrl-names = "default";
 	pinctrl-0 = <&spi1_pins_a>,
 		    <&spi1_cs0_pins_a>;
+	status = "okay";
 };
 
 &spi2 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&spi2_pins_a>,
 		    <&spi2_cs0_pins_a>;
+	status = "okay";
 };
 
 &uart0 {