| Message ID | 1483486889-3662-1-git-send-email-spjoshi@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 01/03/2017 05:41 PM, Sarangdhar Joshi wrote: > The function wkup_m3_rproc_boot_thread waits for > asynchronous firmware loading to parse the resource table > before calling rproc_boot(). However, as the resource table > parsing has been moved to rproc_boot(), there's no need to > wait for the asynchronous firmware loading completion. > So, drop this. > > CC: Dave Gerlach <d-gerlach@ti.com> > CC: Suman Anna <s-anna@ti.com> > CC: Bjorn Andersson <bjorn.andersson@linaro.org> > Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org> + Tony and Santosh, not sure who is picking up the wkup_m3 related patches. Only one minor nit, I would prefer the patch subject to start with soc: ti: wkup_m3_ipc: .... Tested-by: Suman Anna <s-anna@ti.com> regards Suman > --- > > This patch seems to be doing an independent clean up now. Hence > removing it from the series. > > drivers/soc/ti/wkup_m3_ipc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c > index 8823cc8..8bfa44b 100644 > --- a/drivers/soc/ti/wkup_m3_ipc.c > +++ b/drivers/soc/ti/wkup_m3_ipc.c > @@ -370,8 +370,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc) > struct device *dev = m3_ipc->dev; > int ret; > > - wait_for_completion(&m3_ipc->rproc->firmware_loading_complete); > - > init_completion(&m3_ipc->sync_complete); > > ret = rproc_boot(m3_ipc->rproc); >
On 1/5/2017 1:08 PM, Suman Anna wrote: > On 01/03/2017 05:41 PM, Sarangdhar Joshi wrote: >> The function wkup_m3_rproc_boot_thread waits for >> asynchronous firmware loading to parse the resource table >> before calling rproc_boot(). However, as the resource table >> parsing has been moved to rproc_boot(), there's no need to >> wait for the asynchronous firmware loading completion. >> So, drop this. >> >> CC: Dave Gerlach <d-gerlach@ti.com> >> CC: Suman Anna <s-anna@ti.com> >> CC: Bjorn Andersson <bjorn.andersson@linaro.org> >> Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org> > > + Tony and Santosh, not sure who is picking up the wkup_m3 related patches. > I think Tony has queued patches for wakeup_m3 before. Regards, Snatosh
On 01/05/2017 01:08 PM, Suman Anna wrote: > On 01/03/2017 05:41 PM, Sarangdhar Joshi wrote: >> The function wkup_m3_rproc_boot_thread waits for >> asynchronous firmware loading to parse the resource table >> before calling rproc_boot(). However, as the resource table >> parsing has been moved to rproc_boot(), there's no need to >> wait for the asynchronous firmware loading completion. >> So, drop this. >> >> CC: Dave Gerlach <d-gerlach@ti.com> >> CC: Suman Anna <s-anna@ti.com> >> CC: Bjorn Andersson <bjorn.andersson@linaro.org> >> Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org> > > + Tony and Santosh, not sure who is picking up the wkup_m3 related patches. > > Only one minor nit, I would prefer the patch subject to start with > soc: ti: wkup_m3_ipc: .... Sure, will update the subject line. Regards, Sarang > > Tested-by: Suman Anna <s-anna@ti.com> > > regards > Suman > >> --- >> >> This patch seems to be doing an independent clean up now. Hence >> removing it from the series. >> >> drivers/soc/ti/wkup_m3_ipc.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c >> index 8823cc8..8bfa44b 100644 >> --- a/drivers/soc/ti/wkup_m3_ipc.c >> +++ b/drivers/soc/ti/wkup_m3_ipc.c >> @@ -370,8 +370,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc) >> struct device *dev = m3_ipc->dev; >> int ret; >> >> - wait_for_completion(&m3_ipc->rproc->firmware_loading_complete); >> - >> init_completion(&m3_ipc->sync_complete); >> >> ret = rproc_boot(m3_ipc->rproc); >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
* Santosh Shilimkar <santosh.shilimkar@oracle.com> [170105 13:18]: > > > On 1/5/2017 1:08 PM, Suman Anna wrote: > > On 01/03/2017 05:41 PM, Sarangdhar Joshi wrote: > > > The function wkup_m3_rproc_boot_thread waits for > > > asynchronous firmware loading to parse the resource table > > > before calling rproc_boot(). However, as the resource table > > > parsing has been moved to rproc_boot(), there's no need to > > > wait for the asynchronous firmware loading completion. > > > So, drop this. > > > > > > CC: Dave Gerlach <d-gerlach@ti.com> > > > CC: Suman Anna <s-anna@ti.com> > > > CC: Bjorn Andersson <bjorn.andersson@linaro.org> > > > Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org> > > > > + Tony and Santosh, not sure who is picking up the wkup_m3 related patches. > > > I think Tony has queued patches for wakeup_m3 before. Sure I can queue it. Thanks, Tony
diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c index 8823cc8..8bfa44b 100644 --- a/drivers/soc/ti/wkup_m3_ipc.c +++ b/drivers/soc/ti/wkup_m3_ipc.c @@ -370,8 +370,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc) struct device *dev = m3_ipc->dev; int ret; - wait_for_completion(&m3_ipc->rproc->firmware_loading_complete); - init_completion(&m3_ipc->sync_complete); ret = rproc_boot(m3_ipc->rproc);
The function wkup_m3_rproc_boot_thread waits for asynchronous firmware loading to parse the resource table before calling rproc_boot(). However, as the resource table parsing has been moved to rproc_boot(), there's no need to wait for the asynchronous firmware loading completion. So, drop this. CC: Dave Gerlach <d-gerlach@ti.com> CC: Suman Anna <s-anna@ti.com> CC: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org> --- This patch seems to be doing an independent clean up now. Hence removing it from the series. drivers/soc/ti/wkup_m3_ipc.c | 2 -- 1 file changed, 2 deletions(-)