| Message ID | 20161230041421.24448-3-andi.shyti@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Andi, On 2016년 12월 30일 13:14, Andi Shyti wrote: > Commit 5db7e3bb87df ("pinctrl: dt-bindings: samsung: Add header with > values used for configuration") has added a header file for defining the > pinctrl values in order to avoid hardcoded settings in the Exynos > DTS related files. > > Extend samsung.h to the Exynos5433 for drive strength values > which are strictly related to the particular SoC and may defer > from others. > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > --- > include/dt-bindings/pinctrl/samsung.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/include/dt-bindings/pinctrl/samsung.h b/include/dt-bindings/pinctrl/samsung.h > index 6276eb785e2b..e0ebb20ffdd3 100644 > --- a/include/dt-bindings/pinctrl/samsung.h > +++ b/include/dt-bindings/pinctrl/samsung.h > @@ -45,6 +45,20 @@ > #define EXYNOS5420_PIN_DRV_LV3 2 > #define EXYNOS5420_PIN_DRV_LV4 3 > > +/* Drive strengths for Exynos5433 */ > +#define EXYNOS5433_PIN_DRV_FAST_SR1 0 > +#define EXYNOS5433_PIN_DRV_FAST_SR2 1 > +#define EXYNOS5433_PIN_DRV_FAST_SR3 2 > +#define EXYNOS5433_PIN_DRV_FAST_SR4 3 > +#define EXYNOS5433_PIN_DRV_FAST_SR5 4 > +#define EXYNOS5433_PIN_DRV_FAST_SR6 5 > +#define EXYNOS5433_PIN_DRV_SLOW_SR1 8 > +#define EXYNOS5433_PIN_DRV_SLOW_SR2 9 > +#define EXYNOS5433_PIN_DRV_SLOW_SR3 0xa > +#define EXYNOS5433_PIN_DRV_SLOW_SR4 0xb > +#define EXYNOS5433_PIN_DRV_SLOW_SR5 0xc > +#define EXYNOS5433_PIN_DRV_SLOW_SR6 0xf > + > #define EXYNOS_PIN_FUNC_INPUT 0 > #define EXYNOS_PIN_FUNC_OUTPUT 1 > #define EXYNOS_PIN_FUNC_2 2 > Looks good to me. ('SR' means "Slew Rate".) Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
On Fri, Dec 30, 2016 at 5:14 AM, Andi Shyti <andi.shyti@samsung.com> wrote: > Commit 5db7e3bb87df ("pinctrl: dt-bindings: samsung: Add header with > values used for configuration") has added a header file for defining the > pinctrl values in order to avoid hardcoded settings in the Exynos > DTS related files. > > Extend samsung.h to the Exynos5433 for drive strength values > which are strictly related to the particular SoC and may defer > from others. > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> Patch applied with Chanwoo's review tag. Yours, Linus Walleij
On Fri, Dec 30, 2016 at 02:30:47PM +0100, Linus Walleij wrote: > On Fri, Dec 30, 2016 at 5:14 AM, Andi Shyti <andi.shyti@samsung.com> wrote: > > > Commit 5db7e3bb87df ("pinctrl: dt-bindings: samsung: Add header with > > values used for configuration") has added a header file for defining the > > pinctrl values in order to avoid hardcoded settings in the Exynos > > DTS related files. > > > > Extend samsung.h to the Exynos5433 for drive strength values > > which are strictly related to the particular SoC and may defer > > from others. > > > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > > Patch applied with Chanwoo's review tag. As agreed, applied with your ack to samsung-soc. I put it on separate branch so I can provide a tag if needed. Best regards, Krzysztof
diff --git a/include/dt-bindings/pinctrl/samsung.h b/include/dt-bindings/pinctrl/samsung.h index 6276eb785e2b..e0ebb20ffdd3 100644 --- a/include/dt-bindings/pinctrl/samsung.h +++ b/include/dt-bindings/pinctrl/samsung.h @@ -45,6 +45,20 @@ #define EXYNOS5420_PIN_DRV_LV3 2 #define EXYNOS5420_PIN_DRV_LV4 3 +/* Drive strengths for Exynos5433 */ +#define EXYNOS5433_PIN_DRV_FAST_SR1 0 +#define EXYNOS5433_PIN_DRV_FAST_SR2 1 +#define EXYNOS5433_PIN_DRV_FAST_SR3 2 +#define EXYNOS5433_PIN_DRV_FAST_SR4 3 +#define EXYNOS5433_PIN_DRV_FAST_SR5 4 +#define EXYNOS5433_PIN_DRV_FAST_SR6 5 +#define EXYNOS5433_PIN_DRV_SLOW_SR1 8 +#define EXYNOS5433_PIN_DRV_SLOW_SR2 9 +#define EXYNOS5433_PIN_DRV_SLOW_SR3 0xa +#define EXYNOS5433_PIN_DRV_SLOW_SR4 0xb +#define EXYNOS5433_PIN_DRV_SLOW_SR5 0xc +#define EXYNOS5433_PIN_DRV_SLOW_SR6 0xf + #define EXYNOS_PIN_FUNC_INPUT 0 #define EXYNOS_PIN_FUNC_OUTPUT 1 #define EXYNOS_PIN_FUNC_2 2
Commit 5db7e3bb87df ("pinctrl: dt-bindings: samsung: Add header with values used for configuration") has added a header file for defining the pinctrl values in order to avoid hardcoded settings in the Exynos DTS related files. Extend samsung.h to the Exynos5433 for drive strength values which are strictly related to the particular SoC and may defer from others. Signed-off-by: Andi Shyti <andi.shyti@samsung.com> --- include/dt-bindings/pinctrl/samsung.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+)