| Message ID | 20170106114114.19321-2-andi.shyti@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jan 06, 2017 at 08:41:10PM +0900, Andi Shyti wrote: > From: Chanwoo Choi <cw00.choi@samsung.com> > > This patch fixes wrong values assigned to ldo23 and ldo25 on both TM2 and TM2E. > > Fixes: 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board") > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 7 ++++--- > arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 9 --------- > 2 files changed, 4 insertions(+), 12 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > index 3b5215c40fcd..e8971f4a5977 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > @@ -504,9 +504,9 @@ > }; > > ldo23_reg: LDO23 { > - regulator-name = "CAM_SEN_CORE_1.2V_AP"; > + regulator-name = "CAM_SEN_CORE_1.05V_AP"; > regulator-min-microvolt = <1050000>; > - regulator-max-microvolt = <1200000>; > + regulator-max-microvolt = <1050000>; > }; > > ldo24_reg: LDO24 { > @@ -516,9 +516,10 @@ > }; > > ldo25_reg: LDO25 { > - regulator-name = "CAM_SEN_A2.8V_AP"; > + regulator-name = "UNUSED_LDO25"; > regulator-min-microvolt = <2800000>; > regulator-max-microvolt = <2800000>; > + regulator-always-off; No. I mentioned in last email that this property is wrong. When resubmitting, please fix the subject prefix. Best regards, Krzysztof
Hello Andi, On 01/06/2017 08:41 AM, Andi Shyti wrote: > From: Chanwoo Choi <cw00.choi@samsung.com> > > This patch fixes wrong values assigned to ldo23 and ldo25 on both TM2 and TM2E. > > Fixes: 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board") > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > --- I don't have the schematics to check, but the patch looks good to me besides the "regulator-always-off" property as Krzysztof mentioned. Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts index 3b5215c40fcd..e8971f4a5977 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts @@ -504,9 +504,9 @@ }; ldo23_reg: LDO23 { - regulator-name = "CAM_SEN_CORE_1.2V_AP"; + regulator-name = "CAM_SEN_CORE_1.05V_AP"; regulator-min-microvolt = <1050000>; - regulator-max-microvolt = <1200000>; + regulator-max-microvolt = <1050000>; }; ldo24_reg: LDO24 { @@ -516,9 +516,10 @@ }; ldo25_reg: LDO25 { - regulator-name = "CAM_SEN_A2.8V_AP"; + regulator-name = "UNUSED_LDO25"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; + regulator-always-off; }; ldo26_reg: LDO26 { diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts index 398f5e092b02..854c583092d5 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts @@ -18,15 +18,6 @@ compatible = "samsung,tm2e", "samsung,exynos5433"; }; -&ldo23_reg { - regulator-name = "CAM_SEN_CORE_1.025V_AP"; - regulator-max-microvolt = <1050000>; -}; - -&ldo25_reg { - regulator-name = "UNUSED_LDO25"; -}; - &ldo31_reg { regulator-name = "TSP_VDD_1.8V_AP"; regulator-min-microvolt = <1800000>;