| Message ID | 20161229191313.21577-1-zajec5@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e360e72e715f228e426edf0fc99ffa34027ab0ad |
| Headers | show |
On Thu, Dec 29, 2016 at 08:13:13PM +0100, Rafa?? Mi??ecki wrote: > From: Rafa?? Mi??ecki <rafal@milecki.pl> > > My intention was to release this code under GPL v2 license. For some > reason my initial commit 0fc6a323e191 ("spi: bcm53xx: driver for SPI > controller on Broadcom bcma SoC") totally missed licensing info. > MODULE_LICENSE was later added by Axel specifying "GNU Public License > v2 or later". > > This patch clarifies situation by adding a proper header (with Copyright > line) and adjusting MODULE_LICENSE. It should be acked by every driver > contributor. > > Signed-off-by: Rafa?? Mi??ecki <rafal@milecki.pl> > --- > Guys, can I have your Acked-by for this patch, please? > > Vaishali: you are author of commit 6774eea6d7a6 ("spi: bcm53xx: Adjust > devm usage") > > Joe: you are author of commit f7219b527b57 ("treewide: Remove > unnecessary BCMA_CORETABLE_END macro") > > Nicholas: you are author of commit b3e7766bc459 ("spi: bcm53xx: use > msecs_to_jiffies for conversion") > > Axel: you are author of commit 61d38b9a823c ("spi: bcm53xx: Add missing > module information") > > Jingoo: you are author of commit 050429a78b2d ("spi: bcm53xx: make local > symbol static") Acked-by: Nicholas Mc Guire <hofrat@osadl.org> > --- > drivers/spi/spi-bcm53xx.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-bcm53xx.c b/drivers/spi/spi-bcm53xx.c > index 0c61ad4..6e409ea 100644 > --- a/drivers/spi/spi-bcm53xx.c > +++ b/drivers/spi/spi-bcm53xx.c > @@ -1,3 +1,11 @@ > +/* > + * Copyright (C) 2014-2016 Rafa?? Mi??ecki <rafal@milecki.pl> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > #include <linux/kernel.h> > @@ -355,4 +363,4 @@ module_exit(bcm53xxspi_module_exit); > > MODULE_DESCRIPTION("Broadcom BCM53xx SPI Controller driver"); > MODULE_AUTHOR("Rafa?? Mi??ecki <zajec5@gmail.com>"); > -MODULE_LICENSE("GPL"); > +MODULE_LICENSE("GPL v2"); > -- > 2.10.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Sending using Jingoo's new address. Jingoo: can I have your Acked-by as requested below, please? On 12/29/2016 08:13 PM, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > My intention was to release this code under GPL v2 license. For some > reason my initial commit 0fc6a323e191 ("spi: bcm53xx: driver for SPI > controller on Broadcom bcma SoC") totally missed licensing info. > MODULE_LICENSE was later added by Axel specifying "GNU Public License > v2 or later". > > This patch clarifies situation by adding a proper header (with Copyright > line) and adjusting MODULE_LICENSE. It should be acked by every driver > contributor. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > Guys, can I have your Acked-by for this patch, please? > > Vaishali: you are author of commit 6774eea6d7a6 ("spi: bcm53xx: Adjust > devm usage") > > Joe: you are author of commit f7219b527b57 ("treewide: Remove > unnecessary BCMA_CORETABLE_END macro") > > Nicholas: you are author of commit b3e7766bc459 ("spi: bcm53xx: use > msecs_to_jiffies for conversion") > > Axel: you are author of commit 61d38b9a823c ("spi: bcm53xx: Add missing > module information") > > Jingoo: you are author of commit 050429a78b2d ("spi: bcm53xx: make local > symbol static") > --- > drivers/spi/spi-bcm53xx.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-bcm53xx.c b/drivers/spi/spi-bcm53xx.c > index 0c61ad4..6e409ea 100644 > --- a/drivers/spi/spi-bcm53xx.c > +++ b/drivers/spi/spi-bcm53xx.c > @@ -1,3 +1,11 @@ > +/* > + * Copyright (C) 2014-2016 Rafał Miłecki <rafal@milecki.pl> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > #include <linux/kernel.h> > @@ -355,4 +363,4 @@ module_exit(bcm53xxspi_module_exit); > > MODULE_DESCRIPTION("Broadcom BCM53xx SPI Controller driver"); > MODULE_AUTHOR("Rafał Miłecki <zajec5@gmail.com>"); > -MODULE_LICENSE("GPL"); > +MODULE_LICENSE("GPL v2"); > -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2016-12-29 at 20:13 +0100, Rafał Miłecki wrote: > My intention was to release this code under GPL v2 license. [] > Joe: you are author of commit f7219b527b57 ("treewide: Remove > unnecessary BCMA_CORETABLE_END macro") Acked-by: Joe Perches <joe@perches.com> -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2016-12-30 3:13 GMT+08:00 Rafał Miłecki <zajec5@gmail.com>: > From: Rafał Miłecki <rafal@milecki.pl> > > My intention was to release this code under GPL v2 license. For some > reason my initial commit 0fc6a323e191 ("spi: bcm53xx: driver for SPI > controller on Broadcom bcma SoC") totally missed licensing info. > MODULE_LICENSE was later added by Axel specifying "GNU Public License > v2 or later". > > This patch clarifies situation by adding a proper header (with Copyright > line) and adjusting MODULE_LICENSE. It should be acked by every driver > contributor. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > Guys, can I have your Acked-by for this patch, please? > > Vaishali: you are author of commit 6774eea6d7a6 ("spi: bcm53xx: Adjust > devm usage") > > Joe: you are author of commit f7219b527b57 ("treewide: Remove > unnecessary BCMA_CORETABLE_END macro") > > Nicholas: you are author of commit b3e7766bc459 ("spi: bcm53xx: use > msecs_to_jiffies for conversion") > > Axel: you are author of commit 61d38b9a823c ("spi: bcm53xx: Add missing > module information") Acked-by: Axel Lin <axel.lin@ingics.com> -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 30, 2016 at 12:43 AM, Rafał Miłecki <zajec5@gmail.com> wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > My intention was to release this code under GPL v2 license. For some > reason my initial commit 0fc6a323e191 ("spi: bcm53xx: driver for SPI > controller on Broadcom bcma SoC") totally missed licensing info. > MODULE_LICENSE was later added by Axel specifying "GNU Public License > v2 or later". > > This patch clarifies situation by adding a proper header (with Copyright > line) and adjusting MODULE_LICENSE. It should be acked by every driver > contributor. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > Guys, can I have your Acked-by for this patch, please? I am no longer using this mail address for the kernel contribution, so adding acked by with the new mail address. Thanks. > Vaishali: you are author of commit 6774eea6d7a6 ("spi: bcm53xx: Adjust > devm usage") Acked-by: Vaishali Thakkar <vaishali.thakkar@oracle.com> > Joe: you are author of commit f7219b527b57 ("treewide: Remove > unnecessary BCMA_CORETABLE_END macro") > > Nicholas: you are author of commit b3e7766bc459 ("spi: bcm53xx: use > msecs_to_jiffies for conversion") > > Axel: you are author of commit 61d38b9a823c ("spi: bcm53xx: Add missing > module information") > > Jingoo: you are author of commit 050429a78b2d ("spi: bcm53xx: make local > symbol static") > --- > drivers/spi/spi-bcm53xx.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-bcm53xx.c b/drivers/spi/spi-bcm53xx.c > index 0c61ad4..6e409ea 100644 > --- a/drivers/spi/spi-bcm53xx.c > +++ b/drivers/spi/spi-bcm53xx.c > @@ -1,3 +1,11 @@ > +/* > + * Copyright (C) 2014-2016 Rafał Miłecki <rafal@milecki.pl> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > #include <linux/kernel.h> > @@ -355,4 +363,4 @@ module_exit(bcm53xxspi_module_exit); > > MODULE_DESCRIPTION("Broadcom BCM53xx SPI Controller driver"); > MODULE_AUTHOR("Rafał Miłecki <zajec5@gmail.com>"); > -MODULE_LICENSE("GPL"); > +MODULE_LICENSE("GPL v2"); > -- > 2.10.1 >
On 30 December 2016 at 05:30, Han Jingoo <jingoohan1@gmail.com> wrote: > Thank you for sending me the patch. > Your patch looks good. > > But, I am not a maintainer for this bcm53xx SPI driver. > So, I think that my reviewed-by is enough, instead of my acked-by. > However, you can select either one. > > Reviewed-by: Jingoo Han <jingoohan1@gmail.com> > or > Acked-by: Jingoo Han <jingoohan1@gmail.com> According to the Documentation/development-process/5.Posting.rst this "Acked-by" is *often* used by maintainers, but it isn't a requirement. It also "indicates an agreement" which should be clear enough for (re)licensing code. So I think it's justified to use "Acked-by" in this case. I can also see similar usage of it in "git log" of kernel source so I hope it's really OK :) -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 29 December 2016 at 20:13, Rafał Miłecki <zajec5@gmail.com> wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > My intention was to release this code under GPL v2 license. For some > reason my initial commit 0fc6a323e191 ("spi: bcm53xx: driver for SPI > controller on Broadcom bcma SoC") totally missed licensing info. > MODULE_LICENSE was later added by Axel specifying "GNU Public License > v2 or later". > > This patch clarifies situation by adding a proper header (with Copyright > line) and adjusting MODULE_LICENSE. It should be acked by every driver > contributor. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> Hi Mark, For some reason patchwork missed Han's reply: https://patchwork.kernel.org/patch/9491361/ but all other ones are there. Could you get patch as mbox from patchwork: https://patchwork.kernel.org/patch/9491361/mbox/ and add Han's "Acked-by" manually? This would give you a patch acked by every contributor which should be enough to push is safely/legally. -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 30, 2016 at 09:08:30AM +0100, Rafał Miłecki wrote: > On 29 December 2016 at 20:13, Rafał Miłecki <zajec5@gmail.com> wrote: > Could you get patch as mbox from patchwork: > https://patchwork.kernel.org/patch/9491361/mbox/ > and add Han's "Acked-by" manually? > This would give you a patch acked by every contributor which should be > enough to push is safely/legally. Please allow a reasonable period for a reply before sending pings, unless things are *extremely* urgent 24 hours isn't particularly reasonable. I do review from e-mail not from patchwork (I'm pretty sure it's a vanishingly small minority of people who do review from patchwork alone) but it was Christmas.
On 6 January 2017 at 19:21, Mark Brown <broonie@kernel.org> wrote: > On Fri, Dec 30, 2016 at 09:08:30AM +0100, Rafał Miłecki wrote: >> On 29 December 2016 at 20:13, Rafał Miłecki <zajec5@gmail.com> wrote: > >> Could you get patch as mbox from patchwork: >> https://patchwork.kernel.org/patch/9491361/mbox/ >> and add Han's "Acked-by" manually? > >> This would give you a patch acked by every contributor which should be >> enough to push is safely/legally. > > Please allow a reasonable period for a reply before sending pings, > unless things are *extremely* urgent 24 hours isn't particularly > reasonable. I do review from e-mail not from patchwork (I'm pretty sure > it's a vanishingly small minority of people who do review from patchwork > alone) but it was Christmas. I never meant to rush you, I was just trying to be helpful. I wanted to just let you know all ppl I asked sent their Acks & I wanted to give you a notice on possible problem with patchwork & Han's Ack. I didn't want to put effort of tracing Acks on you. Take your time, handle it whenever you have time for this, this isn't urgent :)
diff --git a/drivers/spi/spi-bcm53xx.c b/drivers/spi/spi-bcm53xx.c index 0c61ad4..6e409ea 100644 --- a/drivers/spi/spi-bcm53xx.c +++ b/drivers/spi/spi-bcm53xx.c @@ -1,3 +1,11 @@ +/* + * Copyright (C) 2014-2016 Rafał Miłecki <rafal@milecki.pl> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include <linux/kernel.h> @@ -355,4 +363,4 @@ module_exit(bcm53xxspi_module_exit); MODULE_DESCRIPTION("Broadcom BCM53xx SPI Controller driver"); MODULE_AUTHOR("Rafał Miłecki <zajec5@gmail.com>"); -MODULE_LICENSE("GPL"); +MODULE_LICENSE("GPL v2");