| Message ID | 1484069912-6534-4-git-send-email-javier@osg.samsung.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Tue, Jan 10, 2017 at 02:38:32PM -0300, Javier Martinez Canillas wrote: > The "samsung,exynos5433-mipi-video-phy" and "samsung,exynos5250-dwusb3" > DT bindings don't specify a reg property for these nodes, so having a > unit name leads to the following DTC warnings: > > Node /soc/video-phy@105c0710 has a unit name, but no reg property > Node /soc/usb@15400000 has a unit name, but no reg property > Node /soc/usb@15a00000 has a unit name, but no reg property > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > index 3695ddaf2e04..17e5dafd392c 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi > @@ -706,7 +706,7 @@ > interrupts = <GIC_PPI 9 0xf04>; > }; > > - mipi_phy: video-phy@105c0710 { > + mipi_phy: video-phy { > compatible = "samsung,exynos5433-mipi-video-phy"; > #phy-cells = <1>; > samsung,pmu-syscon = <&pmu_system_controller>; > @@ -1285,7 +1285,7 @@ > status = "disabled"; > }; > > - usbdrd30: usb@15400000 { > + usbdrd30: usb-0 { How about "usbdrd" instead of "usb-0"? It would be still quite a generic description of a class. > compatible = "samsung,exynos5250-dwusb3"; > clocks = <&cmu_fsys CLK_ACLK_USBDRD30>, > <&cmu_fsys CLK_SCLK_USBDRD30>; > @@ -1332,7 +1332,7 @@ > status = "disabled"; > }; > > - usbhost30: usb@15a00000 { > + usbhost30: usb-1 { usbhost? Best regards, Krzysztof > compatible = "samsung,exynos5250-dwusb3"; > clocks = <&cmu_fsys CLK_ACLK_USBHOST30>, > <&cmu_fsys CLK_SCLK_USBHOST30>; > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Krzysztof, On 01/10/2017 03:51 PM, Krzysztof Kozlowski wrote: [snip] >> >> - usbdrd30: usb@15400000 { >> + usbdrd30: usb-0 { > > How about "usbdrd" instead of "usb-0"? It would be still quite a generic > description of a class. > >> compatible = "samsung,exynos5250-dwusb3"; >> clocks = <&cmu_fsys CLK_ACLK_USBDRD30>, >> <&cmu_fsys CLK_SCLK_USBDRD30>; >> @@ -1332,7 +1332,7 @@ >> status = "disabled"; >> }; >> >> - usbhost30: usb@15a00000 { >> + usbhost30: usb-1 { > > usbhost? > Indeed, these sounds better so I'll change for them. Best regards,
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index 3695ddaf2e04..17e5dafd392c 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -706,7 +706,7 @@ interrupts = <GIC_PPI 9 0xf04>; }; - mipi_phy: video-phy@105c0710 { + mipi_phy: video-phy { compatible = "samsung,exynos5433-mipi-video-phy"; #phy-cells = <1>; samsung,pmu-syscon = <&pmu_system_controller>; @@ -1285,7 +1285,7 @@ status = "disabled"; }; - usbdrd30: usb@15400000 { + usbdrd30: usb-0 { compatible = "samsung,exynos5250-dwusb3"; clocks = <&cmu_fsys CLK_ACLK_USBDRD30>, <&cmu_fsys CLK_SCLK_USBDRD30>; @@ -1332,7 +1332,7 @@ status = "disabled"; }; - usbhost30: usb@15a00000 { + usbhost30: usb-1 { compatible = "samsung,exynos5250-dwusb3"; clocks = <&cmu_fsys CLK_ACLK_USBHOST30>, <&cmu_fsys CLK_SCLK_USBHOST30>;
The "samsung,exynos5433-mipi-video-phy" and "samsung,exynos5250-dwusb3" DT bindings don't specify a reg property for these nodes, so having a unit name leads to the following DTC warnings: Node /soc/video-phy@105c0710 has a unit name, but no reg property Node /soc/usb@15400000 has a unit name, but no reg property Node /soc/usb@15a00000 has a unit name, but no reg property Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)