| Message ID | 1484036664-15951-1-git-send-email-a.hajda@samsung.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Tue, Jan 10, 2017 at 09:24:22AM +0100, Andrzej Hajda wrote: > DECON_TV is 2nd display controller on Exynos5433, used in HDMI path > or 2nd DSI path. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > Tested-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> > --- > > Hi Krzysztof, > > These patches are based on latest patches separating tm2 and tm2e and > touchscreen patches. I hope this is good base. > Thanks all for quick response/review. > Thanks for fixing the issues. Also thank you for trying to fix the subject. However this is not a full fix. Please run: $ git log --oneline arch/arm64/boot/dts/exynos/ Why I am asking about this? I am trying to have it consistent so going through history would be easier. Of course we might discuss what prefix should be used. Some other platforms use "arm64: dts: architecture:", some use "arm64: dts: specific_chip_family:". For exynos we are trying to keep it just "exynos". Anyway regardless of the chosen prefix itself, after choosing some pattern, the consistency helps. When people keep sending patches with wrong title, then after every git-am I have to amend the commit and fix it. It is not difficult but annoying. Actually before I did not complain about it... but recently (this cycle) a lot of Samsung folks are sending wrong subjects. Weird. So just use the command and look at history. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 10, 2017 at 09:24:22AM +0100, Andrzej Hajda wrote: > DECON_TV is 2nd display controller on Exynos5433, used in HDMI path > or 2nd DSI path. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > Tested-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> > --- > > Hi Krzysztof, > > These patches are based on latest patches separating tm2 and tm2e and > touchscreen patches. I hope this is good base. > Thanks all for quick response/review. > > Regards > Andrzej > > v2: > - replaced magic numbers with macros, > - removed power domains, > - removed 0x prefixes from node names > > v3: > - order nodes by address > --- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 43 ++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > First, I applied your fix for unit addresses. Then I wanted to apply these... no, it does not apply. Okay, so maybe unit address confuses git-am (it is not that smart as cherry-pick etc) - let's try the other way. I applied these three patches, fixed that damned subject in each commit and I wanted to apply the fix for unit address. Nope. It won't apply. I do not know how you rebased your work. As of now, the fix is applied. Please fix the subject and rebase. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10.01.2017 18:11, Krzysztof Kozlowski wrote: > On Tue, Jan 10, 2017 at 09:24:22AM +0100, Andrzej Hajda wrote: >> DECON_TV is 2nd display controller on Exynos5433, used in HDMI path >> or 2nd DSI path. >> >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> >> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> >> Tested-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> >> --- >> >> Hi Krzysztof, >> >> These patches are based on latest patches separating tm2 and tm2e and >> touchscreen patches. I hope this is good base. >> Thanks all for quick response/review. >> > Thanks for fixing the issues. Also thank you for trying to fix the > subject. However this is not a full fix. Please run: > $ git log --oneline arch/arm64/boot/dts/exynos/ > > Why I am asking about this? I am trying to have it consistent so > going through history would be easier. Of course we might discuss what > prefix should be used. Some other platforms use "arm64: dts: > architecture:", some use "arm64: dts: specific_chip_family:". For exynos > we are trying to keep it just "exynos". Anyway regardless of the chosen > prefix itself, after choosing some pattern, the consistency helps. > > When people keep sending patches with wrong title, then after every > git-am I have to amend the commit and fix it. It is not difficult but > annoying. > > Actually before I did not complain about it... but recently (this cycle) > a lot of Samsung folks are sending wrong subjects. Weird. I agree that consistency is good, so next time maybe it would be better to just simply write which prefix to use, instead of advising to dig into samsung-soc for help :) > > So just use the command and look at history. Good point. Regards Andrzej -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10.01.2017 20:09, Krzysztof Kozlowski wrote: > On Tue, Jan 10, 2017 at 09:24:22AM +0100, Andrzej Hajda wrote: >> DECON_TV is 2nd display controller on Exynos5433, used in HDMI path >> or 2nd DSI path. >> >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> >> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> >> Tested-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> >> --- >> >> Hi Krzysztof, >> >> These patches are based on latest patches separating tm2 and tm2e and >> touchscreen patches. I hope this is good base. >> Thanks all for quick response/review. >> >> Regards >> Andrzej >> >> v2: >> - replaced magic numbers with macros, >> - removed power domains, >> - removed 0x prefixes from node names >> >> v3: >> - order nodes by address >> --- >> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 43 ++++++++++++++++++++++++++++++ >> 1 file changed, 43 insertions(+) >> > First, I applied your fix for unit addresses. Then I wanted to apply > these... no, it does not apply. > > Okay, so maybe unit address confuses git-am (it is not that smart as > cherry-pick etc) - let's try the other way. I applied these three > patches, fixed that damned subject in each commit and I wanted to apply > the fix for unit address. Nope. It won't apply. > > I do not know how you rebased your work. I have get your latest for-next branch 68cb4b38b94473afe4dff3adaf97bbc6a81b5b91. I have reverted "arm64: dts: exynos: Fix addresses in node names on Exynos5433". I have applied all my patches cleanly. Anyway I will send again my patches rebased on 68cb4b38b94473afe4dff3adaf97bbc6a81b5b91 with your prefix. Regards Andrzej -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index 68f764e..8865fae 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -751,6 +751,29 @@ }; }; + decon_tv: decon@13880000 { + compatible = "samsung,exynos5433-decon-tv"; + reg = <0x13880000 0x20b8>; + clocks = <&cmu_disp CLK_PCLK_DECON_TV>, + <&cmu_disp CLK_ACLK_DECON_TV>, + <&cmu_disp CLK_ACLK_SMMU_TV0X>, + <&cmu_disp CLK_ACLK_XIU_TV0X>, + <&cmu_disp CLK_PCLK_SMMU_TV0X>, + <&cmu_disp CLK_SCLK_DECON_TV_VCLK>, + <&cmu_disp CLK_SCLK_DECON_TV_ECLK>; + clock-names = "pclk", "aclk_decon", "aclk_smmu_decon0x", + "aclk_xiu_decon0x", "pclk_smmu_decon0x", + "sclk_decon_vclk", "sclk_decon_eclk"; + samsung,disp-sysreg = <&syscon_disp>; + interrupt-names = "fifo", "vsync", "lcd_sys"; + interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + iommus = <&sysmmu_tv0x>, <&sysmmu_tv1x>; + iommu-names = "m0", "m1"; + }; + dsi: dsi@13900000 { compatible = "samsung,exynos5433-mipi-dsi"; reg = <0x13900000 0xC0>; @@ -912,6 +935,26 @@ #iommu-cells = <0>; }; + sysmmu_tv0x: sysmmu@13a20000 { + compatible = "samsung,exynos-sysmmu"; + reg = <0x13a20000 0x1000>; + interrupts = <GIC_SPI 214 IRQ_TYPE_LEVEL_HIGH>; + clock-names = "pclk", "aclk"; + clocks = <&cmu_disp CLK_PCLK_SMMU_TV0X>, + <&cmu_disp CLK_ACLK_SMMU_TV0X>; + #iommu-cells = <0>; + }; + + sysmmu_tv1x: sysmmu@13a30000 { + compatible = "samsung,exynos-sysmmu"; + reg = <0x13a30000 0x1000>; + interrupts = <GIC_SPI 216 IRQ_TYPE_LEVEL_HIGH>; + clock-names = "pclk", "aclk"; + clocks = <&cmu_disp CLK_PCLK_SMMU_TV1X>, + <&cmu_disp CLK_ACLK_SMMU_TV1X>; + #iommu-cells = <0>; + }; + sysmmu_gscl0: sysmmu@0x13C80000 { compatible = "samsung,exynos-sysmmu"; reg = <0x13C80000 0x1000>;