diff mbox

[10/17] spi/ppc4xx: Adjust checks for null pointers in two functions

Message ID d9bd24b0-d4d5-233c-756d-71aaed63c5ef@users.sourceforge.net (mailing list archive)
State Rejected
Headers show

Commit Message

SF Markus Elfring Jan. 13, 2017, 5:19 p.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 13 Jan 2017 14:56:10 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The script "checkpatch.pl" pointed information out like the following.

Comparison to NULL could be written !…

Thus fix the affected source code places.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/spi/spi-ppc4xx.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Mark Brown Jan. 17, 2017, 6:34 p.m. UTC | #1 
On Fri, Jan 13, 2017 at 06:19:35PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 13 Jan 2017 14:56:10 +0100
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit

This is also corrupted.
SF Markus Elfring Jan. 17, 2017, 6:48 p.m. UTC | #2 
>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Fri, 13 Jan 2017 14:56:10 +0100
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
> 
> This is also corrupted.

Would you like to explain this information a bit more?


The published patch looks reasonable in principle by other interfaces,
doesn't it?
https://lkml.org/lkml/2017/1/13/609
https://patchwork.kernel.org/patch/9516059/
https://lkml.kernel.org/r/<d9bd24b0-d4d5-233c-756d-71aaed63c5ef@users.sourceforge.net>

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown Jan. 17, 2017, 7:11 p.m. UTC | #3 
On Tue, Jan 17, 2017 at 07:48:26PM +0100, SF Markus Elfring wrote:
> >> From: Markus Elfring <elfring@users.sourceforge.net>
> >> Date: Fri, 13 Jan 2017 14:56:10 +0100
> >> MIME-Version: 1.0
> >> Content-Type: text/plain; charset=UTF-8
> >> Content-Transfer-Encoding: 8bit

> > This is also corrupted.

> Would you like to explain this information a bit more?

You've got MIME headers in the middle of the patch description.
SF Markus Elfring Jan. 17, 2017, 7:28 p.m. UTC | #4 
> You've got MIME headers in the middle of the patch description.

The extra header fields were automatically added by the tool “git”
because I dared to use an Unicode character in the commit message
for this patch (and a few others).

Would you like to change the mentioned implementation detail at all?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown Jan. 17, 2017, 7:37 p.m. UTC | #5 
On Tue, Jan 17, 2017 at 08:28:12PM +0100, SF Markus Elfring wrote:
> > You've got MIME headers in the middle of the patch description.

> The extra header fields were automatically added by the tool “git”
> because I dared to use an Unicode character in the commit message
> for this patch (and a few others).

> Would you like to change the mentioned implementation detail at all?

Well, I've deleted the mails now so...

Better yet would be to send patches with a sender address matching the
author information in your patches so they don't get any mangling in the
body at all.
diff mbox

Patch

diff --git a/drivers/spi/spi-ppc4xx.c b/drivers/spi/spi-ppc4xx.c
index 967d94844b30..048794f043a0 100644
--- a/drivers/spi/spi-ppc4xx.c
+++ b/drivers/spi/spi-ppc4xx.c
@@ -229,7 +229,7 @@  static int spi_ppc4xx_setup(struct spi_device *spi)
 		return -EINVAL;
 	}
 
-	if (cs == NULL) {
+	if (!cs) {
 		cs = kzalloc(sizeof *cs, GFP_KERNEL);
 		if (!cs)
 			return -ENOMEM;
@@ -392,7 +392,7 @@  static int spi_ppc4xx_of_probe(struct platform_device *op)
 	const unsigned int *clk;
 
 	master = spi_alloc_master(dev, sizeof *hw);
-	if (master == NULL)
+	if (!master)
 		return -ENOMEM;
 	master->dev.of_node = np;
 	platform_set_drvdata(op, master);
@@ -466,14 +466,14 @@  static int spi_ppc4xx_of_probe(struct platform_device *op)
 
 	/* Get the clock for the OPB */
 	opbnp = of_find_compatible_node(NULL, NULL, "ibm,opb");
-	if (opbnp == NULL) {
+	if (!opbnp) {
 		dev_err(dev, "OPB: cannot find node\n");
 		ret = -ENODEV;
 		goto free_gpios;
 	}
 	/* Get the clock (Hz) for the OPB */
 	clk = of_get_property(opbnp, "clock-frequency", NULL);
-	if (clk == NULL) {
+	if (!clk) {
 		dev_err(dev, "OPB: no clock-frequency property set\n");
 		of_node_put(opbnp);
 		ret = -ENODEV;