| Message ID | 50472f2d-4a71-5f6b-1037-bbefd2d8f4f4@kamp.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am 17.01.2017 um 16:14 hat Peter Lieven geschrieben: > Am 31.10.2016 um 18:20 schrieb Kevin Wolf: > >Am 31.10.2016 um 16:05 hat Ashijeet Acharya geschrieben: > >>Previously posted series patches: > >>v5: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07580.html > >>v4: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07449.html > >>v3: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg06903.html > >>v2: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg05844.html > >>v1: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg04487.html > >> > >>This series adds blockdev-add support for NFS block driver. > >Thanks, fixed as commented on patch 1 and applied. > > Hi, > > it seems this series breaks passing options via URI. > > 1) in nfs_parse_uri > > parse_uint_full(qp->p[i].value, NULL, 0) > > segfaults, as the routine wants to set *NULL = val. Yes, you're right. > 2) all parameters that have a different names in options and qdict > e.g. readahead-size vs. readahead cannot be passed via URI. > > $ qemu-img convert -p nfs://172.21.200.61/templates/VC_debian8-20170116.qcow2,linux\?readahead=131072 iscsi://172.21.200.56:3260/iqn.2001-05.com.equallogic:0-8a0906-69d384e0a-aa3004e55e15878d-XXX/0 > > qemu-img: Could not open 'nfs://172.21.200.61/vcore-dev-cdrom/templates/VC_debian8-20170116.qcow2,linux?readahead=131072': Block protocol 'nfs' doesn't support the option 'readahead-size' > > Please let me know if the below fix would be correct: No, this needs to be fixed the other way round: runtime_opts must use the names as specified in the schema, and nfs_client_open() must access them as such. Without that, blockdev-add can't work (and the command line only with the "wrong" old option names from the URL, whereas it should be using the same names as the QAPI schema). Kevin
Am 18.01.2017 um 10:59 schrieb Kevin Wolf: > Am 17.01.2017 um 16:14 hat Peter Lieven geschrieben: >> Am 31.10.2016 um 18:20 schrieb Kevin Wolf: >>> Am 31.10.2016 um 16:05 hat Ashijeet Acharya geschrieben: >>>> Previously posted series patches: >>>> v5: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07580.html >>>> v4: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07449.html >>>> v3: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg06903.html >>>> v2: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg05844.html >>>> v1: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg04487.html >>>> >>>> This series adds blockdev-add support for NFS block driver. >>> Thanks, fixed as commented on patch 1 and applied. >> Hi, >> >> it seems this series breaks passing options via URI. >> >> 1) in nfs_parse_uri >> >> parse_uint_full(qp->p[i].value, NULL, 0) >> >> segfaults, as the routine wants to set *NULL = val. > Yes, you're right. > >> 2) all parameters that have a different names in options and qdict >> e.g. readahead-size vs. readahead cannot be passed via URI. >> >> $ qemu-img convert -p nfs://172.21.200.61/templates/VC_debian8-20170116.qcow2,linux\?readahead=131072 iscsi://172.21.200.56:3260/iqn.2001-05.com.equallogic:0-8a0906-69d384e0a-aa3004e55e15878d-XXX/0 >> >> qemu-img: Could not open 'nfs://172.21.200.61/vcore-dev-cdrom/templates/VC_debian8-20170116.qcow2,linux?readahead=131072': Block protocol 'nfs' doesn't support the option 'readahead-size' >> >> Please let me know if the below fix would be correct: > No, this needs to be fixed the other way round: runtime_opts must use > the names as specified in the schema, and nfs_client_open() must access > them as such. Without that, blockdev-add can't work (and the command > line only with the "wrong" old option names from the URL, whereas it > should be using the same names as the QAPI schema). Shouldn't we support both for backwards compatiblity.? Peter
On 01/19/2017 08:30 AM, Peter Lieven wrote: >>> qemu-img: Could not open >>> 'nfs://172.21.200.61/vcore-dev-cdrom/templates/VC_debian8-20170116.qcow2,linux?readahead=131072': >>> Block protocol 'nfs' doesn't support the option 'readahead-size' >>> >>> Please let me know if the below fix would be correct: >> No, this needs to be fixed the other way round: runtime_opts must use >> the names as specified in the schema, and nfs_client_open() must access >> them as such. Without that, blockdev-add can't work (and the command >> line only with the "wrong" old option names from the URL, whereas it >> should be using the same names as the QAPI schema). > > Shouldn't we support both for backwards compatiblity.? blockdev-add only needs to support the modern naming. But yes, preserving back-compat spelling of the command-line spellings, as well as matching blockdev-add spellings, is desirable.
Am 19.01.2017 um 15:59 hat Eric Blake geschrieben: > On 01/19/2017 08:30 AM, Peter Lieven wrote: > >>> qemu-img: Could not open > >>> 'nfs://172.21.200.61/vcore-dev-cdrom/templates/VC_debian8-20170116.qcow2,linux?readahead=131072': > >>> Block protocol 'nfs' doesn't support the option 'readahead-size' > >>> > >>> Please let me know if the below fix would be correct: > >> No, this needs to be fixed the other way round: runtime_opts must use > >> the names as specified in the schema, and nfs_client_open() must access > >> them as such. Without that, blockdev-add can't work (and the command > >> line only with the "wrong" old option names from the URL, whereas it > >> should be using the same names as the QAPI schema). > > > > Shouldn't we support both for backwards compatiblity.? > > blockdev-add only needs to support the modern naming. But yes, > preserving back-compat spelling of the command-line spellings, as well > as matching blockdev-add spellings, is desirable. We only just added the individual command line options, previously it only supported the URL. It's true that we have the messed up version of the options in 2.8, so strictly speaking we would break compatibility with a release, but it's only one release, it's only the nfs driver, and the documentation of the options is the schema, which had the right option names even in 2.8 (they just didn't work). So I wouldn't feel bad about removing the wrong names in this specific case. Kevin
Am 19.01.2017 um 16:20 schrieb Kevin Wolf: > Am 19.01.2017 um 15:59 hat Eric Blake geschrieben: >> On 01/19/2017 08:30 AM, Peter Lieven wrote: >>>>> qemu-img: Could not open >>>>> 'nfs://172.21.200.61/vcore-dev-cdrom/templates/VC_debian8-20170116.qcow2,linux?readahead=131072': >>>>> Block protocol 'nfs' doesn't support the option 'readahead-size' >>>>> >>>>> Please let me know if the below fix would be correct: >>>> No, this needs to be fixed the other way round: runtime_opts must use >>>> the names as specified in the schema, and nfs_client_open() must access >>>> them as such. Without that, blockdev-add can't work (and the command >>>> line only with the "wrong" old option names from the URL, whereas it >>>> should be using the same names as the QAPI schema). >>> Shouldn't we support both for backwards compatiblity.? >> blockdev-add only needs to support the modern naming. But yes, >> preserving back-compat spelling of the command-line spellings, as well >> as matching blockdev-add spellings, is desirable. > We only just added the individual command line options, previously it > only supported the URL. > > It's true that we have the messed up version of the options in 2.8, so > strictly speaking we would break compatibility with a release, but it's > only one release, it's only the nfs driver, and the documentation of the > options is the schema, which had the right option names even in 2.8 > (they just didn't work). > > So I wouldn't feel bad about removing the wrong names in this specific > case. So want exactly do you want to do? Fix the names in the QAPI schema to use the old naming? Peter
Am 19.01.2017 um 16:34 hat Peter Lieven geschrieben: > Am 19.01.2017 um 16:20 schrieb Kevin Wolf: > >Am 19.01.2017 um 15:59 hat Eric Blake geschrieben: > >>On 01/19/2017 08:30 AM, Peter Lieven wrote: > >>>>>qemu-img: Could not open > >>>>>'nfs://172.21.200.61/vcore-dev-cdrom/templates/VC_debian8-20170116.qcow2,linux?readahead=131072': > >>>>>Block protocol 'nfs' doesn't support the option 'readahead-size' > >>>>> > >>>>>Please let me know if the below fix would be correct: > >>>>No, this needs to be fixed the other way round: runtime_opts must use > >>>>the names as specified in the schema, and nfs_client_open() must access > >>>>them as such. Without that, blockdev-add can't work (and the command > >>>>line only with the "wrong" old option names from the URL, whereas it > >>>>should be using the same names as the QAPI schema). > >>>Shouldn't we support both for backwards compatiblity.? > >>blockdev-add only needs to support the modern naming. But yes, > >>preserving back-compat spelling of the command-line spellings, as well > >>as matching blockdev-add spellings, is desirable. > >We only just added the individual command line options, previously it > >only supported the URL. > > > >It's true that we have the messed up version of the options in 2.8, so > >strictly speaking we would break compatibility with a release, but it's > >only one release, it's only the nfs driver, and the documentation of the > >options is the schema, which had the right option names even in 2.8 > >(they just didn't work). > > > >So I wouldn't feel bad about removing the wrong names in this specific > >case. > > So want exactly do you want to do? Fix the names in the QAPI schema > to use the old naming? No, fix the command line to use the names in the QAPI schema. The option names from the URL were never supposed to be supported on the command line. Kevin
Am 19.01.2017 um 16:42 schrieb Kevin Wolf: > Am 19.01.2017 um 16:34 hat Peter Lieven geschrieben: >> Am 19.01.2017 um 16:20 schrieb Kevin Wolf: >>> Am 19.01.2017 um 15:59 hat Eric Blake geschrieben: >>>> On 01/19/2017 08:30 AM, Peter Lieven wrote: >>>>>>> qemu-img: Could not open >>>>>>> 'nfs://172.21.200.61/vcore-dev-cdrom/templates/VC_debian8-20170116.qcow2,linux?readahead=131072': >>>>>>> Block protocol 'nfs' doesn't support the option 'readahead-size' >>>>>>> >>>>>>> Please let me know if the below fix would be correct: >>>>>> No, this needs to be fixed the other way round: runtime_opts must use >>>>>> the names as specified in the schema, and nfs_client_open() must access >>>>>> them as such. Without that, blockdev-add can't work (and the command >>>>>> line only with the "wrong" old option names from the URL, whereas it >>>>>> should be using the same names as the QAPI schema). >>>>> Shouldn't we support both for backwards compatiblity.? >>>> blockdev-add only needs to support the modern naming. But yes, >>>> preserving back-compat spelling of the command-line spellings, as well >>>> as matching blockdev-add spellings, is desirable. >>> We only just added the individual command line options, previously it >>> only supported the URL. >>> >>> It's true that we have the messed up version of the options in 2.8, so >>> strictly speaking we would break compatibility with a release, but it's >>> only one release, it's only the nfs driver, and the documentation of the >>> options is the schema, which had the right option names even in 2.8 >>> (they just didn't work). >>> >>> So I wouldn't feel bad about removing the wrong names in this specific >>> case. >> So want exactly do you want to do? Fix the names in the QAPI schema >> to use the old naming? > No, fix the command line to use the names in the QAPI schema. > > The option names from the URL were never supposed to be supported on the > command line. Okay, so no backwards compatiblity? I actually used the options on the command line... Peter
Am 19.01.2017 um 16:44 hat Peter Lieven geschrieben: > Am 19.01.2017 um 16:42 schrieb Kevin Wolf: > >Am 19.01.2017 um 16:34 hat Peter Lieven geschrieben: > >>Am 19.01.2017 um 16:20 schrieb Kevin Wolf: > >>>Am 19.01.2017 um 15:59 hat Eric Blake geschrieben: > >>>>On 01/19/2017 08:30 AM, Peter Lieven wrote: > >>>>>>>qemu-img: Could not open > >>>>>>>'nfs://172.21.200.61/vcore-dev-cdrom/templates/VC_debian8-20170116.qcow2,linux?readahead=131072': > >>>>>>>Block protocol 'nfs' doesn't support the option 'readahead-size' > >>>>>>> > >>>>>>>Please let me know if the below fix would be correct: > >>>>>>No, this needs to be fixed the other way round: runtime_opts must use > >>>>>>the names as specified in the schema, and nfs_client_open() must access > >>>>>>them as such. Without that, blockdev-add can't work (and the command > >>>>>>line only with the "wrong" old option names from the URL, whereas it > >>>>>>should be using the same names as the QAPI schema). > >>>>>Shouldn't we support both for backwards compatiblity.? > >>>>blockdev-add only needs to support the modern naming. But yes, > >>>>preserving back-compat spelling of the command-line spellings, as well > >>>>as matching blockdev-add spellings, is desirable. > >>>We only just added the individual command line options, previously it > >>>only supported the URL. > >>> > >>>It's true that we have the messed up version of the options in 2.8, so > >>>strictly speaking we would break compatibility with a release, but it's > >>>only one release, it's only the nfs driver, and the documentation of the > >>>options is the schema, which had the right option names even in 2.8 > >>>(they just didn't work). > >>> > >>>So I wouldn't feel bad about removing the wrong names in this specific > >>>case. > >>So want exactly do you want to do? Fix the names in the QAPI schema > >>to use the old naming? > >No, fix the command line to use the names in the QAPI schema. > > > >The option names from the URL were never supposed to be supported on the > >command line. > > Okay, so no backwards compatiblity? I actually used the options on the command line... Well, do you _need_ compatibility? It can certainly be done, but as the (wrong) options on the command line have only existed since November and were never documented, I wouldn't bother unless there's a good reason. Kevin
Am 19.01.2017 um 16:55 schrieb Kevin Wolf: > Am 19.01.2017 um 16:44 hat Peter Lieven geschrieben: >> Am 19.01.2017 um 16:42 schrieb Kevin Wolf: >>> Am 19.01.2017 um 16:34 hat Peter Lieven geschrieben: >>>> Am 19.01.2017 um 16:20 schrieb Kevin Wolf: >>>>> Am 19.01.2017 um 15:59 hat Eric Blake geschrieben: >>>>>> On 01/19/2017 08:30 AM, Peter Lieven wrote: >>>>>>>>> qemu-img: Could not open >>>>>>>>> 'nfs://172.21.200.61/vcore-dev-cdrom/templates/VC_debian8-20170116.qcow2,linux?readahead=131072': >>>>>>>>> Block protocol 'nfs' doesn't support the option 'readahead-size' >>>>>>>>> >>>>>>>>> Please let me know if the below fix would be correct: >>>>>>>> No, this needs to be fixed the other way round: runtime_opts must use >>>>>>>> the names as specified in the schema, and nfs_client_open() must access >>>>>>>> them as such. Without that, blockdev-add can't work (and the command >>>>>>>> line only with the "wrong" old option names from the URL, whereas it >>>>>>>> should be using the same names as the QAPI schema). >>>>>>> Shouldn't we support both for backwards compatiblity.? >>>>>> blockdev-add only needs to support the modern naming. But yes, >>>>>> preserving back-compat spelling of the command-line spellings, as well >>>>>> as matching blockdev-add spellings, is desirable. >>>>> We only just added the individual command line options, previously it >>>>> only supported the URL. >>>>> >>>>> It's true that we have the messed up version of the options in 2.8, so >>>>> strictly speaking we would break compatibility with a release, but it's >>>>> only one release, it's only the nfs driver, and the documentation of the >>>>> options is the schema, which had the right option names even in 2.8 >>>>> (they just didn't work). >>>>> >>>>> So I wouldn't feel bad about removing the wrong names in this specific >>>>> case. >>>> So want exactly do you want to do? Fix the names in the QAPI schema >>>> to use the old naming? >>> No, fix the command line to use the names in the QAPI schema. >>> >>> The option names from the URL were never supposed to be supported on the >>> command line. >> Okay, so no backwards compatiblity? I actually used the options on the command line... > Well, do you _need_ compatibility? > > It can certainly be done, but as the (wrong) options on the command line > have only existed since November and were never documented, I wouldn't > bother unless there's a good reason. Every Qemu before 2.8.0 was working with sth like: qemu -cdrom nfs://10.0.0.1/expory/my.iso?readahead=131072 Peter
Am 19.01.2017 um 16:58 hat Peter Lieven geschrieben: > Am 19.01.2017 um 16:55 schrieb Kevin Wolf: > >Am 19.01.2017 um 16:44 hat Peter Lieven geschrieben: > >>Am 19.01.2017 um 16:42 schrieb Kevin Wolf: > >>>Am 19.01.2017 um 16:34 hat Peter Lieven geschrieben: > >>>>Am 19.01.2017 um 16:20 schrieb Kevin Wolf: > >>>>>Am 19.01.2017 um 15:59 hat Eric Blake geschrieben: > >>>>>>On 01/19/2017 08:30 AM, Peter Lieven wrote: > >>>>>>>>>qemu-img: Could not open > >>>>>>>>>'nfs://172.21.200.61/vcore-dev-cdrom/templates/VC_debian8-20170116.qcow2,linux?readahead=131072': > >>>>>>>>>Block protocol 'nfs' doesn't support the option 'readahead-size' > >>>>>>>>> > >>>>>>>>>Please let me know if the below fix would be correct: > >>>>>>>>No, this needs to be fixed the other way round: runtime_opts must use > >>>>>>>>the names as specified in the schema, and nfs_client_open() must access > >>>>>>>>them as such. Without that, blockdev-add can't work (and the command > >>>>>>>>line only with the "wrong" old option names from the URL, whereas it > >>>>>>>>should be using the same names as the QAPI schema). > >>>>>>>Shouldn't we support both for backwards compatiblity.? > >>>>>>blockdev-add only needs to support the modern naming. But yes, > >>>>>>preserving back-compat spelling of the command-line spellings, as well > >>>>>>as matching blockdev-add spellings, is desirable. > >>>>>We only just added the individual command line options, previously it > >>>>>only supported the URL. > >>>>> > >>>>>It's true that we have the messed up version of the options in 2.8, so > >>>>>strictly speaking we would break compatibility with a release, but it's > >>>>>only one release, it's only the nfs driver, and the documentation of the > >>>>>options is the schema, which had the right option names even in 2.8 > >>>>>(they just didn't work). > >>>>> > >>>>>So I wouldn't feel bad about removing the wrong names in this specific > >>>>>case. > >>>>So want exactly do you want to do? Fix the names in the QAPI schema > >>>>to use the old naming? > >>>No, fix the command line to use the names in the QAPI schema. > >>> > >>>The option names from the URL were never supposed to be supported on the > >>>command line. > >>Okay, so no backwards compatiblity? I actually used the options on the command line... > >Well, do you _need_ compatibility? > > > >It can certainly be done, but as the (wrong) options on the command line > >have only existed since November and were never documented, I wouldn't > >bother unless there's a good reason. > > Every Qemu before 2.8.0 was working with sth like: > > qemu -cdrom nfs://10.0.0.1/expory/my.iso?readahead=131072 That will keep working. We're not changing the URL parsing, just the runtime_opts and its accesses in nfs_client_open(). The translation in nfs_parse_uri() stays intact with the fixes. What will stop working (and only worked in 2.8.0) is this: qemu -drive media=cdrom,driver=nfs,server.host=10.0.0.1,path=export/my.iso,readahead=131072 Also, I think the fixes should be Cc: qemu-stable, so that 2.8.1 will work correctly again. Kevin
Am 19.01.2017 um 18:08 schrieb Kevin Wolf: > Am 19.01.2017 um 16:58 hat Peter Lieven geschrieben: >> Am 19.01.2017 um 16:55 schrieb Kevin Wolf: >>> Am 19.01.2017 um 16:44 hat Peter Lieven geschrieben: >>>> Am 19.01.2017 um 16:42 schrieb Kevin Wolf: >>>>> Am 19.01.2017 um 16:34 hat Peter Lieven geschrieben: >>>>>> Am 19.01.2017 um 16:20 schrieb Kevin Wolf: >>>>>>> Am 19.01.2017 um 15:59 hat Eric Blake geschrieben: >>>>>>>> On 01/19/2017 08:30 AM, Peter Lieven wrote: >>>>>>>>>>> qemu-img: Could not open >>>>>>>>>>> 'nfs://172.21.200.61/vcore-dev-cdrom/templates/VC_debian8-20170116.qcow2,linux?readahead=131072': >>>>>>>>>>> Block protocol 'nfs' doesn't support the option 'readahead-size' >>>>>>>>>>> >>>>>>>>>>> Please let me know if the below fix would be correct: >>>>>>>>>> No, this needs to be fixed the other way round: runtime_opts must use >>>>>>>>>> the names as specified in the schema, and nfs_client_open() must access >>>>>>>>>> them as such. Without that, blockdev-add can't work (and the command >>>>>>>>>> line only with the "wrong" old option names from the URL, whereas it >>>>>>>>>> should be using the same names as the QAPI schema). >>>>>>>>> Shouldn't we support both for backwards compatiblity.? >>>>>>>> blockdev-add only needs to support the modern naming. But yes, >>>>>>>> preserving back-compat spelling of the command-line spellings, as well >>>>>>>> as matching blockdev-add spellings, is desirable. >>>>>>> We only just added the individual command line options, previously it >>>>>>> only supported the URL. >>>>>>> >>>>>>> It's true that we have the messed up version of the options in 2.8, so >>>>>>> strictly speaking we would break compatibility with a release, but it's >>>>>>> only one release, it's only the nfs driver, and the documentation of the >>>>>>> options is the schema, which had the right option names even in 2.8 >>>>>>> (they just didn't work). >>>>>>> >>>>>>> So I wouldn't feel bad about removing the wrong names in this specific >>>>>>> case. >>>>>> So want exactly do you want to do? Fix the names in the QAPI schema >>>>>> to use the old naming? >>>>> No, fix the command line to use the names in the QAPI schema. >>>>> >>>>> The option names from the URL were never supposed to be supported on the >>>>> command line. >>>> Okay, so no backwards compatiblity? I actually used the options on the command line... >>> Well, do you _need_ compatibility? >>> >>> It can certainly be done, but as the (wrong) options on the command line >>> have only existed since November and were never documented, I wouldn't >>> bother unless there's a good reason. >> Every Qemu before 2.8.0 was working with sth like: >> >> qemu -cdrom nfs://10.0.0.1/expory/my.iso?readahead=131072 > That will keep working. We're not changing the URL parsing, just the > runtime_opts and its accesses in nfs_client_open(). The translation in > nfs_parse_uri() stays intact with the fixes. > > What will stop working (and only worked in 2.8.0) is this: > > qemu -drive media=cdrom,driver=nfs,server.host=10.0.0.1,path=export/my.iso,readahead=131072 > > Also, I think the fixes should be Cc: qemu-stable, so that 2.8.1 will > work correctly again. Okay, I hope I got it. Will send a patch tomorrow. Peter
diff --git a/block/nfs.c b/block/nfs.c index a564340..0ff8268 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -108,30 +108,31 @@ static int nfs_parse_uri(const char *filename, QDict *options, Error **errp) qdict_put(options, "path", qstring_from_str(uri->path)); for (i = 0; i < qp->n; i++) { + unsigned long long val; if (!qp->p[i].value) { error_setg(errp, "Value for NFS parameter expected: %s", qp->p[i].name); goto out; } - if (parse_uint_full(qp->p[i].value, NULL, 0)) { + if (parse_uint_full(qp->p[i].value, &val, 0)) { error_setg(errp, "Illegal value for NFS parameter: %s", qp->p[i].name); goto out; } if (!strcmp(qp->p[i].name, "uid")) { - qdict_put(options, "user", + qdict_put(options, "uid", qstring_from_str(qp->p[i].value)); } else if (!strcmp(qp->p[i].name, "gid")) { - qdict_put(options, "group", + qdict_put(options, "gid", qstring_from_str(qp->p[i].value)); } else if (!strcmp(qp->p[i].name, "tcp-syncnt")) { - qdict_put(options, "tcp-syn-count", + qdict_put(options, "tcp-syncnt", qstring_from_str(qp->p[i].value)); } else if (!strcmp(qp->p[i].name, "readahead")) { - qdict_put(options, "readahead-size", + qdict_put(options, "readahead", qstring_from_str(qp->p[i].value)); } else if (!strcmp(qp->p[i].name, "pagecache")) { - qdict_put(options, "page-cache-size", + qdict_put(options, "pagecache", qstring_from_str(qp->p[i].value)); } else if (!strcmp(qp->p[i].name, "debug")) { qdict_put(options, "debug",