diff mbox

arm64: dts: exynos: Remove address node from usb parent node

Message ID 1484718408-28933-1-git-send-email-pankaj.dubey@samsung.com (mailing list archive)
State Rejected
Headers show

Commit Message

Pankaj Dubey Jan. 18, 2017, 5:46 a.m. UTC
Address node does not required to be put after parent't node,
so remove address node from usb parent node.

Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Chanwoo Choi Jan. 18, 2017, 7:04 a.m. UTC | #1
Hi Pankaj,

This issue already posted by Javier Martinez Canillas[1].
Maybe, he will post v2.

[1] https://lkml.org/lkml/2017/1/10/907
- ("Re: [PATCH v2 3/3] arm64: dts: exynos: Remove unneeded unit names in Exynos5433 nodes")

On 2017년 01월 18일 14:46, Pankaj Dubey wrote:
> Address node does not required to be put after parent't node,
> so remove address node from usb parent node.
> 
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 68f764e..0d7a55d 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -1285,7 +1285,7 @@
>  			status = "disabled";
>  		};
>  
> -		usbdrd30: usb@15400000  {
> +		usbdrd30: usb3-0 {
>  			compatible = "samsung,exynos5250-dwusb3";
>  			clocks = <&cmu_fsys CLK_ACLK_USBDRD30>,
>  				<&cmu_fsys CLK_SCLK_USBDRD30>;
> @@ -1332,7 +1332,7 @@
>  			status = "disabled";
>  		};
>  
> -		usbhost30: usb@15a00000 {
> +		usbhost30: usbhost3-0 {
>  			compatible = "samsung,exynos5250-dwusb3";
>  			clocks = <&cmu_fsys CLK_ACLK_USBHOST30>,
>  				<&cmu_fsys CLK_SCLK_USBHOST30>;
>
Javier Martinez Canillas Jan. 18, 2017, 3:36 p.m. UTC | #2
Hello,

On 01/18/2017 04:04 AM, Chanwoo Choi wrote:
> Hi Pankaj,
> 
> This issue already posted by Javier Martinez Canillas[1].
> Maybe, he will post v2.
> 

That's correct, I didn't post a v2 since I was waiting for feedback
from the DT maintainers on patches 1/2 and 2/2 from the same series:

https://www.spinics.net/lists/arm-kernel/msg553286.html

But I'll re-spin just this patch since the changes are independent.

Best regards,
Pankaj Dubey Jan. 20, 2017, 4:23 a.m. UTC | #3
Hi Javier,

On Wednesday 18 January 2017 09:06 PM, Javier Martinez Canillas wrote:
> Hello,
> 
> On 01/18/2017 04:04 AM, Chanwoo Choi wrote:
>> Hi Pankaj,
>>
>> This issue already posted by Javier Martinez Canillas[1].
>> Maybe, he will post v2.
>>
> 
> That's correct, I didn't post a v2 since I was waiting for feedback
> from the DT maintainers on patches 1/2 and 2/2 from the same series:
> 
> https://www.spinics.net/lists/arm-kernel/msg553286.html
> 
> But I'll re-spin just this patch since the changes are independent.
> 

I didn't noticed this earlier. In this case my patch [1] can be ignored.

[1]: https://patchwork.kernel.org/patch/9522645/

Thanks,
Pankaj Dubey

> Best regards,
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 68f764e..0d7a55d 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -1285,7 +1285,7 @@ 
 			status = "disabled";
 		};
 
-		usbdrd30: usb@15400000  {
+		usbdrd30: usb3-0 {
 			compatible = "samsung,exynos5250-dwusb3";
 			clocks = <&cmu_fsys CLK_ACLK_USBDRD30>,
 				<&cmu_fsys CLK_SCLK_USBDRD30>;
@@ -1332,7 +1332,7 @@ 
 			status = "disabled";
 		};
 
-		usbhost30: usb@15a00000 {
+		usbhost30: usbhost3-0 {
 			compatible = "samsung,exynos5250-dwusb3";
 			clocks = <&cmu_fsys CLK_ACLK_USBHOST30>,
 				<&cmu_fsys CLK_SCLK_USBHOST30>;