| Message ID | 20170118081346.8451-1-benjamin.tissoires@redhat.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Andy Shevchenko |
| Headers | show |
On Wed, Jan 18, 2017 at 10:13 AM, Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote: > The patch 3dda3b3798f9: "platform/x86: Add custom surface3 platform > device for controlling LID" from Nov 25, 2016, leads to the following > static checker warning: > > drivers/platform/x86/surface3-wmi.c:168 s3_wmi_check_platform_device() > error: uninitialized symbol 'ts_adev'. > Pushed to fixes, thanks! > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > --- > > Hi Dan, > > Sorry for the lag in treating this simple defect. > > Cheers, > Benjamin > > drivers/platform/x86/surface3-wmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/surface3-wmi.c b/drivers/platform/x86/surface3-wmi.c > index cbf4d83..676cfca 100644 > --- a/drivers/platform/x86/surface3-wmi.c > +++ b/drivers/platform/x86/surface3-wmi.c > @@ -139,7 +139,7 @@ static acpi_status s3_wmi_attach_spi_device(acpi_handle handle, > > static int s3_wmi_check_platform_device(struct device *dev, void *data) > { > - struct acpi_device *adev, *ts_adev; > + struct acpi_device *adev, *ts_adev = NULL; > acpi_handle handle; > acpi_status status; > > -- > 2.9.3 >
diff --git a/drivers/platform/x86/surface3-wmi.c b/drivers/platform/x86/surface3-wmi.c index cbf4d83..676cfca 100644 --- a/drivers/platform/x86/surface3-wmi.c +++ b/drivers/platform/x86/surface3-wmi.c @@ -139,7 +139,7 @@ static acpi_status s3_wmi_attach_spi_device(acpi_handle handle, static int s3_wmi_check_platform_device(struct device *dev, void *data) { - struct acpi_device *adev, *ts_adev; + struct acpi_device *adev, *ts_adev = NULL; acpi_handle handle; acpi_status status;
The patch 3dda3b3798f9: "platform/x86: Add custom surface3 platform device for controlling LID" from Nov 25, 2016, leads to the following static checker warning: drivers/platform/x86/surface3-wmi.c:168 s3_wmi_check_platform_device() error: uninitialized symbol 'ts_adev'. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> --- Hi Dan, Sorry for the lag in treating this simple defect. Cheers, Benjamin drivers/platform/x86/surface3-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)