| Message ID | 1308728785-9588-1-git-send-email-dhobsong@igel.co.jp (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, Jun 22, 2011 at 04:46:25PM +0900, Damian Hobson-Garcia wrote: > The check was intended to test if we have a valid pointer to write into, > but it mistakenly checks the pointer contents instead. > > Since a valid pointer is mandatory for the chroma data if a YCbCr format > is used, the pointer check has been removed. > > Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp> > --- > Sorry, forgot to sign off the previous version. Resend > drivers/video/sh_mobile_meram.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/sh_mobile_meram.c b/drivers/video/sh_mobile_meram.c index 216f7f7..a6f28b9 100644 --- a/drivers/video/sh_mobile_meram.c +++ b/drivers/video/sh_mobile_meram.c @@ -246,7 +246,7 @@ static inline void meram_get_next_icb_addr(struct sh_mobile_meram_info *pdata, icb_offset = 0xc0000000 | (cfg->current_reg << 23); *icb_addr_y = icb_offset | (cfg->icb[0].marker_icb << 24); - if ((*icb_addr_c) && is_nvcolor(cfg->pixelformat)) + if (is_nvcolor(cfg->pixelformat)) *icb_addr_c = icb_offset | (cfg->icb[1].marker_icb << 24); }
The check was intended to test if we have a valid pointer to write into, but it mistakenly checks the pointer contents instead. Since a valid pointer is mandatory for the chroma data if a YCbCr format is used, the pointer check has been removed. Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp> --- Sorry, forgot to sign off the previous version. Resend drivers/video/sh_mobile_meram.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)