| Message ID | 1308327913-23220-3-git-send-email-shved@ispras.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 291600193e5c0c3f0a9af1f23a8076dd7417c02a |
| Headers | show |
On Fri, Jun 17, 2011 at 08:25:12PM +0400, Pavel Shved wrote: > In hecubafb_probe(), after a successful try_module_get, vzalloc may > fail and make the hecubafb_probe return, but the module is not put on > this error path. > > This patch adds an exit point that calls module_put in such situation. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Pavel Shved <shved@ispras.ru> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/hecubafb.c b/drivers/video/hecubafb.c index fbef15f..614251a 100644 --- a/drivers/video/hecubafb.c +++ b/drivers/video/hecubafb.c @@ -233,7 +233,7 @@ static int __devinit hecubafb_probe(struct platform_device *dev) videomemory = vzalloc(videomemorysize); if (!videomemory) - return retval; + goto err_videomem_alloc; info = framebuffer_alloc(sizeof(struct hecubafb_par), &dev->dev); if (!info) @@ -275,6 +275,7 @@ err_fbreg: framebuffer_release(info); err_fballoc: vfree(videomemory); +err_videomem_alloc: module_put(board->owner); return retval; }
In hecubafb_probe(), after a successful try_module_get, vzalloc may fail and make the hecubafb_probe return, but the module is not put on this error path. This patch adds an exit point that calls module_put in such situation. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Pavel Shved <shved@ispras.ru> --- drivers/video/hecubafb.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)