| Message ID | 1484821156-20565-2-git-send-email-yong.mao@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jan 19, 2017 at 6:19 PM, Yong Mao <yong.mao@mediatek.com> wrote: > > From: yong mao <yong.mao@mediatek.com> > > Add description for mtk-hs200-cmd-int-delay > Add description for mtk-hs400-cmd-int-delay > Add description for mtk-hs400-cmd-resp-sel > > Signed-off-by: Yong Mao <yong.mao@mediatek.com> > --- > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > index 0120c7f..149f472 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > @@ -21,6 +21,12 @@ Optional properties: > - assigned-clocks: PLL of the source clock > - assigned-clock-parents: parent of source clock, used for HS400 mode to get 400Mhz source clock > - hs400-ds-delay: HS400 DS delay setting > +- mtk-hs200-cmd-int-delay: HS200 command internal delay setting. > + The value is an integer from 0 to 31 > +- mtk-hs400-cmd-int-delay: HS400 command internal delay setting > + The value is an integer from 0 to 31 I think last time Rob meant that you should add a vendor prefixes like this: mediatek,hs200-cmd-int-delay > +- mtk-hs400-cmd-resp-sel: HS400 command response sample selection > + The value is an integer from 0 to 1 Last time Rob stated this looks like a boolean, and to state that and make the default the more common case. So, this could be something like: mediatek,hs200-cmd-resp-sample-rising: A boolean. If present, HS400 command responses are sampled on rising edges. If not present, HS400 command responses are sampled on falling edges. > > Examples: > mmc0: mmc@11230000 { > @@ -38,4 +44,7 @@ mmc0: mmc@11230000 { > assigned-clocks = <&topckgen CLK_TOP_MSDC50_0_SEL>; > assigned-clock-parents = <&topckgen CLK_TOP_MSDCPLL_D2>; > hs400-ds-delay = <0x14015>; > + mtk-hs200-cmd-int-delay = <26>; > + mtk-hs400-cmd-int-delay = <14>; > + mtk-hs400-cmd-resp-sel = <0>; /* 0: rising, 1: falling */ > }; > -- > 1.7.9.5 >
+devicetree, Rob On 19 January 2017 at 11:19, Yong Mao <yong.mao@mediatek.com> wrote: > From: yong mao <yong.mao@mediatek.com> > > Add description for mtk-hs200-cmd-int-delay > Add description for mtk-hs400-cmd-int-delay > Add description for mtk-hs400-cmd-resp-sel > > Signed-off-by: Yong Mao <yong.mao@mediatek.com> > --- > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > index 0120c7f..149f472 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > @@ -21,6 +21,12 @@ Optional properties: > - assigned-clocks: PLL of the source clock > - assigned-clock-parents: parent of source clock, used for HS400 mode to get 400Mhz source clock > - hs400-ds-delay: HS400 DS delay setting > +- mtk-hs200-cmd-int-delay: HS200 command internal delay setting. > + The value is an integer from 0 to 31 Please change to: mediatek,hs200-cmd-delay ... and if there is a unit, like ns or us, please add that a suffix. > +- mtk-hs400-cmd-int-delay: HS400 command internal delay setting > + The value is an integer from 0 to 31 mediatek,hs400-cmd-delay and add unit if applicable. > +- mtk-hs400-cmd-resp-sel: HS400 command response sample selection > + The value is an integer from 0 to 1 mediatek,hs400-cmd-resp-sel And make it a boolean value instead! > > Examples: > mmc0: mmc@11230000 { > @@ -38,4 +44,7 @@ mmc0: mmc@11230000 { > assigned-clocks = <&topckgen CLK_TOP_MSDC50_0_SEL>; > assigned-clock-parents = <&topckgen CLK_TOP_MSDCPLL_D2>; > hs400-ds-delay = <0x14015>; > + mtk-hs200-cmd-int-delay = <26>; > + mtk-hs400-cmd-int-delay = <14>; > + mtk-hs400-cmd-resp-sel = <0>; /* 0: rising, 1: falling */ The rising/falling information belongs in description of the binding a few lines above. Please move it there. > }; > -- > 1.7.9.5 > Kind regards Uffe
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt index 0120c7f..149f472 100644 --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt @@ -21,6 +21,12 @@ Optional properties: - assigned-clocks: PLL of the source clock - assigned-clock-parents: parent of source clock, used for HS400 mode to get 400Mhz source clock - hs400-ds-delay: HS400 DS delay setting +- mtk-hs200-cmd-int-delay: HS200 command internal delay setting. + The value is an integer from 0 to 31 +- mtk-hs400-cmd-int-delay: HS400 command internal delay setting + The value is an integer from 0 to 31 +- mtk-hs400-cmd-resp-sel: HS400 command response sample selection + The value is an integer from 0 to 1 Examples: mmc0: mmc@11230000 { @@ -38,4 +44,7 @@ mmc0: mmc@11230000 { assigned-clocks = <&topckgen CLK_TOP_MSDC50_0_SEL>; assigned-clock-parents = <&topckgen CLK_TOP_MSDCPLL_D2>; hs400-ds-delay = <0x14015>; + mtk-hs200-cmd-int-delay = <26>; + mtk-hs400-cmd-int-delay = <14>; + mtk-hs400-cmd-resp-sel = <0>; /* 0: rising, 1: falling */ };