diff mbox

[v3,2/3] dts: mediatek: configure some fixed mmc parameters

Message ID 1484821156-20565-3-git-send-email-yong.mao@mediatek.com (mailing list archive)
State New, archived
Headers show

Commit Message

Yong Mao Jan. 19, 2017, 10:19 a.m. UTC
From: yong mao <yong.mao@mediatek.com>

configure some fixed mmc parameters

Signed-off-by: Yong Mao <yong.mao@mediatek.com>
Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
 arch/arm64/boot/dts/mediatek/mt8173-evb.dts |    3 +++
 1 file changed, 3 insertions(+)

Comments

Ulf Hansson Jan. 20, 2017, 7:59 a.m. UTC | #1
On 19 January 2017 at 11:19, Yong Mao <yong.mao@mediatek.com> wrote:
> From: yong mao <yong.mao@mediatek.com>
>
> configure some fixed mmc parameters
>
> Signed-off-by: Yong Mao <yong.mao@mediatek.com>
> Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>

Please change the prefix of the commit message header to "ARM64: dts: mt8173:".

Also make sure you send this to the ARM mailing list as well.

In general, I think it's better DTS changes go via the ARM SoC tree,
but I can pick it up if it's trivial and I get an ack from the SoC
maintainer.

> ---
>  arch/arm64/boot/dts/mediatek/mt8173-evb.dts |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> index 0ecaad4..403705e 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> @@ -134,6 +134,9 @@
>         bus-width = <8>;
>         max-frequency = <50000000>;
>         cap-mmc-highspeed;
> +       mtk-hs200-cmd-int-delay=<26>;
> +       mtk-hs400-cmd-int-delay=<14>;
> +       mtk-hs400-cmd-resp-sel=<0>; /* 0:rising, 1:falling */
>         vmmc-supply = <&mt6397_vemc_3v3_reg>;
>         vqmmc-supply = <&mt6397_vio18_reg>;
>         non-removable;
> --
> 1.7.9.5
>

Kind regards
Uffe
Matthias Brugger Jan. 24, 2017, 10:36 a.m. UTC | #2
Hi Ulf,

On 01/20/2017 08:59 AM, Ulf Hansson wrote:
> On 19 January 2017 at 11:19, Yong Mao <yong.mao@mediatek.com> wrote:
>> From: yong mao <yong.mao@mediatek.com>
>>
>> configure some fixed mmc parameters
>>
>> Signed-off-by: Yong Mao <yong.mao@mediatek.com>
>> Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
>
> Please change the prefix of the commit message header to "ARM64: dts: mt8173:".
>
> Also make sure you send this to the ARM mailing list as well.
>
> In general, I think it's better DTS changes go via the ARM SoC tree,
> but I can pick it up if it's trivial and I get an ack from the SoC
> maintainer.
>

I can take them through my tree, let's wait at Rob's opinion of v4.

Regards,
Matthias

>> ---
>>  arch/arm64/boot/dts/mediatek/mt8173-evb.dts |    3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
>> index 0ecaad4..403705e 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
>> @@ -134,6 +134,9 @@
>>         bus-width = <8>;
>>         max-frequency = <50000000>;
>>         cap-mmc-highspeed;
>> +       mtk-hs200-cmd-int-delay=<26>;
>> +       mtk-hs400-cmd-int-delay=<14>;
>> +       mtk-hs400-cmd-resp-sel=<0>; /* 0:rising, 1:falling */
>>         vmmc-supply = <&mt6397_vemc_3v3_reg>;
>>         vqmmc-supply = <&mt6397_vio18_reg>;
>>         non-removable;
>> --
>> 1.7.9.5
>>
>
> Kind regards
> Uffe
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
>
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
index 0ecaad4..403705e 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
@@ -134,6 +134,9 @@ 
 	bus-width = <8>;
 	max-frequency = <50000000>;
 	cap-mmc-highspeed;
+	mtk-hs200-cmd-int-delay=<26>;
+	mtk-hs400-cmd-int-delay=<14>;
+	mtk-hs400-cmd-resp-sel=<0>; /* 0:rising, 1:falling */
 	vmmc-supply = <&mt6397_vemc_3v3_reg>;
 	vqmmc-supply = <&mt6397_vio18_reg>;
 	non-removable;