diff mbox

[01/34] target/tcm_fc: Remove a set-but-not-used variable

Message ID 20170125233646.2243-2-bart.vanassche@sandisk.com (mailing list archive)
State Superseded
Headers show

Commit Message

Bart Van Assche Jan. 25, 2017, 11:36 p.m. UTC 
This was detected by building with W=1.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Johannes Thumshirn <jth@kernel.org>
---
 drivers/target/tcm_fc/tfc_cmd.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Hannes Reinecke Jan. 26, 2017, 7:43 a.m. UTC | #1 
On 01/26/2017 12:36 AM, Bart Van Assche wrote:
> This was detected by building with W=1.
> 
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Hannes Reinecke <hare@suse.com>
> Cc: Johannes Thumshirn <jth@kernel.org>
> ---
>  drivers/target/tcm_fc/tfc_cmd.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/target/tcm_fc/tfc_cmd.c b/drivers/target/tcm_fc/tfc_cmd.c
> index 9af7842b8178..ec372860106f 100644
> --- a/drivers/target/tcm_fc/tfc_cmd.c
> +++ b/drivers/target/tcm_fc/tfc_cmd.c
> @@ -83,14 +83,12 @@ void ft_dump_cmd(struct ft_cmd *cmd, const char *caller)
>  static void ft_free_cmd(struct ft_cmd *cmd)
>  {
>  	struct fc_frame *fp;
> -	struct fc_lport *lport;
>  	struct ft_sess *sess;
>  
>  	if (!cmd)
>  		return;
>  	sess = cmd->sess;
>  	fp = cmd->req_frame;
> -	lport = fr_dev(fp);
>  	if (fr_seq(fp))
>  		fc_seq_release(fr_seq(fp));
>  	fc_frame_free(fp);
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
Christoph Hellwig Jan. 26, 2017, 4:36 p.m. UTC | #2 
Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/target/tcm_fc/tfc_cmd.c b/drivers/target/tcm_fc/tfc_cmd.c
index 9af7842b8178..ec372860106f 100644
--- a/drivers/target/tcm_fc/tfc_cmd.c
+++ b/drivers/target/tcm_fc/tfc_cmd.c
@@ -83,14 +83,12 @@  void ft_dump_cmd(struct ft_cmd *cmd, const char *caller)
 static void ft_free_cmd(struct ft_cmd *cmd)
 {
 	struct fc_frame *fp;
-	struct fc_lport *lport;
 	struct ft_sess *sess;
 
 	if (!cmd)
 		return;
 	sess = cmd->sess;
 	fp = cmd->req_frame;
-	lport = fr_dev(fp);
 	if (fr_seq(fp))
 		fc_seq_release(fr_seq(fp));
 	fc_frame_free(fp);