| Message ID | 1485365586-21653-4-git-send-email-joao.m.martins@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jan 25, 2017 at 9:33 AM, Joao Martins <joao.m.martins@oracle.com> wrote: > This file defines an ABI shared between guest and hypervisor(s) > (KVM, Xen) and as such there should be an correspondent entry in > MAINTAINERS file. Notice that there's already a text notice at the > top of the header file, hence this commit simply enforces it more > explicitly and have both peers noticed when such changes happen. > > Signed-off-by: Joao Martins <joao.m.martins@oracle.com> > --- > This was suggested by folks at xen-devel as we missed some of the > ABI additions (e.g. flags field in pvti, TSC stable bit) - so this > patch is to help preventing that from happening. Alternatively I > could instead add a "PVCLOCK ABI" section in this file with the > two mailing lists. If you do the latter, please add me as an R:. --Andy
On 01/26/2017 05:25 PM, Andy Lutomirski wrote: > On Wed, Jan 25, 2017 at 9:33 AM, Joao Martins <joao.m.martins@oracle.com> wrote: >> This file defines an ABI shared between guest and hypervisor(s) >> (KVM, Xen) and as such there should be an correspondent entry in >> MAINTAINERS file. Notice that there's already a text notice at the >> top of the header file, hence this commit simply enforces it more >> explicitly and have both peers noticed when such changes happen. >> >> Signed-off-by: Joao Martins <joao.m.martins@oracle.com> >> --- >> This was suggested by folks at xen-devel as we missed some of the >> ABI additions (e.g. flags field in pvti, TSC stable bit) - so this >> patch is to help preventing that from happening. Alternatively I >> could instead add a "PVCLOCK ABI" section in this file with the >> two mailing lists. > > If you do the latter, please add me as an R:. OK, Thanks. Since the ABI is used on both hypervisors I'll leave/wait for maintainers to voice their preference. Joao
On 25/01/17 18:33, Joao Martins wrote: > This file defines an ABI shared between guest and hypervisor(s) > (KVM, Xen) and as such there should be an correspondent entry in > MAINTAINERS file. Notice that there's already a text notice at the > top of the header file, hence this commit simply enforces it more > explicitly and have both peers noticed when such changes happen. > > Signed-off-by: Joao Martins <joao.m.martins@oracle.com> > --- > This was suggested by folks at xen-devel as we missed some of the > ABI additions (e.g. flags field in pvti, TSC stable bit) - so this > patch is to help preventing that from happening. Alternatively I > could instead add a "PVCLOCK ABI" section in this file with the > two mailing lists. I don't mind either way. In case of an own section: make it more generic like "PARAVIRT ABIS" as there might be more than PVCLOCK (if not now maybe in future). For both variants: Acked-by: Juergen Gross <jgross@suse.com> Juergen > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 26edd83..c4315d1 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -7041,6 +7041,7 @@ F: Documentation/virtual/kvm/ > F: arch/*/kvm/ > F: arch/x86/kernel/kvm.c > F: arch/x86/kernel/kvmclock.c > +F: arch/x86/include/asm/pvclock-abi.h > F: arch/*/include/asm/kvm* > F: include/linux/kvm* > F: include/uapi/linux/kvm* > @@ -13483,6 +13484,7 @@ M: Juergen Gross <jgross@suse.com> > L: xen-devel@lists.xenproject.org (moderated for non-subscribers) > T: git git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > S: Supported > +F: arch/x86/include/asm/pvclock-abi.h > F: arch/x86/xen/ > F: drivers/*/xen-*front.c > F: drivers/xen/ >
diff --git a/MAINTAINERS b/MAINTAINERS index 26edd83..c4315d1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7041,6 +7041,7 @@ F: Documentation/virtual/kvm/ F: arch/*/kvm/ F: arch/x86/kernel/kvm.c F: arch/x86/kernel/kvmclock.c +F: arch/x86/include/asm/pvclock-abi.h F: arch/*/include/asm/kvm* F: include/linux/kvm* F: include/uapi/linux/kvm* @@ -13483,6 +13484,7 @@ M: Juergen Gross <jgross@suse.com> L: xen-devel@lists.xenproject.org (moderated for non-subscribers) T: git git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git S: Supported +F: arch/x86/include/asm/pvclock-abi.h F: arch/x86/xen/ F: drivers/*/xen-*front.c F: drivers/xen/
This file defines an ABI shared between guest and hypervisor(s) (KVM, Xen) and as such there should be an correspondent entry in MAINTAINERS file. Notice that there's already a text notice at the top of the header file, hence this commit simply enforces it more explicitly and have both peers noticed when such changes happen. Signed-off-by: Joao Martins <joao.m.martins@oracle.com> --- This was suggested by folks at xen-devel as we missed some of the ABI additions (e.g. flags field in pvti, TSC stable bit) - so this patch is to help preventing that from happening. Alternatively I could instead add a "PVCLOCK ABI" section in this file with the two mailing lists. --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+)