diff mbox

[libdrm,5/5] android: silence ~550 warnings

Message ID 20170122183443.11963-5-emil.l.velikov@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Emil Velikov Jan. 22, 2017, 6:34 p.m. UTC
Analogous to the autoconf build add the following to the build

   -Wno-unused-parameter
   -Wno-missing-field-initializers

Cc: Chih-Wei Huang <cwhuang@android-x86.org>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
---
According to Rob's jenkins build there's still some 26 libdrm warnings
libdrm most of which duplicates - can we fix those properly ?

There might be a lot more since it builds only libdrm and the freedreno,
intel and radeon DSO.

Rob, with this patch/series the total warnings reported drops by half ;-)
---
 Android.common.mk | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Emil Velikov Jan. 26, 2017, 1:28 p.m. UTC | #1
On 22 January 2017 at 18:34, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> Analogous to the autoconf build add the following to the build
>
>    -Wno-unused-parameter
>    -Wno-missing-field-initializers
>
> Cc: Chih-Wei Huang <cwhuang@android-x86.org>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
> ---
> According to Rob's jenkins build there's still some 26 libdrm warnings
> libdrm most of which duplicates - can we fix those properly ?
>
> There might be a lot more since it builds only libdrm and the freedreno,
> intel and radeon DSO.
>
> Rob, with this patch/series the total warnings reported drops by half ;-)
Meant to say this but I've completely forgot:

The series is untested so any input will be greatly appreciated.

-Emil
Rob Herring (Arm) Jan. 26, 2017, 6:04 p.m. UTC | #2
On Sun, Jan 22, 2017 at 12:34 PM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> Analogous to the autoconf build add the following to the build
>
>    -Wno-unused-parameter
>    -Wno-missing-field-initializers
>
> Cc: Chih-Wei Huang <cwhuang@android-x86.org>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
> ---
> According to Rob's jenkins build there's still some 26 libdrm warnings
> libdrm most of which duplicates - can we fix those properly ?
>
> There might be a lot more since it builds only libdrm and the freedreno,
> intel and radeon DSO.
>
> Rob, with this patch/series the total warnings reported drops by half ;-)

I added these on mesa I think, so I'm not sure how I missed them for libdrm.

Reviewed-by: Rob Herring <robh@kernel.org>

Rob
diff mbox

Patch

diff --git a/Android.common.mk b/Android.common.mk
index 71f14ec3..f57b8d37 100644
--- a/Android.common.mk
+++ b/Android.common.mk
@@ -3,6 +3,10 @@  LOCAL_CFLAGS += \
 	-DHAVE_VISIBILITY=1 \
 	-DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
 
+LOCAL_CFLAGS += \
+	-Wno-unused-parameter \
+	-Wno-missing-field-initializers
+
 # Quiet down the build system and remove any .h files from the sources
 LOCAL_SRC_FILES := $(patsubst %.h, , $(LOCAL_SRC_FILES))
 LOCAL_EXPORT_C_INCLUDE_DIRS += $(LOCAL_PATH)