| Message ID | 20170126225621.12314-15-noralf@tronnes.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jan 26, 2017 at 11:56:16PM +0100, Noralf Trønnes wrote: > drm_debugfs_cleanup() now removes all minor->debugfs_list entries > automatically, so the drm_driver.debugfs_cleanup callback is not > needed. > > Cc: thierry.reding@gmail.com > Signed-off-by: Noralf Trønnes <noralf@tronnes.org> Already mentioned on the cover letter, but I think you can savely remove all other debugfs cleanup calls too. -Daniel > --- > drivers/gpu/drm/tegra/drm.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c > index 2d57f62..ef215fe 100644 > --- a/drivers/gpu/drm/tegra/drm.c > +++ b/drivers/gpu/drm/tegra/drm.c > @@ -894,12 +894,6 @@ static int tegra_debugfs_init(struct drm_minor *minor) > ARRAY_SIZE(tegra_debugfs_list), > minor->debugfs_root, minor); > } > - > -static void tegra_debugfs_cleanup(struct drm_minor *minor) > -{ > - drm_debugfs_remove_files(tegra_debugfs_list, > - ARRAY_SIZE(tegra_debugfs_list), minor); > -} > #endif > > static struct drm_driver tegra_drm_driver = { > @@ -917,7 +911,6 @@ static struct drm_driver tegra_drm_driver = { > > #if defined(CONFIG_DEBUG_FS) > .debugfs_init = tegra_debugfs_init, > - .debugfs_cleanup = tegra_debugfs_cleanup, > #endif > > .gem_free_object_unlocked = tegra_bo_free_object, > -- > 2.10.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Thu, Jan 26, 2017 at 11:56:16PM +0100, Noralf Trønnes wrote: > drm_debugfs_cleanup() now removes all minor->debugfs_list entries > automatically, so the drm_driver.debugfs_cleanup callback is not > needed. > > Cc: thierry.reding@gmail.com > Signed-off-by: Noralf Trønnes <noralf@tronnes.org> > --- > drivers/gpu/drm/tegra/drm.c | 7 ------- > 1 file changed, 7 deletions(-) Reviewed-by: Thierry Reding <treding@nvidia.com>
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index 2d57f62..ef215fe 100644 --- a/drivers/gpu/drm/tegra/drm.c +++ b/drivers/gpu/drm/tegra/drm.c @@ -894,12 +894,6 @@ static int tegra_debugfs_init(struct drm_minor *minor) ARRAY_SIZE(tegra_debugfs_list), minor->debugfs_root, minor); } - -static void tegra_debugfs_cleanup(struct drm_minor *minor) -{ - drm_debugfs_remove_files(tegra_debugfs_list, - ARRAY_SIZE(tegra_debugfs_list), minor); -} #endif static struct drm_driver tegra_drm_driver = { @@ -917,7 +911,6 @@ static struct drm_driver tegra_drm_driver = { #if defined(CONFIG_DEBUG_FS) .debugfs_init = tegra_debugfs_init, - .debugfs_cleanup = tegra_debugfs_cleanup, #endif .gem_free_object_unlocked = tegra_bo_free_object,
drm_debugfs_cleanup() now removes all minor->debugfs_list entries automatically, so the drm_driver.debugfs_cleanup callback is not needed. Cc: thierry.reding@gmail.com Signed-off-by: Noralf Trønnes <noralf@tronnes.org> --- drivers/gpu/drm/tegra/drm.c | 7 ------- 1 file changed, 7 deletions(-)