diff mbox

[06/19] drm/etnaviv: allow build with COMPILE_TEST

Message ID 20170126225621.12314-7-noralf@tronnes.org (mailing list archive)
State New, archived
Headers show

Commit Message

Noralf Trønnes Jan. 26, 2017, 10:56 p.m. UTC
Make it possible to compile test the driver on other platforms.

Cc: l.stach@pengutronix.de
Cc: linux+etnaviv@armlinux.org.uk
Cc: christian.gmeiner@gmail.com
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
 drivers/gpu/drm/etnaviv/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lucas Stach Jan. 27, 2017, 9:57 a.m. UTC | #1
Am Donnerstag, den 26.01.2017, 23:56 +0100 schrieb Noralf Trønnes:
> Make it possible to compile test the driver on other platforms.
> 
> Cc: l.stach@pengutronix.de
> Cc: linux+etnaviv@armlinux.org.uk
> Cc: christian.gmeiner@gmail.com
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>

I'm not sure we are pulling in all dependencies on other platforms, but
as I have no good way to check right now, lets go with the patch and see
if anything blows up:

Acked-by: Lucas Stach <l.stach@pengutronix.de>

> ---
>  drivers/gpu/drm/etnaviv/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/Kconfig b/drivers/gpu/drm/etnaviv/Kconfig
> index 656c061..cc1731c 100644
> --- a/drivers/gpu/drm/etnaviv/Kconfig
> +++ b/drivers/gpu/drm/etnaviv/Kconfig
> @@ -2,7 +2,7 @@
>  config DRM_ETNAVIV
>  	tristate "ETNAVIV (DRM support for Vivante GPU IP cores)"
>  	depends on DRM
> -	depends on ARCH_MXC || ARCH_DOVE
> +	depends on ARCH_MXC || ARCH_DOVE || (ARM && COMPILE_TEST)
>  	depends on MMU
>  	select SHMEM
>  	select TMPFS
Daniel Vetter Jan. 27, 2017, 2:24 p.m. UTC | #2
On Fri, Jan 27, 2017 at 10:57:30AM +0100, Lucas Stach wrote:
> Am Donnerstag, den 26.01.2017, 23:56 +0100 schrieb Noralf Trønnes:
> > Make it possible to compile test the driver on other platforms.
> > 
> > Cc: l.stach@pengutronix.de
> > Cc: linux+etnaviv@armlinux.org.uk
> > Cc: christian.gmeiner@gmail.com
> > Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> 
> I'm not sure we are pulling in all dependencies on other platforms, but
> as I have no good way to check right now, lets go with the patch and see
> if anything blows up:

There's no other way to validate KConfig patches than to apply them and
let 0day beat for a few weeks through all the combinations once it's in
linux-next. 0day doesn't do randomized configs on stuff that's not in
linux-next unfortunately (probably too much of a cpu waste).

> Acked-by: Lucas Stach <l.stach@pengutronix.de>

Thanks, applied.
-Daniel

> 
> > ---
> >  drivers/gpu/drm/etnaviv/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/etnaviv/Kconfig b/drivers/gpu/drm/etnaviv/Kconfig
> > index 656c061..cc1731c 100644
> > --- a/drivers/gpu/drm/etnaviv/Kconfig
> > +++ b/drivers/gpu/drm/etnaviv/Kconfig
> > @@ -2,7 +2,7 @@
> >  config DRM_ETNAVIV
> >  	tristate "ETNAVIV (DRM support for Vivante GPU IP cores)"
> >  	depends on DRM
> > -	depends on ARCH_MXC || ARCH_DOVE
> > +	depends on ARCH_MXC || ARCH_DOVE || (ARM && COMPILE_TEST)
> >  	depends on MMU
> >  	select SHMEM
> >  	select TMPFS
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox

Patch

diff --git a/drivers/gpu/drm/etnaviv/Kconfig b/drivers/gpu/drm/etnaviv/Kconfig
index 656c061..cc1731c 100644
--- a/drivers/gpu/drm/etnaviv/Kconfig
+++ b/drivers/gpu/drm/etnaviv/Kconfig
@@ -2,7 +2,7 @@ 
 config DRM_ETNAVIV
 	tristate "ETNAVIV (DRM support for Vivante GPU IP cores)"
 	depends on DRM
-	depends on ARCH_MXC || ARCH_DOVE
+	depends on ARCH_MXC || ARCH_DOVE || (ARM && COMPILE_TEST)
 	depends on MMU
 	select SHMEM
 	select TMPFS