diff mbox

[i-g-t,v1] lib/drmtest: Add comment explaining DRIVER_ANY excluding DRIVER_VGEM

Message ID 20170130151228.27886-1-robert.foss@collabora.com (mailing list archive)
State New, archived
Headers show

Commit Message

Robert Foss Jan. 30, 2017, 3:12 p.m. UTC
Signed-off-by: Robert Foss <robert.foss@collabora.com>
---
 lib/drmtest.h | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Eric Engestrom Jan. 30, 2017, 3:24 p.m. UTC | #1
On Monday, 2017-01-30 10:12:28 -0500, Robert Foss wrote:
> Signed-off-by: Robert Foss <robert.foss@collabora.com>
> ---
>  lib/drmtest.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/lib/drmtest.h b/lib/drmtest.h
> index 19d4bd19..c9c019c0 100644
> --- a/lib/drmtest.h
> +++ b/lib/drmtest.h
> @@ -42,8 +42,15 @@
>  #define DRIVER_VC4	(1 << 1)
>  #define DRIVER_VGEM	(1 << 2)
>  #define DRIVER_VIRTIO	(1 << 3)
> +/*
> + * Exclude DRVER_VGEM from DRIVER_ANY since if you run on a system
> + * with vgem as well as a supported driver, you can end up with a
> + * near-100% skip rate if you don't explicitly specify the device,
> + * depending on device-load ordering.
> + */
>  #define DRIVER_ANY 	~(DRIVER_VGEM)

Brilliant, cheers :)
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>

>  
> +
>  #ifdef ANDROID
>  #if (!(defined HAVE_MMAP64)) && (!(defined __x86_64__))
>  extern void*  __mmap2(void *, size_t, int, int, int, off_t);
> -- 
> 2.11.0.453.g787f75f05
>
diff mbox

Patch

diff --git a/lib/drmtest.h b/lib/drmtest.h
index 19d4bd19..c9c019c0 100644
--- a/lib/drmtest.h
+++ b/lib/drmtest.h
@@ -42,8 +42,15 @@ 
 #define DRIVER_VC4	(1 << 1)
 #define DRIVER_VGEM	(1 << 2)
 #define DRIVER_VIRTIO	(1 << 3)
+/*
+ * Exclude DRVER_VGEM from DRIVER_ANY since if you run on a system
+ * with vgem as well as a supported driver, you can end up with a
+ * near-100% skip rate if you don't explicitly specify the device,
+ * depending on device-load ordering.
+ */
 #define DRIVER_ANY 	~(DRIVER_VGEM)
 
+
 #ifdef ANDROID
 #if (!(defined HAVE_MMAP64)) && (!(defined __x86_64__))
 extern void*  __mmap2(void *, size_t, int, int, int, off_t);