diff mbox

ARM: bcm2835: dt: add index to the ethernet alias

Message ID 5942321c5d0bfea54eac64ace2b217e8e0b6220d.1485801879.git.baruch@tkos.co.il (mailing list archive)
State New, archived
Headers show

Commit Message

Baruch Siach Jan. 30, 2017, 6:44 p.m. UTC 
An alias name should have an index number even when it is the only of its type.
This allows U-Boot to add the local-mac-address property. Otherwise U-Boot
skips the alias.

Cc: Lubomir Rintel <lkundrak@v3.sk>
Fixes: 6a93792774 ("ARM: bcm2835: dt: Add the ethernet to the device trees")
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi | 2 +-
 arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Lubomir Rintel Jan. 31, 2017, 10:07 a.m. UTC | #1 
On Mon, 2017-01-30 at 20:44 +0200, Baruch Siach wrote:
> An alias name should have an index number even when it is the only of
> its type.
> This allows U-Boot to add the local-mac-address property. Otherwise
> U-Boot
> skips the alias.
> 
> Cc: Lubomir Rintel <lkundrak@v3.sk>
> Fixes: 6a93792774 ("ARM: bcm2835: dt: Add the ethernet to the device
> trees")
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Acked-by: Lubomir Rintel <lkundrak@v3.sk>

> ---
>  arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi | 2 +-
>  arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi
> b/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi
> index 12c981e51134..9a0599f711ff 100644
> --- a/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi
> +++ b/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi
> @@ -1,6 +1,6 @@
>  / {
>  	aliases {
> -		ethernet = &ethernet;
> +		ethernet0 = &ethernet;
>  	};
>  };
>  
> diff --git a/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi
> b/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi
> index 3f0a56ebcf1f..dc7ae776db5f 100644
> --- a/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi
> +++ b/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi
> @@ -1,6 +1,6 @@
>  / {
>  	aliases {
> -		ethernet = &ethernet;
> +		ethernet0 = &ethernet;
>  	};
>  };
>
Eric Anholt Jan. 31, 2017, 6:43 p.m. UTC | #2 
Lubomir Rintel <lkundrak@v3.sk> writes:

> On Mon, 2017-01-30 at 20:44 +0200, Baruch Siach wrote:
>> An alias name should have an index number even when it is the only of
>> its type.
>> This allows U-Boot to add the local-mac-address property. Otherwise
>> U-Boot
>> skips the alias.
>> 
>> Cc: Lubomir Rintel <lkundrak@v3.sk>
>> Fixes: 6a93792774 ("ARM: bcm2835: dt: Add the ethernet to the device
>> trees")
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>
> Acked-by: Lubomir Rintel <lkundrak@v3.sk>

Pulled for dt-next.  Thanks!
diff mbox

Patch

diff --git a/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi b/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi
index 12c981e51134..9a0599f711ff 100644
--- a/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi
+++ b/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi
@@ -1,6 +1,6 @@ 
 / {
 	aliases {
-		ethernet = &ethernet;
+		ethernet0 = &ethernet;
 	};
 };
 
diff --git a/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi b/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi
index 3f0a56ebcf1f..dc7ae776db5f 100644
--- a/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi
+++ b/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi
@@ -1,6 +1,6 @@ 
 / {
 	aliases {
-		ethernet = &ethernet;
+		ethernet0 = &ethernet;
 	};
 };