| Message ID | 1484718141-28785-3-git-send-email-pankaj.dubey@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Wed, Jan 18, 2017 at 2:42 PM, Pankaj Dubey <pankaj.dubey@samsung.com> wrote: > Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except > for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks > pinctrl driver strength related macros which will be used in Exynos7 > DTSi files. > > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > --- Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > include/dt-bindings/pinctrl/samsung.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/dt-bindings/pinctrl/samsung.h b/include/dt-bindings/pinctrl/samsung.h > index 6276eb7..3f1d583 100644 > --- a/include/dt-bindings/pinctrl/samsung.h > +++ b/include/dt-bindings/pinctrl/samsung.h > @@ -54,4 +54,12 @@ > #define EXYNOS_PIN_FUNC_6 6 > #define EXYNOS_PIN_FUNC_F 0xf > > +/* Drive strengths for Exynos7 FSYS1 block */ > +#define EXYNOS7_FSYS1_PIN_DRV_LV1 0 > +#define EXYNOS7_FSYS1_PIN_DRV_LV2 4 > +#define EXYNOS7_FSYS1_PIN_DRV_LV3 2 > +#define EXYNOS7_FSYS1_PIN_DRV_LV4 6 > +#define EXYNOS7_FSYS1_PIN_DRV_LV5 1 > +#define EXYNOS7_FSYS1_PIN_DRV_LV6 5 > + > #endif /* __DT_BINDINGS_PINCTRL_SAMSUNG_H__ */ > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 18, 2017 at 11:12:20AM +0530, Pankaj Dubey wrote: > Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except > for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks > pinctrl driver strength related macros which will be used in Exynos7 > DTSi files. > > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > --- > include/dt-bindings/pinctrl/samsung.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> I will need this header, so Sylwester if it is okay with you, could you provide a tag with it (or ack it)? Best regards, Krzysztof
On 01/18/2017 03:19 PM, Krzysztof Kozlowski wrote: > On Wed, Jan 18, 2017 at 11:12:20AM +0530, Pankaj Dubey wrote: >> Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except >> for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks >> pinctrl driver strength related macros which will be used in Exynos7 >> DTSi files. >> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> >> --- >> include/dt-bindings/pinctrl/samsung.h | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> > > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > > I will need this header, so Sylwester if it is okay with you, could you > provide a tag with it (or ack it)? Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com> I don't have pinctrl/samsung git tree, Linus applies patches directly.
On Fri, Jan 27, 2017 at 01:25:42PM +0100, Sylwester Nawrocki wrote: > On 01/18/2017 03:19 PM, Krzysztof Kozlowski wrote: > > On Wed, Jan 18, 2017 at 11:12:20AM +0530, Pankaj Dubey wrote: > >> Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except > >> for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks > >> pinctrl driver strength related macros which will be used in Exynos7 > >> DTSi files. > >> > >> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > >> --- > >> include/dt-bindings/pinctrl/samsung.h | 8 ++++++++ > >> 1 file changed, 8 insertions(+) > >> > > > > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > > > > I will need this header, so Sylwester if it is okay with you, could you > > provide a tag with it (or ack it)? > > Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > > I don't have pinctrl/samsung git tree, Linus applies patches directly. Oh, my mistake. Linus, This is similar case as "pinctrl: dt-bindings: samsung: add drive strength macros for Exynos5433" [1]. Best regards, Krzysztof [1] https://git.kernel.org/cgit/linux/kernel/git/krzk/linux.git/log/?h=for-v4.11/pinctrl-macros
On Fri, Jan 27, 2017 at 3:41 PM, Krzysztof Kozlowski <krzk@kernel.org> wrote: > On Fri, Jan 27, 2017 at 01:25:42PM +0100, Sylwester Nawrocki wrote: >> On 01/18/2017 03:19 PM, Krzysztof Kozlowski wrote: >> > On Wed, Jan 18, 2017 at 11:12:20AM +0530, Pankaj Dubey wrote: >> >> Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except >> >> for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks >> >> pinctrl driver strength related macros which will be used in Exynos7 >> >> DTSi files. >> >> >> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> >> >> --- >> >> include/dt-bindings/pinctrl/samsung.h | 8 ++++++++ >> >> 1 file changed, 8 insertions(+) >> >> >> > >> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> >> > >> > I will need this header, so Sylwester if it is okay with you, could you >> > provide a tag with it (or ack it)? >> >> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com> >> >> I don't have pinctrl/samsung git tree, Linus applies patches directly. > > Oh, my mistake. > > Linus, > This is similar case as "pinctrl: dt-bindings: samsung: add drive > strength macros for Exynos5433" [1]. OK Acked-by: Linus Walleij <linus.walleij@linaro.org> I expect that you take it through ARM SoC and/or send me a pull request for it on an immutable branch, whatever is best. Yours, Linus Walleij
diff --git a/include/dt-bindings/pinctrl/samsung.h b/include/dt-bindings/pinctrl/samsung.h index 6276eb7..3f1d583 100644 --- a/include/dt-bindings/pinctrl/samsung.h +++ b/include/dt-bindings/pinctrl/samsung.h @@ -54,4 +54,12 @@ #define EXYNOS_PIN_FUNC_6 6 #define EXYNOS_PIN_FUNC_F 0xf +/* Drive strengths for Exynos7 FSYS1 block */ +#define EXYNOS7_FSYS1_PIN_DRV_LV1 0 +#define EXYNOS7_FSYS1_PIN_DRV_LV2 4 +#define EXYNOS7_FSYS1_PIN_DRV_LV3 2 +#define EXYNOS7_FSYS1_PIN_DRV_LV4 6 +#define EXYNOS7_FSYS1_PIN_DRV_LV5 1 +#define EXYNOS7_FSYS1_PIN_DRV_LV6 5 + #endif /* __DT_BINDINGS_PINCTRL_SAMSUNG_H__ */
Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks pinctrl driver strength related macros which will be used in Exynos7 DTSi files. Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> --- include/dt-bindings/pinctrl/samsung.h | 8 ++++++++ 1 file changed, 8 insertions(+)