| Message ID | 20170202142744.3418986-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
Hi, On 02-02-17 15:25, Arnd Bergmann wrote: > The new driver cannot be a loadable module, so if I2C is loadable, we get this > link error: > > drivers/platform/built-in.o: In function `silead_ts_dmi_init': > silead_dmi.c:(.init.text+0x2ef): undefined reference to `i2c_bus_type' > > This makes the Kconfig dependency stricter to require I2C=y. > > Fixes: 9eeda3897a85 ("platform/x86: add support for devices with Silead touchscreens") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thank you. Acked-by: Hans de Goede <hdegoede@redhat.com> Regards. Hans > --- > drivers/platform/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index dd4952ac8797..a7fe9b9f975d 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3 > > config SILEAD_DMI > bool "Tablets with Silead touchscreens" > - depends on ACPI && DMI && I2C && INPUT > + depends on ACPI && DMI && I2C=y && INPUT > ---help--- > Certain ACPI based tablets with Silead touchscreens do not have > enough data in ACPI tables for the touchscreen driver to handle >
On Thu, Feb 2, 2017 at 4:45 PM, Hans de Goede <hdegoede@redhat.com> wrote: > Hi, > > On 02-02-17 15:25, Arnd Bergmann wrote: >> >> The new driver cannot be a loadable module, so if I2C is loadable, we get >> this >> link error: >> >> drivers/platform/built-in.o: In function `silead_ts_dmi_init': >> silead_dmi.c:(.init.text+0x2ef): undefined reference to `i2c_bus_type' >> >> This makes the Kconfig dependency stricter to require I2C=y. >> >> Fixes: 9eeda3897a85 ("platform/x86: add support for devices with Silead >> touchscreens") >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > > Thank you. > > Acked-by: Hans de Goede <hdegoede@redhat.com> I'm a bit confused now: http://www.spinics.net/lists/platform-driver-x86/msg10408.html Please, clarify. > > Regards. > > Hans > > > >> --- >> drivers/platform/x86/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig >> index dd4952ac8797..a7fe9b9f975d 100644 >> --- a/drivers/platform/x86/Kconfig >> +++ b/drivers/platform/x86/Kconfig >> @@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3 >> >> config SILEAD_DMI >> bool "Tablets with Silead touchscreens" >> - depends on ACPI && DMI && I2C && INPUT >> + depends on ACPI && DMI && I2C=y && INPUT >> ---help--- >> Certain ACPI based tablets with Silead touchscreens do not have >> enough data in ACPI tables for the touchscreen driver to handle >> >
Hi, On 02-02-17 16:01, Andy Shevchenko wrote: > On Thu, Feb 2, 2017 at 4:45 PM, Hans de Goede <hdegoede@redhat.com> wrote: >> Hi, >> >> On 02-02-17 15:25, Arnd Bergmann wrote: >>> >>> The new driver cannot be a loadable module, so if I2C is loadable, we get >>> this >>> link error: >>> >>> drivers/platform/built-in.o: In function `silead_ts_dmi_init': >>> silead_dmi.c:(.init.text+0x2ef): undefined reference to `i2c_bus_type' >>> >>> This makes the Kconfig dependency stricter to require I2C=y. >>> >>> Fixes: 9eeda3897a85 ("platform/x86: add support for devices with Silead >>> touchscreens") >>> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> >> >> Thank you. >> >> Acked-by: Hans de Goede <hdegoede@redhat.com> > > I'm a bit confused now: > > http://www.spinics.net/lists/platform-driver-x86/msg10408.html > > Please, clarify. The depends on INPUT is not entirely wrong, the module does not need it, but without the SILEAD driver being build the silead_dmi code is of no use. Since multiple people already reported this I thought it would be best to just go ahead with Arnd's version. Regards, Hans > >> >> Regards. >> >> Hans >> >> >> >>> --- >>> drivers/platform/x86/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig >>> index dd4952ac8797..a7fe9b9f975d 100644 >>> --- a/drivers/platform/x86/Kconfig >>> +++ b/drivers/platform/x86/Kconfig >>> @@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3 >>> >>> config SILEAD_DMI >>> bool "Tablets with Silead touchscreens" >>> - depends on ACPI && DMI && I2C && INPUT >>> + depends on ACPI && DMI && I2C=y && INPUT >>> ---help--- >>> Certain ACPI based tablets with Silead touchscreens do not have >>> enough data in ACPI tables for the touchscreen driver to handle >>> >> > > >
On Thu, Feb 2, 2017 at 5:10 PM, Hans de Goede <hdegoede@redhat.com> wrote: > On 02-02-17 16:01, Andy Shevchenko wrote: >> On Thu, Feb 2, 2017 at 4:45 PM, Hans de Goede <hdegoede@redhat.com> wrote: >>> Thank you. >>> >>> Acked-by: Hans de Goede <hdegoede@redhat.com> >> >> >> I'm a bit confused now: >> >> http://www.spinics.net/lists/platform-driver-x86/msg10408.html >> >> Please, clarify. > > The depends on INPUT is not entirely wrong, the module does not > need it, but without the SILEAD driver being build the silead_dmi > code is of no use. Since multiple people already reported this > I thought it would be best to just go ahead with Arnd's version. Thanks, pushed to testing.
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index dd4952ac8797..a7fe9b9f975d 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3 config SILEAD_DMI bool "Tablets with Silead touchscreens" - depends on ACPI && DMI && I2C && INPUT + depends on ACPI && DMI && I2C=y && INPUT ---help--- Certain ACPI based tablets with Silead touchscreens do not have enough data in ACPI tables for the touchscreen driver to handle
The new driver cannot be a loadable module, so if I2C is loadable, we get this link error: drivers/platform/built-in.o: In function `silead_ts_dmi_init': silead_dmi.c:(.init.text+0x2ef): undefined reference to `i2c_bus_type' This makes the Kconfig dependency stricter to require I2C=y. Fixes: 9eeda3897a85 ("platform/x86: add support for devices with Silead touchscreens") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)