| Message ID | 20170207080748.9524-1-andi.shyti@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 379f831a927817c130a62e3ca0082ae685557324 |
| Headers | show |
On Tue, Feb 07, 2017 at 05:07:48PM +0900, Andi Shyti wrote: > Commit a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS > line is not connected") introduced an inconsistency between the > binding where the disconnected CS line was marked as > 'no-cs-readback' while the driver was erroneously checking for > 'broken-cs'. Please describe in one sentence the visible output of this error to justify backporting and then: Fixes: a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS line is not connected") Cc: <stable@vger.kernel.org> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index b8cd356d8d10..b392cca8fa4f 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -969,7 +969,7 @@ static struct s3c64xx_spi_info *s3c64xx_spi_parse_dt(struct device *dev) sci->num_cs = temp; } - sci->no_cs = of_property_read_bool(dev->of_node, "broken-cs"); + sci->no_cs = of_property_read_bool(dev->of_node, "no-cs-readback"); return sci; }
Commit a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS line is not connected") introduced an inconsistency between the binding where the disconnected CS line was marked as 'no-cs-readback' while the driver was erroneously checking for 'broken-cs'. Check for 'no-cs-readback' in the driver as well. Signed-off-by: Andi Shyti <andi.shyti@samsung.com> --- drivers/spi/spi-s3c64xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)