| Message ID | e2c150ce1312a524ea0a524f3d476f910333ae82.1486327509.git.chunkeey@googlemail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Sun, Feb 05, 2017 at 10:03:15PM +0100, Christian Lamparter wrote: > This patch updates the LM90's devicetree definition to > include the #thermal-sensor-cells property as well as > the sensor constants in include/dt-bindings/thermal/lm90.h. > > Cc: Wei Ni <wni@nvidia.com> > Signed-off-by: Christian Lamparter <chunkeey@googlemail.com> > --- > I'm aware that there was atleast one previous attempt to add > thermal_zone temperature sensors for the LM90 module. This was > discussed on: > <http://www.gossamer-threads.com/lists/linux/kernel/1992853> > <https://lkml.org/lkml/2014/3/4/194> > > This RFC is meant to get it going again. As I would really > like to have this functionality for the Netgear WNDR4700. > This router uses a G781 to measure the SoCs temperature > in order to regulate a TC654 fan-controller. > <https://git.lede-project.org/?p=source.git;a=commit;h=9e0fd1b52ad1f805a308bf6a5a13236f352fd962> > --- > Documentation/devicetree/bindings/hwmon/lm90.txt | 6 ++++++ > MAINTAINERS | 1 + > include/dt-bindings/thermal/lm90.h | 12 ++++++++++++ > 3 files changed, 19 insertions(+) > create mode 100644 include/dt-bindings/thermal/lm90.h Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday, February 8, 2017 4:30:34 PM CET Rob Herring wrote: > On Sun, Feb 05, 2017 at 10:03:15PM +0100, Christian Lamparter wrote: > > This patch updates the LM90's devicetree definition to > > include the #thermal-sensor-cells property as well as > > the sensor constants in include/dt-bindings/thermal/lm90.h. > > > > Cc: Wei Ni <wni@nvidia.com> > > Signed-off-by: Christian Lamparter <chunkeey@googlemail.com> > > --- > > I'm aware that there was atleast one previous attempt to add > > thermal_zone temperature sensors for the LM90 module. This was > > discussed on: > > <http://www.gossamer-threads.com/lists/linux/kernel/1992853> > > <https://lkml.org/lkml/2014/3/4/194> > > > > This RFC is meant to get it going again. As I would really > > like to have this functionality for the Netgear WNDR4700. > > This router uses a G781 to measure the SoCs temperature > > in order to regulate a TC654 fan-controller. > > <https://git.lede-project.org/?p=source.git;a=commit;h=9e0fd1b52ad1f805a308bf6a5a13236f352fd962> > > --- > > Documentation/devicetree/bindings/hwmon/lm90.txt | 6 ++++++ > > MAINTAINERS | 1 + > > include/dt-bindings/thermal/lm90.h | 12 ++++++++++++ > > 3 files changed, 19 insertions(+) > > create mode 100644 include/dt-bindings/thermal/lm90.h > > Acked-by: Rob Herring <robh@kernel.org> > Ok thanks. Just a quick note: Don't apply this yet. I'm working on a patch, but this has to wait for the weekend. OnT: From Guenter Roeck: > Sure, no problem with that. Does supporting this require changes in the hwmon > core ? No changes to hwmon's core are required. It's basically this 1/1 patch with +#define LM90_LOCAL_TEMPERATURE 1 (updated to 0) +#define LM90_REMOTE_TEMPERATURE 0 (updated to 1) swapped and a small update to lm90.c. This way the defines are doing something in the driver [0]: static const u8 lm90_temp_index[3] = { LOCAL_TEMP, REMOTE_TEMP, REMOTE2_TEMP }; will become something like: static const u8 lm90_temp_index[3] = { [LM90_LOCAL_TEMPERATURE] = LOCAL_TEMP, [LM90_REMOTE_TEMPERATURE] = REMOTE_TEMP, [LM90_REMOTE2_TEMPERATURE] = REMOTE2_TEMP }; Regards, Christian [0] <http://lxr.free-electrons.com/source/drivers/hwmon/lm90.c#L1018> -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/hwmon/lm90.txt b/Documentation/devicetree/bindings/hwmon/lm90.txt index e8632486b9ef..97581266e329 100644 --- a/Documentation/devicetree/bindings/hwmon/lm90.txt +++ b/Documentation/devicetree/bindings/hwmon/lm90.txt @@ -33,6 +33,11 @@ Optional properties: LM90 "-ALERT" pin output. See interrupt-controller/interrupts.txt for the format. +- #thermal-sensor-cells: should be set to 1. See thermal/thermal.txt for + details. See <include/dt-bindings/thermal/lm90.h> for the + definition of the local, remote and 2nd remote sensor index + constants. + Example LM90 node: temp-sensor { @@ -41,4 +46,5 @@ temp-sensor { vcc-supply = <&palmas_ldo6_reg>; interrupt-parent = <&gpio>; interrupts = <TEGRA_GPIO(O, 4) IRQ_TYPE_LEVEL_LOW>; + #thermal-sensor-cells = <1>; } diff --git a/MAINTAINERS b/MAINTAINERS index 5e637e2b3ff9..8c2ea8a18064 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7541,6 +7541,7 @@ S: Maintained F: Documentation/hwmon/lm90 F: Documentation/devicetree/bindings/hwmon/lm90.txt F: drivers/hwmon/lm90.c +F: include/dt-bindings/thermal/lm90.h LM95234 HARDWARE MONITOR DRIVER M: Guenter Roeck <linux@roeck-us.net> diff --git a/include/dt-bindings/thermal/lm90.h b/include/dt-bindings/thermal/lm90.h new file mode 100644 index 000000000000..39d90f3e63ee --- /dev/null +++ b/include/dt-bindings/thermal/lm90.h @@ -0,0 +1,12 @@ +/* + * This header provides constants for the LM90 thermal bindings. + */ + +#ifndef _DT_BINDINGS_THERMAL_LM90_H_ +#define _DT_BINDINGS_THERMAL_LM90_H_ + +#define LM90_REMOTE_TEMPERATURE 0 +#define LM90_LOCAL_TEMPERATURE 1 +#define LM90_REMOTE2_TEMPERATURE 2 + +#endif
This patch updates the LM90's devicetree definition to include the #thermal-sensor-cells property as well as the sensor constants in include/dt-bindings/thermal/lm90.h. Cc: Wei Ni <wni@nvidia.com> Signed-off-by: Christian Lamparter <chunkeey@googlemail.com> --- I'm aware that there was atleast one previous attempt to add thermal_zone temperature sensors for the LM90 module. This was discussed on: <http://www.gossamer-threads.com/lists/linux/kernel/1992853> <https://lkml.org/lkml/2014/3/4/194> This RFC is meant to get it going again. As I would really like to have this functionality for the Netgear WNDR4700. This router uses a G781 to measure the SoCs temperature in order to regulate a TC654 fan-controller. <https://git.lede-project.org/?p=source.git;a=commit;h=9e0fd1b52ad1f805a308bf6a5a13236f352fd962> --- Documentation/devicetree/bindings/hwmon/lm90.txt | 6 ++++++ MAINTAINERS | 1 + include/dt-bindings/thermal/lm90.h | 12 ++++++++++++ 3 files changed, 19 insertions(+) create mode 100644 include/dt-bindings/thermal/lm90.h