| Message ID | 1306542839-5688-1-git-send-email-khilman@ti.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Saturday, May 28, 2011, Kevin Hilman wrote: > Some platforms wish to implement their PM core suspend code as > modules. To do so, these functions need to be exported to modules. > > Reported-by: Jean Pihet <j-pihet@ti.com> > Signed-off-by: Kevin Hilman <khilman@ti.com> Applied to suspend-2.6/linux-next. Thanks, Rafael > --- > Applies against v2.6.39 > > kernel/power/suspend.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c > index 6275970..eca495d 100644 > --- a/kernel/power/suspend.c > +++ b/kernel/power/suspend.c > @@ -44,6 +44,7 @@ void suspend_set_ops(const struct platform_suspend_ops *ops) > suspend_ops = ops; > mutex_unlock(&pm_mutex); > } > +EXPORT_SYMBOL(suspend_set_ops); > > bool valid_state(suspend_state_t state) > { > @@ -65,6 +66,7 @@ int suspend_valid_only_mem(suspend_state_t state) > { > return state == PM_SUSPEND_MEM; > } > +EXPORT_SYMBOL(suspend_valid_only_mem); > > static int suspend_test(int level) > { >
On Sun 2011-06-12 16:20:20, Rafael J. Wysocki wrote: > On Saturday, May 28, 2011, Kevin Hilman wrote: > > Some platforms wish to implement their PM core suspend code as > > modules. To do so, these functions need to be exported to modules. > > > > Reported-by: Jean Pihet <j-pihet@ti.com> > > Signed-off-by: Kevin Hilman <khilman@ti.com> > > Applied to suspend-2.6/linux-next. I'd do export_symbol_gpl on those; it is really tightly coupled... pavel > > @@ -44,6 +44,7 @@ void suspend_set_ops(const struct platform_suspend_ops *ops) > > suspend_ops = ops; > > mutex_unlock(&pm_mutex); > > } > > +EXPORT_SYMBOL(suspend_set_ops); > > > > bool valid_state(suspend_state_t state) > > {
On Sunday, June 26, 2011, Pavel Machek wrote: > On Sun 2011-06-12 16:20:20, Rafael J. Wysocki wrote: > > On Saturday, May 28, 2011, Kevin Hilman wrote: > > > Some platforms wish to implement their PM core suspend code as > > > modules. To do so, these functions need to be exported to modules. > > > > > > Reported-by: Jean Pihet <j-pihet@ti.com> > > > Signed-off-by: Kevin Hilman <khilman@ti.com> > > > > Applied to suspend-2.6/linux-next. > > I'd do export_symbol_gpl on those; it is really tightly coupled... Good point, thanks, I'll fix this up. Rafael
diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c index 6275970..eca495d 100644 --- a/kernel/power/suspend.c +++ b/kernel/power/suspend.c @@ -44,6 +44,7 @@ void suspend_set_ops(const struct platform_suspend_ops *ops) suspend_ops = ops; mutex_unlock(&pm_mutex); } +EXPORT_SYMBOL(suspend_set_ops); bool valid_state(suspend_state_t state) { @@ -65,6 +66,7 @@ int suspend_valid_only_mem(suspend_state_t state) { return state == PM_SUSPEND_MEM; } +EXPORT_SYMBOL(suspend_valid_only_mem); static int suspend_test(int level) {
Some platforms wish to implement their PM core suspend code as modules. To do so, these functions need to be exported to modules. Reported-by: Jean Pihet <j-pihet@ti.com> Signed-off-by: Kevin Hilman <khilman@ti.com> --- Applies against v2.6.39 kernel/power/suspend.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)