diff mbox

PM: export suspend_set_ops, suspend_valid_only_mem

Message ID 1306542839-5688-1-git-send-email-khilman@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kevin Hilman May 28, 2011, 12:33 a.m. UTC
Some platforms wish to implement their PM core suspend code as
modules.  To do so, these functions need to be exported to modules.

Reported-by: Jean Pihet <j-pihet@ti.com>
Signed-off-by: Kevin Hilman <khilman@ti.com>
---
Applies against v2.6.39

 kernel/power/suspend.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Rafael Wysocki June 12, 2011, 2:20 p.m. UTC | #1
On Saturday, May 28, 2011, Kevin Hilman wrote:
> Some platforms wish to implement their PM core suspend code as
> modules.  To do so, these functions need to be exported to modules.
> 
> Reported-by: Jean Pihet <j-pihet@ti.com>
> Signed-off-by: Kevin Hilman <khilman@ti.com>

Applied to suspend-2.6/linux-next.

Thanks,
Rafael


> ---
> Applies against v2.6.39
> 
>  kernel/power/suspend.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
> index 6275970..eca495d 100644
> --- a/kernel/power/suspend.c
> +++ b/kernel/power/suspend.c
> @@ -44,6 +44,7 @@ void suspend_set_ops(const struct platform_suspend_ops *ops)
>  	suspend_ops = ops;
>  	mutex_unlock(&pm_mutex);
>  }
> +EXPORT_SYMBOL(suspend_set_ops);
>  
>  bool valid_state(suspend_state_t state)
>  {
> @@ -65,6 +66,7 @@ int suspend_valid_only_mem(suspend_state_t state)
>  {
>  	return state == PM_SUSPEND_MEM;
>  }
> +EXPORT_SYMBOL(suspend_valid_only_mem);
>  
>  static int suspend_test(int level)
>  {
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pavel Machek June 26, 2011, 11:08 a.m. UTC | #2
On Sun 2011-06-12 16:20:20, Rafael J. Wysocki wrote:
> On Saturday, May 28, 2011, Kevin Hilman wrote:
> > Some platforms wish to implement their PM core suspend code as
> > modules.  To do so, these functions need to be exported to modules.
> > 
> > Reported-by: Jean Pihet <j-pihet@ti.com>
> > Signed-off-by: Kevin Hilman <khilman@ti.com>
> 
> Applied to suspend-2.6/linux-next.

I'd do export_symbol_gpl on those; it is really tightly coupled...

       			    	      pavel

> > @@ -44,6 +44,7 @@ void suspend_set_ops(const struct platform_suspend_ops *ops)
> >  	suspend_ops = ops;
> >  	mutex_unlock(&pm_mutex);
> >  }
> > +EXPORT_SYMBOL(suspend_set_ops);
> >  
> >  bool valid_state(suspend_state_t state)
> >  {
Rafael Wysocki June 26, 2011, 12:22 p.m. UTC | #3
On Sunday, June 26, 2011, Pavel Machek wrote:
> On Sun 2011-06-12 16:20:20, Rafael J. Wysocki wrote:
> > On Saturday, May 28, 2011, Kevin Hilman wrote:
> > > Some platforms wish to implement their PM core suspend code as
> > > modules.  To do so, these functions need to be exported to modules.
> > > 
> > > Reported-by: Jean Pihet <j-pihet@ti.com>
> > > Signed-off-by: Kevin Hilman <khilman@ti.com>
> > 
> > Applied to suspend-2.6/linux-next.
> 
> I'd do export_symbol_gpl on those; it is really tightly coupled...

Good point, thanks, I'll fix this up.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
index 6275970..eca495d 100644
--- a/kernel/power/suspend.c
+++ b/kernel/power/suspend.c
@@ -44,6 +44,7 @@  void suspend_set_ops(const struct platform_suspend_ops *ops)
 	suspend_ops = ops;
 	mutex_unlock(&pm_mutex);
 }
+EXPORT_SYMBOL(suspend_set_ops);
 
 bool valid_state(suspend_state_t state)
 {
@@ -65,6 +66,7 @@  int suspend_valid_only_mem(suspend_state_t state)
 {
 	return state == PM_SUSPEND_MEM;
 }
+EXPORT_SYMBOL(suspend_valid_only_mem);
 
 static int suspend_test(int level)
 {